test: allow overriding tar in get_previous_releases.py #34390

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:tar_override_get_prev changing 1 files +3 −1
  1. fanquake commented at 1:36 pm on January 23, 2026: member
    Facilitate use on distros that might have tar as something else, such as gtar, i.e Chimera.
  2. test: allow overriding tar in get_previous_releases
    Facilitate use on distros that might have 'tar' as something else, such
    as 'gtar', i.e Chimera.
    be2b48b9f3
  3. DrahtBot added the label Tests on Jan 23, 2026
  4. DrahtBot commented at 1:36 pm on January 23, 2026: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34390.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK hebasto, maflcko, sedited

    If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

  5. hebasto approved
  6. hebasto commented at 1:53 pm on January 23, 2026: member

    ACK be2b48b9f3e56b672e391e18a09f2d5f4e78d74e, I have reviewed the code and it looks OK.

    It is worth documenting the specific implementation, as others (such as those on SmartOS) might be incompatible:

     0--- a/test/get_previous_releases.py
     1+++ b/test/get_previous_releases.py
     2@@ -5,7 +5,7 @@
     3 # file COPYING or http://www.opensource.org/licenses/mit-license.php.
     4 #
     5 # Download or build previous releases.
     6-# Needs curl and tar to download a release, or the build dependencies when
     7+# Needs curl and GNU tar to download a release, or the build dependencies when
     8 # building a release.
     9 
    10 import argparse
    
  7. maflcko commented at 2:08 pm on January 23, 2026: member
    lgtm ACK be2b48b9f3e56b672e391e18a09f2d5f4e78d74e
  8. sedited approved
  9. sedited commented at 11:26 am on January 25, 2026: contributor
    ACK be2b48b9f3e56b672e391e18a09f2d5f4e78d74e
  10. hebasto merged this on Jan 25, 2026
  11. hebasto closed this on Jan 25, 2026

  12. fanquake deleted the branch on Jan 26, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-01-27 06:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me