Facilitate use on distros that might have tar as something else, such as gtar, i.e Chimera.
test: allow overriding `tar` in `get_previous_releases.py` #34390
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:tar_override_get_prev changing 1 files +3 −1-
fanquake commented at 1:36 PM on January 23, 2026: member
-
be2b48b9f3
test: allow overriding tar in get_previous_releases
Facilitate use on distros that might have 'tar' as something else, such as 'gtar', i.e Chimera.
- DrahtBot added the label Tests on Jan 23, 2026
-
DrahtBot commented at 1:36 PM on January 23, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34390.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- hebasto approved
-
hebasto commented at 1:53 PM on January 23, 2026: member
ACK be2b48b9f3e56b672e391e18a09f2d5f4e78d74e, I have reviewed the code and it looks OK.
It is worth documenting the specific implementation, as others (such as those on SmartOS) might be incompatible:
--- a/test/get_previous_releases.py +++ b/test/get_previous_releases.py @@ -5,7 +5,7 @@ # file COPYING or http://www.opensource.org/licenses/mit-license.php. # # Download or build previous releases. -# Needs curl and tar to download a release, or the build dependencies when +# Needs curl and GNU tar to download a release, or the build dependencies when # building a release. import argparse -
maflcko commented at 2:08 PM on January 23, 2026: member
lgtm ACK be2b48b9f3e56b672e391e18a09f2d5f4e78d74e
- sedited approved
-
sedited commented at 11:26 AM on January 25, 2026: contributor
ACK be2b48b9f3e56b672e391e18a09f2d5f4e78d74e
- hebasto merged this on Jan 25, 2026
- hebasto closed this on Jan 25, 2026
- fanquake deleted the branch on Jan 26, 2026
