iwyu: Fix patch to prefer <cstdint> #34498

1. 
   hebasto commented at 8:31 am on February 4, 2026: member

   The goal of the patch is to suggest C++ headers rather than their C counterparts. However, for fixed width integer types, the patched IWYU currently suggests <cinttypes> where <cstdint> is sufficient.

   This PR fixes this behavior.

2. iwyu: Fix patch to prefer `<cstdint>`

   The goal of the patch is to suggest C++ headers rather than their C
   counterparts. However, for fixed width integer types, the patched IWYU
   currently suggests `<cinttypes>` where `<cstdint>` is sufficient.
   
   This change fixes this behavior.

   b65a3d8009
3. 
   DrahtBot commented at 8:32 am on February 4, 2026: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	maflcko, furszy, willcl-ark

   If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

4. 
   hebasto commented at 8:34 am on February 4, 2026: member

   cc @furszy
5. 
   hebasto commented at 8:53 am on February 4, 2026: member

   So far, a suboptimal IWYU suggestion was applied in only one place: https://github.com/bitcoin/bitcoin/blob/3532e242134e8f92fb5fe99bbd024ed185839e8c/src/test/fuzz/util/descriptor.h#L9

   I plan to fix this, along with the rest of the src/test/fuzz/util directory, after landing #34448.

6. 
   maflcko commented at 9:28 am on February 4, 2026: member

   lgtm ACK b65a3d80093b992a2574d5762a8cd03ce2eb4412
7. 
   furszy commented at 3:59 pm on February 5, 2026: member

   utACK b65a3d80093b992a2574d5762a8cd03ce2eb4412
8. 
   fanquake commented at 4:24 pm on February 5, 2026: member

   Are we sending this upstream, or going to start maintaining a divergence in behaviour (assuming other similar changes happen)?
9. 
   hebasto commented at 4:28 pm on February 5, 2026: member

   Are we sending this upstream, or going to start maintaining a divergence in behaviour (assuming other similar changes happen)?

   The issue is specific to us only as it was introduced by our patch.

10. willcl-ark approved
11. 
    willcl-ark commented at 1:35 pm on February 6, 2026: member

    utACK b65a3d80093b992a2574d5762a8cd03ce2eb4412

    Marking <cstdint> as kPublic means IWYU will suggest it directly rather than redirecting to <cinttypes>, which is what we want here.

12. fanquake merged this on Feb 6, 2026
13. fanquake closed this on Feb 6, 2026

    ---

14. hebasto deleted the branch on Feb 6, 2026

Contributors
hebasto DrahtBot maflcko furszy fanquake willcl-ark