iwyu: Fix patch to prefer `<cstdint>` #34498

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:260204-fix-patch changing 1 files +1 −1

hebasto commented at 8:31 AM on February 4, 2026: member

The goal of the patch is to suggest C++ headers rather than their C counterparts. However, for fixed width integer types, the patched IWYU currently suggests <cinttypes> where <cstdint> is sufficient.

This PR fixes this behavior.

iwyu: Fix patch to prefer `<cstdint>`

The goal of the patch is to suggest C++ headers rather than their C
counterparts. However, for fixed width integer types, the patched IWYU
currently suggests `<cinttypes>` where `<cstdint>` is sufficient.

This change fixes this behavior.

b65a3d8009

DrahtBot commented at 8:32 AM on February 4, 2026: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK maflcko, furszy, willcl-ark

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.
hebasto commented at 8:34 AM on February 4, 2026: member

cc @furszy
hebasto commented at 8:53 AM on February 4, 2026: member

So far, a suboptimal IWYU suggestion was applied in only one place: https://github.com/bitcoin/bitcoin/blob/3532e242134e8f92fb5fe99bbd024ed185839e8c/src/test/fuzz/util/descriptor.h#L9

I plan to fix this, along with the rest of the src/test/fuzz/util directory, after landing #34448.
maflcko commented at 9:28 AM on February 4, 2026: member

lgtm ACK b65a3d80093b992a2574d5762a8cd03ce2eb4412
furszy commented at 3:59 PM on February 5, 2026: member

utACK b65a3d80093b992a2574d5762a8cd03ce2eb4412
fanquake commented at 4:24 PM on February 5, 2026: member

Are we sending this upstream, or going to start maintaining a divergence in behaviour (assuming other similar changes happen)?
hebasto commented at 4:28 PM on February 5, 2026: member

Are we sending this upstream, or going to start maintaining a divergence in behaviour (assuming other similar changes happen)?

The issue is specific to us only as it was introduced by our patch.
willcl-ark approved
willcl-ark commented at 1:35 PM on February 6, 2026: member

utACK b65a3d80093b992a2574d5762a8cd03ce2eb4412

Marking <cstdint> as kPublic means IWYU will suggest it directly rather than redirecting to <cinttypes>, which is what we want here.
fanquake merged this on Feb 6, 2026
fanquake closed this on Feb 6, 2026
hebasto deleted the branch on Feb 6, 2026

Type	Reviewers
ACK	maflcko, furszy, willcl-ark

Contributors

iwyu: Fix patch to prefer `<cstdint>` #34498

Reviews