guix: remove double export of `TZ` #34604

fanquake commented at 10:01 AM on February 17, 2026: member

Remove a double export of TZ and fix a typo.

guix: fix typo in guix-codesign badcf1c68d

guix: don't export TZ twice 62e378584e

DrahtBot added the label Build system on Feb 17, 2026

DrahtBot commented at 10:01 AM on February 17, 2026: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	janb84, hebasto

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.

janb84 commented at 3:15 PM on February 17, 2026: contributor

My Guix build output

Host architecture: aarch64 Commit: 62e3785

44f5f733c6eb580a57f8654c1d65575e16eb59f11479ae41161c13231caf369a  guix-build-62e378584e77/output/aarch64-linux-gnu/SHA256SUMS.part
151607fd8f149a91e6628028a4378172d09a185575a2384cbf9f7f6e96f77670  guix-build-62e378584e77/output/aarch64-linux-gnu/bitcoin-62e378584e77-aarch64-linux-gnu-debug.tar.gz
0dccef2b27f885d7bec5a7a92e189eecf381b9b1c18fcc6d6689a0025e61f9da  guix-build-62e378584e77/output/aarch64-linux-gnu/bitcoin-62e378584e77-aarch64-linux-gnu.tar.gz
43dc6c58ea82417ba827c43a4eb763f74b43c17b91cd2c013ad0bb843e172714  guix-build-62e378584e77/output/arm-linux-gnueabihf/SHA256SUMS.part
b1e967b9aa438783e4b88df3c7d2808a79d0c39ed1a8f192090467160f138c18  guix-build-62e378584e77/output/arm-linux-gnueabihf/bitcoin-62e378584e77-arm-linux-gnueabihf-debug.tar.gz
77633ea6a9dd674b525aa1a753202ee4a4306a1f342d6ac4623f4c003a56cd5e  guix-build-62e378584e77/output/arm-linux-gnueabihf/bitcoin-62e378584e77-arm-linux-gnueabihf.tar.gz
f72bc3a91db4947868c1222c84e5e34672632b6b6f850dc16e6c9827abb95d29  guix-build-62e378584e77/output/arm64-apple-darwin/SHA256SUMS.part
92637787df8ff8317e2d9b6acfa46aee8056aa377d34294cbf79a919fa200a1e  guix-build-62e378584e77/output/arm64-apple-darwin/bitcoin-62e378584e77-arm64-apple-darwin-codesigning.tar.gz
1fcf13fe5139209ae6fd3813396ecff12799c1c716f2f2fce2e2bf83a89ec386  guix-build-62e378584e77/output/arm64-apple-darwin/bitcoin-62e378584e77-arm64-apple-darwin-unsigned.tar.gz
6407bb5d714e4f681df1ee01e1ee13c22d22549783d79d88c27c984d7ad2c1cd  guix-build-62e378584e77/output/arm64-apple-darwin/bitcoin-62e378584e77-arm64-apple-darwin-unsigned.zip
b6d48d46b3a444457848bb78ff38ae246432cac235ffe9c469b645e79c3aaae1  guix-build-62e378584e77/output/dist-archive/bitcoin-62e378584e77.tar.gz
af7360dfbe3f529b4836108db43a0329aa71341aef6e83a838955e59e3b2505e  guix-build-62e378584e77/output/powerpc64-linux-gnu/SHA256SUMS.part
8b382d12d42ee046b38ef3091996c8a0310cb9a447e1317be0ce769adfcb9605  guix-build-62e378584e77/output/powerpc64-linux-gnu/bitcoin-62e378584e77-powerpc64-linux-gnu-debug.tar.gz
e9fdb3ff69da47c3242d57f19f9aaf7333ea9ae3cd0dea0a5479aaaf60d06a75  guix-build-62e378584e77/output/powerpc64-linux-gnu/bitcoin-62e378584e77-powerpc64-linux-gnu.tar.gz
632c55ef0b2a0101b05c10e79edc3401c11b354253d0f446d38df4a1a395a56e  guix-build-62e378584e77/output/riscv64-linux-gnu/SHA256SUMS.part
0a34e20b6e76070c94bdf566358d882def16aec515a4f82ccc0cb33beefe2f52  guix-build-62e378584e77/output/riscv64-linux-gnu/bitcoin-62e378584e77-riscv64-linux-gnu-debug.tar.gz
161ba95907965e5c8afe0f766f9c478a71f9f98e8c867ca4aa7f8b586ab5ec09  guix-build-62e378584e77/output/riscv64-linux-gnu/bitcoin-62e378584e77-riscv64-linux-gnu.tar.gz
aeea4b997d7c6202ee77cc3aeede6e725e327d0a4a4512d9e88cb754a513bed0  guix-build-62e378584e77/output/x86_64-apple-darwin/SHA256SUMS.part
1553cc3c8248a0c8c9e4d3f08e42de6c2d96d217f4d88b31b67440549dc0c809  guix-build-62e378584e77/output/x86_64-apple-darwin/bitcoin-62e378584e77-x86_64-apple-darwin-codesigning.tar.gz
ce44a60a7893fb71684118b769533e9a20bcf36d860eb4094be0122818f4ebf9  guix-build-62e378584e77/output/x86_64-apple-darwin/bitcoin-62e378584e77-x86_64-apple-darwin-unsigned.tar.gz
b109caf38a5764161b1617276179ec53b1ecc98c523b321bae9eb4bb1ad76c98  guix-build-62e378584e77/output/x86_64-apple-darwin/bitcoin-62e378584e77-x86_64-apple-darwin-unsigned.zip
65218d439eac56af4b37c5abb7ead3e4e82252e7db12588f088a507bebc833d3  guix-build-62e378584e77/output/x86_64-linux-gnu/SHA256SUMS.part
f8ceba4f4dde5d9864b4526d69652dd99f8810dfd4e5d1c19bc2e044d789e06d  guix-build-62e378584e77/output/x86_64-linux-gnu/bitcoin-62e378584e77-x86_64-linux-gnu-debug.tar.gz
a6d1639260a05559bfecd8713d1e827a850185745db105fa8655bef9b97bfec1  guix-build-62e378584e77/output/x86_64-linux-gnu/bitcoin-62e378584e77-x86_64-linux-gnu.tar.gz
d7cd502108fe8479860567b3344edafe3d314bc02749a96dabc8cc3d89f6d5b0  guix-build-62e378584e77/output/x86_64-w64-mingw32/SHA256SUMS.part
776b91e9adb6e80b0ad2cdde0965fd7583e0a74d91f0e9c87ef8bab3973f9ce8  guix-build-62e378584e77/output/x86_64-w64-mingw32/bitcoin-62e378584e77-win64-codesigning.tar.gz
9ce0ce7a3c8977d5cd8cde6dbf23b00df409e508aabdb90e7d5d2075d30b8ba6  guix-build-62e378584e77/output/x86_64-w64-mingw32/bitcoin-62e378584e77-win64-debug.zip
d2d79d2ac7c530fe2b8f601df43bea35909558ae8f68ceb47c6e059bb82c6736  guix-build-62e378584e77/output/x86_64-w64-mingw32/bitcoin-62e378584e77-win64-setup-unsigned.exe
9d865b103182cba911ae002382fc74cfb518001d9c64e78e69178324432837f8  guix-build-62e378584e77/output/x86_64-w64-mingw32/bitcoin-62e378584e77-win64-unsigned.zip

janb84 commented at 3:17 PM on February 17, 2026: contributor

ACK 62e378584e77cb8382facc6a7c18133d1cf9ffb3

Deduplication and the move of some code. Guix still builds, lgtm.

fanquake commented at 4:25 PM on February 17, 2026: member

Guix build (x86_64):

44f5f733c6eb580a57f8654c1d65575e16eb59f11479ae41161c13231caf369a  guix-build-62e378584e77/output/aarch64-linux-gnu/SHA256SUMS.part
151607fd8f149a91e6628028a4378172d09a185575a2384cbf9f7f6e96f77670  guix-build-62e378584e77/output/aarch64-linux-gnu/bitcoin-62e378584e77-aarch64-linux-gnu-debug.tar.gz
0dccef2b27f885d7bec5a7a92e189eecf381b9b1c18fcc6d6689a0025e61f9da  guix-build-62e378584e77/output/aarch64-linux-gnu/bitcoin-62e378584e77-aarch64-linux-gnu.tar.gz
43dc6c58ea82417ba827c43a4eb763f74b43c17b91cd2c013ad0bb843e172714  guix-build-62e378584e77/output/arm-linux-gnueabihf/SHA256SUMS.part
b1e967b9aa438783e4b88df3c7d2808a79d0c39ed1a8f192090467160f138c18  guix-build-62e378584e77/output/arm-linux-gnueabihf/bitcoin-62e378584e77-arm-linux-gnueabihf-debug.tar.gz
77633ea6a9dd674b525aa1a753202ee4a4306a1f342d6ac4623f4c003a56cd5e  guix-build-62e378584e77/output/arm-linux-gnueabihf/bitcoin-62e378584e77-arm-linux-gnueabihf.tar.gz
f72bc3a91db4947868c1222c84e5e34672632b6b6f850dc16e6c9827abb95d29  guix-build-62e378584e77/output/arm64-apple-darwin/SHA256SUMS.part
92637787df8ff8317e2d9b6acfa46aee8056aa377d34294cbf79a919fa200a1e  guix-build-62e378584e77/output/arm64-apple-darwin/bitcoin-62e378584e77-arm64-apple-darwin-codesigning.tar.gz
1fcf13fe5139209ae6fd3813396ecff12799c1c716f2f2fce2e2bf83a89ec386  guix-build-62e378584e77/output/arm64-apple-darwin/bitcoin-62e378584e77-arm64-apple-darwin-unsigned.tar.gz
6407bb5d714e4f681df1ee01e1ee13c22d22549783d79d88c27c984d7ad2c1cd  guix-build-62e378584e77/output/arm64-apple-darwin/bitcoin-62e378584e77-arm64-apple-darwin-unsigned.zip
b6d48d46b3a444457848bb78ff38ae246432cac235ffe9c469b645e79c3aaae1  guix-build-62e378584e77/output/dist-archive/bitcoin-62e378584e77.tar.gz
af7360dfbe3f529b4836108db43a0329aa71341aef6e83a838955e59e3b2505e  guix-build-62e378584e77/output/powerpc64-linux-gnu/SHA256SUMS.part
8b382d12d42ee046b38ef3091996c8a0310cb9a447e1317be0ce769adfcb9605  guix-build-62e378584e77/output/powerpc64-linux-gnu/bitcoin-62e378584e77-powerpc64-linux-gnu-debug.tar.gz
e9fdb3ff69da47c3242d57f19f9aaf7333ea9ae3cd0dea0a5479aaaf60d06a75  guix-build-62e378584e77/output/powerpc64-linux-gnu/bitcoin-62e378584e77-powerpc64-linux-gnu.tar.gz
632c55ef0b2a0101b05c10e79edc3401c11b354253d0f446d38df4a1a395a56e  guix-build-62e378584e77/output/riscv64-linux-gnu/SHA256SUMS.part
0a34e20b6e76070c94bdf566358d882def16aec515a4f82ccc0cb33beefe2f52  guix-build-62e378584e77/output/riscv64-linux-gnu/bitcoin-62e378584e77-riscv64-linux-gnu-debug.tar.gz
161ba95907965e5c8afe0f766f9c478a71f9f98e8c867ca4aa7f8b586ab5ec09  guix-build-62e378584e77/output/riscv64-linux-gnu/bitcoin-62e378584e77-riscv64-linux-gnu.tar.gz
aeea4b997d7c6202ee77cc3aeede6e725e327d0a4a4512d9e88cb754a513bed0  guix-build-62e378584e77/output/x86_64-apple-darwin/SHA256SUMS.part
1553cc3c8248a0c8c9e4d3f08e42de6c2d96d217f4d88b31b67440549dc0c809  guix-build-62e378584e77/output/x86_64-apple-darwin/bitcoin-62e378584e77-x86_64-apple-darwin-codesigning.tar.gz
ce44a60a7893fb71684118b769533e9a20bcf36d860eb4094be0122818f4ebf9  guix-build-62e378584e77/output/x86_64-apple-darwin/bitcoin-62e378584e77-x86_64-apple-darwin-unsigned.tar.gz
b109caf38a5764161b1617276179ec53b1ecc98c523b321bae9eb4bb1ad76c98  guix-build-62e378584e77/output/x86_64-apple-darwin/bitcoin-62e378584e77-x86_64-apple-darwin-unsigned.zip
65218d439eac56af4b37c5abb7ead3e4e82252e7db12588f088a507bebc833d3  guix-build-62e378584e77/output/x86_64-linux-gnu/SHA256SUMS.part
f8ceba4f4dde5d9864b4526d69652dd99f8810dfd4e5d1c19bc2e044d789e06d  guix-build-62e378584e77/output/x86_64-linux-gnu/bitcoin-62e378584e77-x86_64-linux-gnu-debug.tar.gz
a6d1639260a05559bfecd8713d1e827a850185745db105fa8655bef9b97bfec1  guix-build-62e378584e77/output/x86_64-linux-gnu/bitcoin-62e378584e77-x86_64-linux-gnu.tar.gz
d7cd502108fe8479860567b3344edafe3d314bc02749a96dabc8cc3d89f6d5b0  guix-build-62e378584e77/output/x86_64-w64-mingw32/SHA256SUMS.part
776b91e9adb6e80b0ad2cdde0965fd7583e0a74d91f0e9c87ef8bab3973f9ce8  guix-build-62e378584e77/output/x86_64-w64-mingw32/bitcoin-62e378584e77-win64-codesigning.tar.gz
9ce0ce7a3c8977d5cd8cde6dbf23b00df409e508aabdb90e7d5d2075d30b8ba6  guix-build-62e378584e77/output/x86_64-w64-mingw32/bitcoin-62e378584e77-win64-debug.zip
d2d79d2ac7c530fe2b8f601df43bea35909558ae8f68ceb47c6e059bb82c6736  guix-build-62e378584e77/output/x86_64-w64-mingw32/bitcoin-62e378584e77-win64-setup-unsigned.exe
9d865b103182cba911ae002382fc74cfb518001d9c64e78e69178324432837f8  guix-build-62e378584e77/output/x86_64-w64-mingw32/bitcoin-62e378584e77-win64-unsigned.zip

hebasto approved

hebasto commented at 9:05 PM on February 18, 2026: member

ACK 62e378584e77cb8382facc6a7c18133d1cf9ffb3, I have reviewed the code and it looks OK.

fanquake merged this on Feb 19, 2026

fanquake closed this on Feb 19, 2026

fanquake deleted the branch on Feb 19, 2026