test: remove appveyor reference in comment #34609

pull m3dwards wants to merge 1 commits into bitcoin:master from m3dwards:260217-666-comment changing 1 files +2 −2
  1. m3dwards commented at 10:29 pm on February 17, 2026: contributor

    Appveyor is not longer used however the test still requires to check for permissions including 666 as otherwise the tests fail on Windows

    Fixes: #32576

  2. DrahtBot added the label Tests on Feb 17, 2026
  3. DrahtBot commented at 10:29 pm on February 17, 2026: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, hebasto

    If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

  4. in test/functional/tool_wallet.py:161 in 80208d5552
    157@@ -158,7 +158,7 @@ def test_tool_wallet_info(self):
    158         #
    159         # self.log.debug('Setting wallet file permissions to 400 (read-only)')
    160         # os.chmod(self.wallet_path, stat.S_IRUSR)
    161-        # assert self.wallet_permissions() in ['400', '666'] # Sanity check. 666 because Appveyor.
    162+        # assert self.wallet_permissions() in ['400', '666'] # Sanity check. 666 is for on Windows.
    


    chriszeng1010 commented at 10:59 pm on February 17, 2026:
    This is not grammatically correct.

    m3dwards commented at 5:34 pm on February 26, 2026:
    Reads ok to me but I’ve changed it to “666 on Windows” as I originally proposed in #32576 (comment)
  5. chriszeng1010 commented at 11:00 pm on February 17, 2026: none
    Comment is grammatically incorrect.
  6. test: remove appveyor reference in comment
    Appveyor is not longer used however the test still requires to check for
    permissions including 666 as otherwise the tests fail on Windows
    8834e4e86c
  7. m3dwards force-pushed on Feb 26, 2026
  8. maflcko commented at 6:04 pm on February 26, 2026: member
    lgtm ACK 8834e4e86c851c4eb01a7e978cdbde5b3cbd24cc
  9. DrahtBot added the label CI failed on Feb 26, 2026
  10. hebasto approved
  11. hebasto commented at 9:27 am on February 27, 2026: member
    ACK 8834e4e86c851c4eb01a7e978cdbde5b3cbd24cc.
  12. hebasto merged this on Feb 27, 2026
  13. hebasto closed this on Feb 27, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-03-16 03:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me