Remove db/c.cc, dumpfile.cc & histogram.cc.
leveldb: remove unused files #34612
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:unused_historgram changing 1 files +0 −3-
fanquake commented at 10:55 AM on February 18, 2026: member
-
DrahtBot commented at 10:55 AM on February 18, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK willcl-ark, sedited If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- fanquake force-pushed on Feb 18, 2026
- fanquake renamed this:
leveldb: remove unused `util/histogram.cc`
leveldb: remove unused `db/dumpfile.cc` & `util/histogram.cc`
on Feb 18, 2026 -
fanquake commented at 2:32 PM on February 18, 2026: member
Added
db/dumpfile.cc, which is also unused. -
leveldb: remove unused files 3feabb203a
- fanquake renamed this:
leveldb: remove unused `db/dumpfile.cc` & `util/histogram.cc`
leveldb: remove unused files
on Feb 20, 2026 - fanquake force-pushed on Feb 20, 2026
-
willcl-ark commented at 1:17 PM on February 25, 2026: member
ACK 3feabb203a6e1af9fe03e997782ecb1a5020872d
Looks reasonable to me. As far as I could see these were ported to cmake from autotools, and arrived originally during the leveldb subtree, where autotools just built all files.
Tested a build-and-link without them.
Removing from the build list but keeping the files seems like the best approach, to minimise conflicts during any future subtree bumps.
- sedited approved
-
sedited commented at 8:00 AM on March 6, 2026: contributor
ACK 3feabb203a6e1af9fe03e997782ecb1a5020872d
I think it's good to keep the files around. I do use the utilities sometimes and being able to compile from our subtree is useful.
-
fanquake commented at 10:37 AM on March 6, 2026: member
To make another benefit clear, removing these means that we have less dead code being compiled into the kernel lib.
I do use the utilities sometimes and being able to compile from our subtree is useful.
You might be interested in some of the upstream PRs, i.e: https://github.com/bitcoin-core/leveldb-subtree/pull/55, if you're already working around that locally.
- fanquake merged this on Mar 6, 2026
- fanquake closed this on Mar 6, 2026
- fanquake deleted the branch on Mar 6, 2026
Contributors