guix: re-enable riscv exported symbol checking

fanquake commented at 4:15 pm on March 6, 2026: member

Switching to binutils 2.46.0 fixes the spurious exported symbols (2.45.1 was still broken). Will find the relevant upstream change. No updates on our upstream issue: https://sourceware.org/bugzilla/show_bug.cgi?id=32783.

Fixes #28095.

DrahtBot added the label Build system on Mar 6, 2026

DrahtBot commented at 4:16 pm on March 6, 2026: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	hebasto
Concept ACK	trevarj

If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

Conflicts

No conflicts as of last run.

DrahtBot added the label Needs rebase on Mar 10, 2026

fanquake force-pushed on Mar 10, 2026

DrahtBot removed the label Needs rebase on Mar 10, 2026

guix: binutils 2.46.0 bc10394a89

guix: remove riscv exclusion from symbol check 604e6798fb

fanquake force-pushed on Mar 20, 2026

fanquake marked this as ready for review on Mar 20, 2026

fanquake added the label DrahtBot Guix build requested on Mar 20, 2026

fanquake commented at 0:27 am on March 20, 2026: member

Rebased & ready for review.

fanquake commented at 3:02 am on March 20, 2026: member

Guix build (x86_64):

 06bda9ad0e0e23398975e6b49fc828a723e1ad923f42a136b2b12df372a12b1b8  guix-build-604e6798fb3e/output/aarch64-linux-gnu/SHA256SUMS.part
 1246ab16366ecbecd70d63f047652ebfaf37b7f96f8ed9683c27cef0fafeeea6c  guix-build-604e6798fb3e/output/aarch64-linux-gnu/bitcoin-604e6798fb3e-aarch64-linux-gnu-debug.tar.gz
 2b3d148b3b73ad1740043d6b7b2c0e36a012fcad96b5ebe01cca0ffdc98e0a9db  guix-build-604e6798fb3e/output/aarch64-linux-gnu/bitcoin-604e6798fb3e-aarch64-linux-gnu.tar.gz
 3b25ee0827c6a2661aea41aec501a8612801ff927fcf5196ab1f1214b00221948  guix-build-604e6798fb3e/output/arm-linux-gnueabihf/SHA256SUMS.part
 459aeeda01387348ea20c1c3b868b3dd0b03dd2fa97b21912e54c623ed1b9bc48  guix-build-604e6798fb3e/output/arm-linux-gnueabihf/bitcoin-604e6798fb3e-arm-linux-gnueabihf-debug.tar.gz
 5365e9d209c1786aab9d7feb1f6d94dbd273a0e2aef26f15823f3ec8112f9659e  guix-build-604e6798fb3e/output/arm-linux-gnueabihf/bitcoin-604e6798fb3e-arm-linux-gnueabihf.tar.gz
 61e4190a5d6f8080377bbe27004a7c752e8ff260cbf3b57265626a059482796b6  guix-build-604e6798fb3e/output/arm64-apple-darwin/SHA256SUMS.part
 7886f478f0a995f377a9531d5c7d33322256c89ac96c604417b848967836bb213  guix-build-604e6798fb3e/output/arm64-apple-darwin/bitcoin-604e6798fb3e-arm64-apple-darwin-codesigning.tar.gz
 80f3387853d191800cf822be2e5f0886c9b21496fdb4667038662d32424047a1a  guix-build-604e6798fb3e/output/arm64-apple-darwin/bitcoin-604e6798fb3e-arm64-apple-darwin-unsigned.tar.gz
 9b1076b5752fb50ffe1191588abc5b3d673edfa560a451a745bcfd0e098e211a6  guix-build-604e6798fb3e/output/arm64-apple-darwin/bitcoin-604e6798fb3e-arm64-apple-darwin-unsigned.zip
100d46564dc0b84da9ea761929d9b6426f12e770e37eb40520296edbb024a07075  guix-build-604e6798fb3e/output/dist-archive/bitcoin-604e6798fb3e.tar.gz
1191958603dc0c5307688a52a680d538bd7853d56b5014079ddf98672cacc73b31  guix-build-604e6798fb3e/output/powerpc64-linux-gnu/SHA256SUMS.part
124496c2da6260ebf094b33609fb855f1b7b73eeb3bbcd5ea445ec10990116a10d  guix-build-604e6798fb3e/output/powerpc64-linux-gnu/bitcoin-604e6798fb3e-powerpc64-linux-gnu-debug.tar.gz
13bc07a6ea35d3f1a070875f665c04c2ff7377bbb8521fb233db44bb8ae656a877  guix-build-604e6798fb3e/output/powerpc64-linux-gnu/bitcoin-604e6798fb3e-powerpc64-linux-gnu.tar.gz
14dcbc80fdb4e8059ecf638d48c6a76e548c6e05c448c44d8c95ecc7efdd677403  guix-build-604e6798fb3e/output/riscv64-linux-gnu/SHA256SUMS.part
15a3aad12fabf0ea0e44b32a849f40c4f31c58b583707ece3d59eae07311a15b9d  guix-build-604e6798fb3e/output/riscv64-linux-gnu/bitcoin-604e6798fb3e-riscv64-linux-gnu-debug.tar.gz
16e4a4201568f4f43352039ddd12211b78c22cbaee1ec7046bf0be46bd4210f225  guix-build-604e6798fb3e/output/riscv64-linux-gnu/bitcoin-604e6798fb3e-riscv64-linux-gnu.tar.gz
17b02e69c848fd62e510af7e06605850e23623be967954ec505dd8a83a3840e763  guix-build-604e6798fb3e/output/x86_64-apple-darwin/SHA256SUMS.part
1802620f6de6ca557dc421662d5e984e7a67d5db9d4e0ccdf3d862703bc6225711  guix-build-604e6798fb3e/output/x86_64-apple-darwin/bitcoin-604e6798fb3e-x86_64-apple-darwin-codesigning.tar.gz
1980c2236456afca1b6c3debe28cdf60310500f9fc4c6790df087fd35581c9c158  guix-build-604e6798fb3e/output/x86_64-apple-darwin/bitcoin-604e6798fb3e-x86_64-apple-darwin-unsigned.tar.gz
2005fa75dccf18a910fb0e9ad05fad496efd475a00f4b00a5033c6ba5b2be700c6  guix-build-604e6798fb3e/output/x86_64-apple-darwin/bitcoin-604e6798fb3e-x86_64-apple-darwin-unsigned.zip
21bcbbd8d9be79eb636bab46138af8d95929132801e41fd105fe20f62bd7be630a  guix-build-604e6798fb3e/output/x86_64-linux-gnu/SHA256SUMS.part
226d558c4e4cd6c8fa4d02f6e3c5894678216a261935687c566efd98707430a956  guix-build-604e6798fb3e/output/x86_64-linux-gnu/bitcoin-604e6798fb3e-x86_64-linux-gnu-debug.tar.gz
23fc0993b4301bad9e58d9ed1bd5f0bbd53ddd273baf1cc3c9346bfc736fd9e4b5  guix-build-604e6798fb3e/output/x86_64-linux-gnu/bitcoin-604e6798fb3e-x86_64-linux-gnu.tar.gz
242df671aa7353d5aa99ec4e4214846ee4c5030e46da7a863a6d5b6bb7835e15a2  guix-build-604e6798fb3e/output/x86_64-w64-mingw32/SHA256SUMS.part
25d7ff255a17725ef981a57c3d795958cfb51489ae7dcb6498fd210af0129f5ffa  guix-build-604e6798fb3e/output/x86_64-w64-mingw32/bitcoin-604e6798fb3e-win64-codesigning.tar.gz
268aae5bad0af873c45cf6db965f129467c655c7aec30400609cc43b00ed2412b2  guix-build-604e6798fb3e/output/x86_64-w64-mingw32/bitcoin-604e6798fb3e-win64-debug.zip
27181165c4fb8927a54775e0b61fe87199aded99c003aa0b085c302d1cfdcddea1  guix-build-604e6798fb3e/output/x86_64-w64-mingw32/bitcoin-604e6798fb3e-win64-setup-unsigned.exe
2854401e556f6792d0e009c403ab94bff9abba735d7a9932b2bc2bff5d50a46d69  guix-build-604e6798fb3e/output/x86_64-w64-mingw32/bitcoin-604e6798fb3e-win64-unsigned.zip

trevarj commented at 8:15 pm on March 22, 2026: none

ACK

would be nice to get guix to bump the version too 🥲

hebasto commented at 9:44 pm on March 22, 2026: member

My Guix build:

 0aarch64
 16bda9ad0e0e23398975e6b49fc828a723e1ad923f42a136b2b12df372a12b1b8  guix-build-604e6798fb3e/output/aarch64-linux-gnu/SHA256SUMS.part
 2246ab16366ecbecd70d63f047652ebfaf37b7f96f8ed9683c27cef0fafeeea6c  guix-build-604e6798fb3e/output/aarch64-linux-gnu/bitcoin-604e6798fb3e-aarch64-linux-gnu-debug.tar.gz
 3b3d148b3b73ad1740043d6b7b2c0e36a012fcad96b5ebe01cca0ffdc98e0a9db  guix-build-604e6798fb3e/output/aarch64-linux-gnu/bitcoin-604e6798fb3e-aarch64-linux-gnu.tar.gz
 4b25ee0827c6a2661aea41aec501a8612801ff927fcf5196ab1f1214b00221948  guix-build-604e6798fb3e/output/arm-linux-gnueabihf/SHA256SUMS.part
 559aeeda01387348ea20c1c3b868b3dd0b03dd2fa97b21912e54c623ed1b9bc48  guix-build-604e6798fb3e/output/arm-linux-gnueabihf/bitcoin-604e6798fb3e-arm-linux-gnueabihf-debug.tar.gz
 6365e9d209c1786aab9d7feb1f6d94dbd273a0e2aef26f15823f3ec8112f9659e  guix-build-604e6798fb3e/output/arm-linux-gnueabihf/bitcoin-604e6798fb3e-arm-linux-gnueabihf.tar.gz
 71e4190a5d6f8080377bbe27004a7c752e8ff260cbf3b57265626a059482796b6  guix-build-604e6798fb3e/output/arm64-apple-darwin/SHA256SUMS.part
 8886f478f0a995f377a9531d5c7d33322256c89ac96c604417b848967836bb213  guix-build-604e6798fb3e/output/arm64-apple-darwin/bitcoin-604e6798fb3e-arm64-apple-darwin-codesigning.tar.gz
 90f3387853d191800cf822be2e5f0886c9b21496fdb4667038662d32424047a1a  guix-build-604e6798fb3e/output/arm64-apple-darwin/bitcoin-604e6798fb3e-arm64-apple-darwin-unsigned.tar.gz
10b1076b5752fb50ffe1191588abc5b3d673edfa560a451a745bcfd0e098e211a6  guix-build-604e6798fb3e/output/arm64-apple-darwin/bitcoin-604e6798fb3e-arm64-apple-darwin-unsigned.zip
110d46564dc0b84da9ea761929d9b6426f12e770e37eb40520296edbb024a07075  guix-build-604e6798fb3e/output/dist-archive/bitcoin-604e6798fb3e.tar.gz
1291958603dc0c5307688a52a680d538bd7853d56b5014079ddf98672cacc73b31  guix-build-604e6798fb3e/output/powerpc64-linux-gnu/SHA256SUMS.part
134496c2da6260ebf094b33609fb855f1b7b73eeb3bbcd5ea445ec10990116a10d  guix-build-604e6798fb3e/output/powerpc64-linux-gnu/bitcoin-604e6798fb3e-powerpc64-linux-gnu-debug.tar.gz
14bc07a6ea35d3f1a070875f665c04c2ff7377bbb8521fb233db44bb8ae656a877  guix-build-604e6798fb3e/output/powerpc64-linux-gnu/bitcoin-604e6798fb3e-powerpc64-linux-gnu.tar.gz
15dcbc80fdb4e8059ecf638d48c6a76e548c6e05c448c44d8c95ecc7efdd677403  guix-build-604e6798fb3e/output/riscv64-linux-gnu/SHA256SUMS.part
16a3aad12fabf0ea0e44b32a849f40c4f31c58b583707ece3d59eae07311a15b9d  guix-build-604e6798fb3e/output/riscv64-linux-gnu/bitcoin-604e6798fb3e-riscv64-linux-gnu-debug.tar.gz
17e4a4201568f4f43352039ddd12211b78c22cbaee1ec7046bf0be46bd4210f225  guix-build-604e6798fb3e/output/riscv64-linux-gnu/bitcoin-604e6798fb3e-riscv64-linux-gnu.tar.gz
18b02e69c848fd62e510af7e06605850e23623be967954ec505dd8a83a3840e763  guix-build-604e6798fb3e/output/x86_64-apple-darwin/SHA256SUMS.part
1902620f6de6ca557dc421662d5e984e7a67d5db9d4e0ccdf3d862703bc6225711  guix-build-604e6798fb3e/output/x86_64-apple-darwin/bitcoin-604e6798fb3e-x86_64-apple-darwin-codesigning.tar.gz
2080c2236456afca1b6c3debe28cdf60310500f9fc4c6790df087fd35581c9c158  guix-build-604e6798fb3e/output/x86_64-apple-darwin/bitcoin-604e6798fb3e-x86_64-apple-darwin-unsigned.tar.gz
2105fa75dccf18a910fb0e9ad05fad496efd475a00f4b00a5033c6ba5b2be700c6  guix-build-604e6798fb3e/output/x86_64-apple-darwin/bitcoin-604e6798fb3e-x86_64-apple-darwin-unsigned.zip
22bcbbd8d9be79eb636bab46138af8d95929132801e41fd105fe20f62bd7be630a  guix-build-604e6798fb3e/output/x86_64-linux-gnu/SHA256SUMS.part
236d558c4e4cd6c8fa4d02f6e3c5894678216a261935687c566efd98707430a956  guix-build-604e6798fb3e/output/x86_64-linux-gnu/bitcoin-604e6798fb3e-x86_64-linux-gnu-debug.tar.gz
24fc0993b4301bad9e58d9ed1bd5f0bbd53ddd273baf1cc3c9346bfc736fd9e4b5  guix-build-604e6798fb3e/output/x86_64-linux-gnu/bitcoin-604e6798fb3e-x86_64-linux-gnu.tar.gz
252df671aa7353d5aa99ec4e4214846ee4c5030e46da7a863a6d5b6bb7835e15a2  guix-build-604e6798fb3e/output/x86_64-w64-mingw32/SHA256SUMS.part
26d7ff255a17725ef981a57c3d795958cfb51489ae7dcb6498fd210af0129f5ffa  guix-build-604e6798fb3e/output/x86_64-w64-mingw32/bitcoin-604e6798fb3e-win64-codesigning.tar.gz
278aae5bad0af873c45cf6db965f129467c655c7aec30400609cc43b00ed2412b2  guix-build-604e6798fb3e/output/x86_64-w64-mingw32/bitcoin-604e6798fb3e-win64-debug.zip
28181165c4fb8927a54775e0b61fe87199aded99c003aa0b085c302d1cfdcddea1  guix-build-604e6798fb3e/output/x86_64-w64-mingw32/bitcoin-604e6798fb3e-win64-setup-unsigned.exe
2954401e556f6792d0e009c403ab94bff9abba735d7a9932b2bc2bff5d50a46d69  guix-build-604e6798fb3e/output/x86_64-w64-mingw32/bitcoin-604e6798fb3e-win64-unsigned.zip

maflcko commented at 3:07 pm on March 24, 2026: member

Not a blocker, but it would be nice to bisect this, to see which commit fixed this, and possibly leave a comment in the upstream bug report that it was fixed and can be closed?

hebasto approved

hebasto commented at 2:58 pm on March 26, 2026: member

ACK 604e6798fb3e27559ef6b8b4e1ed983c418fdbcb, I have reviewed the code and it looks OK.

DrahtBot commented at 2:55 am on March 27, 2026: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit 19c947474260d18558db4121f28fba01028c9dab(master)	commit e5ef1f079b5633e59eb7cce16e3aac51aebdc665(pull/34757/merge)
*-aarch64-linux-gnu-debug.tar.gz	`4a21ecdd483e2be8...`	`40927d904e0cc427...`
*-aarch64-linux-gnu.tar.gz	`cd6d861c08e474d4...`	`c2396a924680b6a6...`
*-arm-linux-gnueabihf-debug.tar.gz	`c9557213ddde50a9...`	`2724d76c1182181a...`
*-arm-linux-gnueabihf.tar.gz	`18108fe14b9a6ce8...`	`de42ac3c572390ed...`
*-arm64-apple-darwin-codesigning.tar.gz	`71528afc39c8935b...`	`7f3feec88d93a6b9...`
*-arm64-apple-darwin-unsigned.tar.gz	`8f64160d63986694...`	`274a098c86d3673d...`
*-arm64-apple-darwin-unsigned.zip	`b945e73e91a4c04c...`	`283e5c96681c0370...`
*-powerpc64-linux-gnu-debug.tar.gz	`5b81861ba6ff6435...`	`ecce90e61cafbdd3...`
*-powerpc64-linux-gnu.tar.gz	`3811e50a364250e6...`	`d8983186eedb1f96...`
*-riscv64-linux-gnu-debug.tar.gz	`f062432ebf0b25c9...`	`702139365e81be55...`
*-riscv64-linux-gnu.tar.gz	`1a24a831713d38ff...`	`6253c832a91f56eb...`
*-win64-codesigning.tar.gz	`70793ae3a7ff91d5...`	`f3a1cd64d9f077f1...`
*-win64-debug.zip	`71efcbb2ee1d78cb...`	`55e98ce65ef2a8c7...`
*-win64-setup-unsigned.exe	`ee3716b9cada5865...`	`120aa263eb464a4b...`
*-win64-unsigned.zip	`f31650750ec8c321...`	`d6ab3613e4dd1ed5...`
*-x86_64-apple-darwin-codesigning.tar.gz	`307548f83a1b3bb6...`	`002aa07d3f545ee8...`
*-x86_64-apple-darwin-unsigned.tar.gz	`8a9cd8c8ffbe544a...`	`f1ec4dc083730193...`
*-x86_64-apple-darwin-unsigned.zip	`9761f406ee5d686d...`	`f55d3d2ddfad48cf...`
*-x86_64-linux-gnu-debug.tar.gz	`58b4bba3c400db5a...`	`ee7cac6cc223a671...`
*-x86_64-linux-gnu.tar.gz	`ff0c174042fd2245...`	`28ef08af8c98cdf5...`
*.tar.gz	`7911e517fb8cf656...`	`d88dbd12a0c7a315...`
SHA256SUMS.part	`d162c9c33145a3ad...`	`6294fda9d1febfe8...`
guix_build.log	`e7f82c459c10392d...`	`85305852e0dc05a9...`
guix_build.log.diff		`0bfd35c447035729...`

DrahtBot removed the label DrahtBot Guix build requested on Mar 27, 2026

guix: re-enable riscv exported symbol checking #34757

Reviews

Conflicts

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]