guix: re-enable riscv exported symbol checking #34757

fanquake commented at 4:15 PM on March 6, 2026: member

Switching to binutils 2.46.0 fixes the spurious exported symbols (2.45.1 was still broken).

The relevant upstream change is https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=9e10fcf71c1101fb6422d0f52de5e615ed8df71d.

Fixes #28095.

DrahtBot added the label Build system on Mar 6, 2026

DrahtBot commented at 4:16 PM on March 6, 2026: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	hebasto
Concept ACK	trevarj

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.

Conflicts

No conflicts as of last run.

DrahtBot added the label Needs rebase on Mar 10, 2026

fanquake force-pushed on Mar 10, 2026

DrahtBot removed the label Needs rebase on Mar 10, 2026

fanquake force-pushed on Mar 20, 2026

fanquake marked this as ready for review on Mar 20, 2026

fanquake added the label DrahtBot Guix build requested on Mar 20, 2026

fanquake commented at 12:27 AM on March 20, 2026: member

Rebased & ready for review.

trevarj commented at 8:15 PM on March 22, 2026: none

ACK

would be nice to get guix to bump the version too 🥲

hebasto commented at 9:44 PM on March 22, 2026: member

My Guix build:

aarch64
6bda9ad0e0e23398975e6b49fc828a723e1ad923f42a136b2b12df372a12b1b8  guix-build-604e6798fb3e/output/aarch64-linux-gnu/SHA256SUMS.part
246ab16366ecbecd70d63f047652ebfaf37b7f96f8ed9683c27cef0fafeeea6c  guix-build-604e6798fb3e/output/aarch64-linux-gnu/bitcoin-604e6798fb3e-aarch64-linux-gnu-debug.tar.gz
b3d148b3b73ad1740043d6b7b2c0e36a012fcad96b5ebe01cca0ffdc98e0a9db  guix-build-604e6798fb3e/output/aarch64-linux-gnu/bitcoin-604e6798fb3e-aarch64-linux-gnu.tar.gz
b25ee0827c6a2661aea41aec501a8612801ff927fcf5196ab1f1214b00221948  guix-build-604e6798fb3e/output/arm-linux-gnueabihf/SHA256SUMS.part
59aeeda01387348ea20c1c3b868b3dd0b03dd2fa97b21912e54c623ed1b9bc48  guix-build-604e6798fb3e/output/arm-linux-gnueabihf/bitcoin-604e6798fb3e-arm-linux-gnueabihf-debug.tar.gz
365e9d209c1786aab9d7feb1f6d94dbd273a0e2aef26f15823f3ec8112f9659e  guix-build-604e6798fb3e/output/arm-linux-gnueabihf/bitcoin-604e6798fb3e-arm-linux-gnueabihf.tar.gz
1e4190a5d6f8080377bbe27004a7c752e8ff260cbf3b57265626a059482796b6  guix-build-604e6798fb3e/output/arm64-apple-darwin/SHA256SUMS.part
886f478f0a995f377a9531d5c7d33322256c89ac96c604417b848967836bb213  guix-build-604e6798fb3e/output/arm64-apple-darwin/bitcoin-604e6798fb3e-arm64-apple-darwin-codesigning.tar.gz
0f3387853d191800cf822be2e5f0886c9b21496fdb4667038662d32424047a1a  guix-build-604e6798fb3e/output/arm64-apple-darwin/bitcoin-604e6798fb3e-arm64-apple-darwin-unsigned.tar.gz
b1076b5752fb50ffe1191588abc5b3d673edfa560a451a745bcfd0e098e211a6  guix-build-604e6798fb3e/output/arm64-apple-darwin/bitcoin-604e6798fb3e-arm64-apple-darwin-unsigned.zip
0d46564dc0b84da9ea761929d9b6426f12e770e37eb40520296edbb024a07075  guix-build-604e6798fb3e/output/dist-archive/bitcoin-604e6798fb3e.tar.gz
91958603dc0c5307688a52a680d538bd7853d56b5014079ddf98672cacc73b31  guix-build-604e6798fb3e/output/powerpc64-linux-gnu/SHA256SUMS.part
4496c2da6260ebf094b33609fb855f1b7b73eeb3bbcd5ea445ec10990116a10d  guix-build-604e6798fb3e/output/powerpc64-linux-gnu/bitcoin-604e6798fb3e-powerpc64-linux-gnu-debug.tar.gz
bc07a6ea35d3f1a070875f665c04c2ff7377bbb8521fb233db44bb8ae656a877  guix-build-604e6798fb3e/output/powerpc64-linux-gnu/bitcoin-604e6798fb3e-powerpc64-linux-gnu.tar.gz
dcbc80fdb4e8059ecf638d48c6a76e548c6e05c448c44d8c95ecc7efdd677403  guix-build-604e6798fb3e/output/riscv64-linux-gnu/SHA256SUMS.part
a3aad12fabf0ea0e44b32a849f40c4f31c58b583707ece3d59eae07311a15b9d  guix-build-604e6798fb3e/output/riscv64-linux-gnu/bitcoin-604e6798fb3e-riscv64-linux-gnu-debug.tar.gz
e4a4201568f4f43352039ddd12211b78c22cbaee1ec7046bf0be46bd4210f225  guix-build-604e6798fb3e/output/riscv64-linux-gnu/bitcoin-604e6798fb3e-riscv64-linux-gnu.tar.gz
b02e69c848fd62e510af7e06605850e23623be967954ec505dd8a83a3840e763  guix-build-604e6798fb3e/output/x86_64-apple-darwin/SHA256SUMS.part
02620f6de6ca557dc421662d5e984e7a67d5db9d4e0ccdf3d862703bc6225711  guix-build-604e6798fb3e/output/x86_64-apple-darwin/bitcoin-604e6798fb3e-x86_64-apple-darwin-codesigning.tar.gz
80c2236456afca1b6c3debe28cdf60310500f9fc4c6790df087fd35581c9c158  guix-build-604e6798fb3e/output/x86_64-apple-darwin/bitcoin-604e6798fb3e-x86_64-apple-darwin-unsigned.tar.gz
05fa75dccf18a910fb0e9ad05fad496efd475a00f4b00a5033c6ba5b2be700c6  guix-build-604e6798fb3e/output/x86_64-apple-darwin/bitcoin-604e6798fb3e-x86_64-apple-darwin-unsigned.zip
bcbbd8d9be79eb636bab46138af8d95929132801e41fd105fe20f62bd7be630a  guix-build-604e6798fb3e/output/x86_64-linux-gnu/SHA256SUMS.part
6d558c4e4cd6c8fa4d02f6e3c5894678216a261935687c566efd98707430a956  guix-build-604e6798fb3e/output/x86_64-linux-gnu/bitcoin-604e6798fb3e-x86_64-linux-gnu-debug.tar.gz
fc0993b4301bad9e58d9ed1bd5f0bbd53ddd273baf1cc3c9346bfc736fd9e4b5  guix-build-604e6798fb3e/output/x86_64-linux-gnu/bitcoin-604e6798fb3e-x86_64-linux-gnu.tar.gz
2df671aa7353d5aa99ec4e4214846ee4c5030e46da7a863a6d5b6bb7835e15a2  guix-build-604e6798fb3e/output/x86_64-w64-mingw32/SHA256SUMS.part
d7ff255a17725ef981a57c3d795958cfb51489ae7dcb6498fd210af0129f5ffa  guix-build-604e6798fb3e/output/x86_64-w64-mingw32/bitcoin-604e6798fb3e-win64-codesigning.tar.gz
8aae5bad0af873c45cf6db965f129467c655c7aec30400609cc43b00ed2412b2  guix-build-604e6798fb3e/output/x86_64-w64-mingw32/bitcoin-604e6798fb3e-win64-debug.zip
181165c4fb8927a54775e0b61fe87199aded99c003aa0b085c302d1cfdcddea1  guix-build-604e6798fb3e/output/x86_64-w64-mingw32/bitcoin-604e6798fb3e-win64-setup-unsigned.exe
54401e556f6792d0e009c403ab94bff9abba735d7a9932b2bc2bff5d50a46d69  guix-build-604e6798fb3e/output/x86_64-w64-mingw32/bitcoin-604e6798fb3e-win64-unsigned.zip

maflcko commented at 3:07 PM on March 24, 2026: member

Not a blocker, but it would be nice to bisect this, to see which commit fixed this, and possibly leave a comment in the upstream bug report that it was fixed and can be closed?

hebasto approved

hebasto commented at 2:58 PM on March 26, 2026: member

ACK 604e6798fb3e27559ef6b8b4e1ed983c418fdbcb, I have reviewed the code and it looks OK.

DrahtBot commented at 2:55 AM on March 27, 2026: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit 19c947474260d18558db4121f28fba01028c9dab<br>(master)	commit e5ef1f079b5633e59eb7cce16e3aac51aebdc665<br>(pull/34757/merge)
*-aarch64-linux-gnu-debug.tar.gz	`4a21ecdd483e2be8...`	`40927d904e0cc427...`
*-aarch64-linux-gnu.tar.gz	`cd6d861c08e474d4...`	`c2396a924680b6a6...`
*-arm-linux-gnueabihf-debug.tar.gz	`c9557213ddde50a9...`	`2724d76c1182181a...`
*-arm-linux-gnueabihf.tar.gz	`18108fe14b9a6ce8...`	`de42ac3c572390ed...`
*-arm64-apple-darwin-codesigning.tar.gz	`71528afc39c8935b...`	`7f3feec88d93a6b9...`
*-arm64-apple-darwin-unsigned.tar.gz	`8f64160d63986694...`	`274a098c86d3673d...`
*-arm64-apple-darwin-unsigned.zip	`b945e73e91a4c04c...`	`283e5c96681c0370...`
*-powerpc64-linux-gnu-debug.tar.gz	`5b81861ba6ff6435...`	`ecce90e61cafbdd3...`
*-powerpc64-linux-gnu.tar.gz	`3811e50a364250e6...`	`d8983186eedb1f96...`
*-riscv64-linux-gnu-debug.tar.gz	`f062432ebf0b25c9...`	`702139365e81be55...`
*-riscv64-linux-gnu.tar.gz	`1a24a831713d38ff...`	`6253c832a91f56eb...`
*-win64-codesigning.tar.gz	`70793ae3a7ff91d5...`	`f3a1cd64d9f077f1...`
*-win64-debug.zip	`71efcbb2ee1d78cb...`	`55e98ce65ef2a8c7...`
*-win64-setup-unsigned.exe	`ee3716b9cada5865...`	`120aa263eb464a4b...`
*-win64-unsigned.zip	`f31650750ec8c321...`	`d6ab3613e4dd1ed5...`
*-x86_64-apple-darwin-codesigning.tar.gz	`307548f83a1b3bb6...`	`002aa07d3f545ee8...`
*-x86_64-apple-darwin-unsigned.tar.gz	`8a9cd8c8ffbe544a...`	`f1ec4dc083730193...`
*-x86_64-apple-darwin-unsigned.zip	`9761f406ee5d686d...`	`f55d3d2ddfad48cf...`
*-x86_64-linux-gnu-debug.tar.gz	`58b4bba3c400db5a...`	`ee7cac6cc223a671...`
*-x86_64-linux-gnu.tar.gz	`ff0c174042fd2245...`	`28ef08af8c98cdf5...`
*.tar.gz	`7911e517fb8cf656...`	`d88dbd12a0c7a315...`
SHA256SUMS.part	`d162c9c33145a3ad...`	`6294fda9d1febfe8...`
guix_build.log	`e7f82c459c10392d...`	`85305852e0dc05a9...`
guix_build.log.diff		`0bfd35c447035729...`

DrahtBot removed the label DrahtBot Guix build requested on Mar 27, 2026

guix: binutils 2.46.0 47b7a9f666

guix: remove riscv exclusion from symbol check 19e99be011

fanquake force-pushed on Apr 6, 2026

fanquake commented at 7:33 AM on April 6, 2026: member

Pushed to (re) add (guix download).

hebasto approved

hebasto commented at 10:25 AM on April 6, 2026: member

re-ACK 19e99be011ba953a6df0c5866a034debe86925e4, only rebased and properly adjusted since my recent review.

hebasto commented at 9:10 AM on April 7, 2026: member

My Guix build:

aarch64
b4bf8d62981841010e29086cd107f56eeb68222bbffccfb30fd97fc012b5d8d5  guix-build-19e99be011ba/output/aarch64-linux-gnu/SHA256SUMS.part
00d61cacedd50f72232c66a87468df62015d55ccbc45e1a6b599fb80872b078c  guix-build-19e99be011ba/output/aarch64-linux-gnu/bitcoin-19e99be011ba-aarch64-linux-gnu-debug.tar.gz
dd0f154f544654d901c93a1cc48e098b5e17c87bdbaf4dff7279956c91b8a377  guix-build-19e99be011ba/output/aarch64-linux-gnu/bitcoin-19e99be011ba-aarch64-linux-gnu.tar.gz
c5e00f945cd67eb8d4d32ad9db74ccab2a4934d59ed373dfb8c1f0e2313aad5d  guix-build-19e99be011ba/output/arm-linux-gnueabihf/SHA256SUMS.part
0afa11a7c7506ec36224ef2fce5a08219064f545adb2bc44cc0ed36333c09723  guix-build-19e99be011ba/output/arm-linux-gnueabihf/bitcoin-19e99be011ba-arm-linux-gnueabihf-debug.tar.gz
9b97c646bbe856dc2aca8722aad9a3b6fa73ae20563335b7e4d422672a6f866f  guix-build-19e99be011ba/output/arm-linux-gnueabihf/bitcoin-19e99be011ba-arm-linux-gnueabihf.tar.gz
c8f689b24e8e431a017ae75d19dedb173b82a957350f7891e3d34bf6f315a514  guix-build-19e99be011ba/output/arm64-apple-darwin/SHA256SUMS.part
ec5100bb6b5c272d6744f107056e4d1c2b4f54500884df3036509d18f55385c1  guix-build-19e99be011ba/output/arm64-apple-darwin/bitcoin-19e99be011ba-arm64-apple-darwin-codesigning.tar.gz
8a5e8ce426eec5238aab701cd3ce4a3f383e58a541f9daa1fff655ef36f642f7  guix-build-19e99be011ba/output/arm64-apple-darwin/bitcoin-19e99be011ba-arm64-apple-darwin-unsigned.tar.gz
a9e105471923afab107760fe34daac8e82ebca87f6e6e807d7d3d109d8c1be08  guix-build-19e99be011ba/output/arm64-apple-darwin/bitcoin-19e99be011ba-arm64-apple-darwin-unsigned.zip
5bea2059ab85fc9e8263838d6ef218a7759d8999991f3b75cd46ea6eca28d5db  guix-build-19e99be011ba/output/dist-archive/bitcoin-19e99be011ba.tar.gz
75c50e467d0b4e8369ebeb85804f5f3d57621044654738303805a4f7f6a058e9  guix-build-19e99be011ba/output/powerpc64-linux-gnu/SHA256SUMS.part
053915fc83658a05b050736175def31b3542e908fc524a74b492f19940fbe0b8  guix-build-19e99be011ba/output/powerpc64-linux-gnu/bitcoin-19e99be011ba-powerpc64-linux-gnu-debug.tar.gz
92d3f2c40fb8f29332595f9c79289eac2540091ddceaf91eb9af1513b5c70c4d  guix-build-19e99be011ba/output/powerpc64-linux-gnu/bitcoin-19e99be011ba-powerpc64-linux-gnu.tar.gz
a2633ffddc41d6974d15d5f78ee65861cb3878c561429bb01aa9e0e7c1eede9e  guix-build-19e99be011ba/output/riscv64-linux-gnu/SHA256SUMS.part
1edd2c124d7b95134a4f77f3041f76a95669103cb871c0890b474a4649b201a5  guix-build-19e99be011ba/output/riscv64-linux-gnu/bitcoin-19e99be011ba-riscv64-linux-gnu-debug.tar.gz
0781bc838923447d334fdc037e56f43e3213d0c915479234532eb166d48d1951  guix-build-19e99be011ba/output/riscv64-linux-gnu/bitcoin-19e99be011ba-riscv64-linux-gnu.tar.gz
7c69bdf783131a22f44df1d6cd4ed04f38143289dcb0b9e9c0a2de509853e4b5  guix-build-19e99be011ba/output/x86_64-apple-darwin/SHA256SUMS.part
43faf807393b30811f992946ae81e38905acffddc206396a85762b568728df81  guix-build-19e99be011ba/output/x86_64-apple-darwin/bitcoin-19e99be011ba-x86_64-apple-darwin-codesigning.tar.gz
71805140901a0a543710e6dc99172f5163e83e77858f2cbdbb4fd4822f7f1513  guix-build-19e99be011ba/output/x86_64-apple-darwin/bitcoin-19e99be011ba-x86_64-apple-darwin-unsigned.tar.gz
6cbb829dc02a24ae4d5c155868b3dfd26094f39798fe5579383f5d276821bae9  guix-build-19e99be011ba/output/x86_64-apple-darwin/bitcoin-19e99be011ba-x86_64-apple-darwin-unsigned.zip
441eae5f4646857b417c6134c3a248f0257ae18491b503f5749fe4f07fda1d5e  guix-build-19e99be011ba/output/x86_64-linux-gnu/SHA256SUMS.part
1347aff822e773210d46d2c2d4217df7e541756281d88dce78c81dab37c57f5a  guix-build-19e99be011ba/output/x86_64-linux-gnu/bitcoin-19e99be011ba-x86_64-linux-gnu-debug.tar.gz
5b32e8822d6dcca96f5e681f98efec2db308a44bd6d1efcf9f79a94e6f340128  guix-build-19e99be011ba/output/x86_64-linux-gnu/bitcoin-19e99be011ba-x86_64-linux-gnu.tar.gz
2ba560124a9d62192bf2526ca39f689df6556b0ffd4e7b9634871a586e2ab3ee  guix-build-19e99be011ba/output/x86_64-w64-mingw32/SHA256SUMS.part
16b3d369de4648e6084b7813f2227c1b0a97aadd8b9bef17263320d64e2a1310  guix-build-19e99be011ba/output/x86_64-w64-mingw32/bitcoin-19e99be011ba-win64-codesigning.tar.gz
991eb2d5bf6675b7a310814a3bfb32cb3aaddf3c5b2513ef83ab5d1388178808  guix-build-19e99be011ba/output/x86_64-w64-mingw32/bitcoin-19e99be011ba-win64-debug.zip
d808a8657338489497524e43ec57816912fbf86d8868904fcab36798b5be9f1b  guix-build-19e99be011ba/output/x86_64-w64-mingw32/bitcoin-19e99be011ba-win64-setup-unsigned.exe
90cd8fe0150bf228e38fd7ac4a217e6c5640a68a1fcf1b0ef3a5c3be0e9bfeaf  guix-build-19e99be011ba/output/x86_64-w64-mingw32/bitcoin-19e99be011ba-win64-unsigned.zip

theuni commented at 7:13 PM on April 14, 2026: member

Not a blocker, but it would be nice to bisect this, to see which commit fixed this, and possibly leave a comment in the upstream bug report that it was fixed and can be closed?

From a quick git blame, I'd say it was likely this: https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=9e10fcf71c1101fb6422d0f52de5e615ed8df71d + https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=f6fc2b523161b7c459e7fc9ae80b288727071be9

theuni commented at 9:48 PM on April 14, 2026: member

Confirmed via a git bisect that 9e10fcf71c1 fixed the issue upstream.

fanquake commented at 9:57 AM on April 16, 2026: member

@theuni thanks for taking a look. Updated the PR description. There's a comment upstream now as well: https://sourceware.org/bugzilla/show_bug.cgi?id=32783#c1.

would be nice to get guix to bump the version too @trevarj there's no binutils bump for the core-packages-team yet, but maybe we can get something added to https://codeberg.org/guix/guix/pulls/4058.

fanquake merged this on Apr 16, 2026

fanquake closed this on Apr 16, 2026

fanquake deleted the branch on Apr 16, 2026