doc: update http worker thread names #34769

pull rkrux wants to merge 1 commits into bitcoin:master from rkrux:http-threads-doc changing 1 files +1 −1
  1. rkrux commented at 9:02 am on March 7, 2026: contributor

    After using Threadpool for HTTP server in PR 33689, the previously documented HTTP worker thread names are outdated. This commit makes the corresponding changes to document new names for the HTTP worker threads. Below is the output from the thead list command after attaching lldb to bitcoind.

    0thread [#3](/bitcoin-bitcoin/3/): tid = 0xfe551, 0x00007ff80e3536f6 libsystem_kernel.dylib`__psynch_cvwait + 10, name = 'b-http_pool_0'
    1thread [#4](/bitcoin-bitcoin/4/): tid = 0xfe552, 0x00007ff80e3536f6 libsystem_kernel.dylib`__psynch_cvwait + 10, name = 'b-http_pool_1'
    
  2. DrahtBot added the label Docs on Mar 7, 2026
  3. DrahtBot commented at 9:02 am on March 7, 2026: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK l0rinc, hebasto, theStack, furszy, sedited

    If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

  4. in doc/developer-notes.md:675 in f5c75037cc
    671@@ -672,7 +672,7 @@ and its `cs_KeyStore` lock for example).
    672 - [ThreadHTTP (`b-http`)](https://doxygen.bitcoincore.org/httpserver_8cpp.html#abb9f6ea8819672bd9a62d3695070709c)
    673   : Libevent thread to listen for RPC and REST connections.
    674 
    675-- [HTTP worker threads(`b-httpworker.x`)](https://doxygen.bitcoincore.org/httpserver_8cpp.html#aa6a7bc27265043bc0193220c5ae3a55f)
    676+- [HTTP pool threads(`b-http_pool_x`)](https://doxygen.bitcoincore.org/httpserver_8cpp.html#a2ad0a49dc9b5e8117c0dee98c24187d8)
    


    l0rinc commented at 9:15 am on March 7, 2026:
    0- [HTTP worker threads (`b-http_pool_x`)](https://doxygen.bitcoincore.org/httpserver_8cpp.html#a2ad0a49dc9b5e8117c0dee98c24187d8)
    
  5. l0rinc commented at 9:25 am on March 7, 2026: contributor
    I think it should stay worker threads, and if we’re touching this, we could fix the b-mapport and b-net entries as well.
  6. l0rinc approved
  7. rkrux commented at 9:57 am on March 7, 2026: contributor

    and if we’re touching this, we could fix the b-mapport and b-net entries as well.

    Do you mean updating their Doxygen links?

  8. doc: update http worker thread names
    After using `Threadpool` for HTTP server in PR 33689, the previously
    documented HTTP worker thread names are outdated. This commit makes
    the corresponding changes to document new names for the HTTP worker
    threads. Below is the output from the `thead list` command after
    attaching `lldb` to `bitcoind`.
    
    ```zsh
    thread #3: tid = 0xfe551, 0x00007ff80e3536f6 libsystem_kernel.dylib`__psynch_cvwait + 10, name = 'b-http_pool_0'
    thread #4: tid = 0xfe552, 0x00007ff80e3536f6 libsystem_kernel.dylib`__psynch_cvwait + 10, name = 'b-http_pool_1'
    ```
    46189fd526
  9. rkrux force-pushed on Mar 10, 2026
  10. rkrux renamed this:
    doc: update http pool thread names
    doc: update http worker thread names
    on Mar 10, 2026
  11. fanquake commented at 1:52 pm on March 10, 2026: member
    cc @furszy
  12. l0rinc commented at 1:56 pm on March 10, 2026: contributor
    ACK 46189fd5264580d0320976faf81aa2f45e1a7760
  13. in doc/developer-notes.md:675 in 46189fd526
    671@@ -672,7 +672,7 @@ and its `cs_KeyStore` lock for example).
    672 - [ThreadHTTP (`b-http`)](https://doxygen.bitcoincore.org/httpserver_8cpp.html#abb9f6ea8819672bd9a62d3695070709c)
    673   : Libevent thread to listen for RPC and REST connections.
    674 
    675-- [HTTP worker threads(`b-httpworker.x`)](https://doxygen.bitcoincore.org/httpserver_8cpp.html#aa6a7bc27265043bc0193220c5ae3a55f)
    676+- [HTTP worker threads (`b-http_pool_x`)](https://doxygen.bitcoincore.org/httpserver_8cpp.html#a2ad0a49dc9b5e8117c0dee98c24187d8)
    


  14. hebasto approved
  15. hebasto commented at 2:20 pm on March 10, 2026: member
    ACK 46189fd5264580d0320976faf81aa2f45e1a7760.
  16. fanquake added this to the milestone 31.0 on Mar 10, 2026
  17. theStack approved
  18. theStack commented at 5:54 pm on March 10, 2026: contributor
    ACK 46189fd5264580d0320976faf81aa2f45e1a7760
  19. furszy commented at 6:50 pm on March 10, 2026: member
    ACK 46189fd5264580d0320976faf81aa2f45e1a7760
  20. sedited approved
  21. sedited commented at 8:17 pm on March 10, 2026: contributor
    ACK 46189fd5264580d0320976faf81aa2f45e1a7760
  22. sedited merged this on Mar 10, 2026
  23. sedited closed this on Mar 10, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-04 06:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me