doc: update http worker thread names #34769

pull rkrux wants to merge 1 commits into bitcoin:master from rkrux:http-threads-doc changing 1 files +1 −1
  1. rkrux commented at 9:02 AM on March 7, 2026: contributor

    After using Threadpool for HTTP server in PR 33689, the previously documented HTTP worker thread names are outdated. This commit makes the corresponding changes to document new names for the HTTP worker threads. Below is the output from the thead list command after attaching lldb to bitcoind.

    thread [#3](/bitcoin-bitcoin/3/): tid = 0xfe551, 0x00007ff80e3536f6 libsystem_kernel.dylib`__psynch_cvwait + 10, name = 'b-http_pool_0'
thread [#4](/bitcoin-bitcoin/4/): tid = 0xfe552, 0x00007ff80e3536f6 libsystem_kernel.dylib`__psynch_cvwait + 10, name = 'b-http_pool_1'

    <!-- *** Please remove the following help text before submitting: *** Pull requests without a rationale and clear improvement may be closed immediately. GUI-related pull requests should be opened against https://github.com/bitcoin-core/gui first. See CONTRIBUTING.md -->

    <!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible. * Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they *significantly* improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. -->

    <!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. -->

  2. DrahtBot added the label Docs on Mar 7, 2026
  3. DrahtBot commented at 9:02 AM on March 7, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK l0rinc, hebasto, theStack, furszy, sedited

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. in doc/developer-notes.md:675 in f5c75037cc 
     671 | @@ -672,7 +672,7 @@ and its `cs_KeyStore` lock for example).
 672 |  - [ThreadHTTP (`b-http`)](https://doxygen.bitcoincore.org/httpserver_8cpp.html#abb9f6ea8819672bd9a62d3695070709c)
 673 |    : Libevent thread to listen for RPC and REST connections.
 674 |  
 675 | -- [HTTP worker threads(`b-httpworker.x`)](https://doxygen.bitcoincore.org/httpserver_8cpp.html#aa6a7bc27265043bc0193220c5ae3a55f)
 676 | +- [HTTP pool threads(`b-http_pool_x`)](https://doxygen.bitcoincore.org/httpserver_8cpp.html#a2ad0a49dc9b5e8117c0dee98c24187d8)
    l0rinc commented at 9:15 AM on March 7, 2026: 
    - [HTTP worker threads (`b-http_pool_x`)](https://doxygen.bitcoincore.org/httpserver_8cpp.html#a2ad0a49dc9b5e8117c0dee98c24187d8)
  5. l0rinc commented at 9:25 AM on March 7, 2026: contributor

    I think it should stay worker threads, and if we're touching this, we could fix the b-mapport and b-net entries as well.

  6. l0rinc approved
  7. rkrux commented at 9:57 AM on March 7, 2026: contributor

    and if we're touching this, we could fix the b-mapport and b-net entries as well.

    Do you mean updating their Doxygen links?

  8. doc: update http worker thread names
    After using `Threadpool` for HTTP server in PR 33689, the previously
documented HTTP worker thread names are outdated. This commit makes
the corresponding changes to document new names for the HTTP worker
threads. Below is the output from the `thead list` command after
attaching `lldb` to `bitcoind`.

```zsh
thread #3: tid = 0xfe551, 0x00007ff80e3536f6 libsystem_kernel.dylib`__psynch_cvwait + 10, name = 'b-http_pool_0'
thread #4: tid = 0xfe552, 0x00007ff80e3536f6 libsystem_kernel.dylib`__psynch_cvwait + 10, name = 'b-http_pool_1'
```
    46189fd526
  9. rkrux force-pushed on Mar 10, 2026
  10. rkrux renamed this:
    doc: update http pool thread names
    doc: update http worker thread names
    on Mar 10, 2026
  11. fanquake commented at 1:52 PM on March 10, 2026: member

    cc @furszy

  12. l0rinc commented at 1:56 PM on March 10, 2026: contributor

    ACK 46189fd5264580d0320976faf81aa2f45e1a7760

  13. in doc/developer-notes.md:675 in 46189fd526 
     671 | @@ -672,7 +672,7 @@ and its `cs_KeyStore` lock for example).
 672 |  - [ThreadHTTP (`b-http`)](https://doxygen.bitcoincore.org/httpserver_8cpp.html#abb9f6ea8819672bd9a62d3695070709c)
 673 |    : Libevent thread to listen for RPC and REST connections.
 674 |  
 675 | -- [HTTP worker threads(`b-httpworker.x`)](https://doxygen.bitcoincore.org/httpserver_8cpp.html#aa6a7bc27265043bc0193220c5ae3a55f)
 676 | +- [HTTP worker threads (`b-http_pool_x`)](https://doxygen.bitcoincore.org/httpserver_8cpp.html#a2ad0a49dc9b5e8117c0dee98c24187d8)
  14. hebasto approved
  15. hebasto commented at 2:20 PM on March 10, 2026: member

    ACK 46189fd5264580d0320976faf81aa2f45e1a7760.

  16. fanquake added this to the milestone 31.0 on Mar 10, 2026
  17. theStack approved
  18. theStack commented at 5:54 PM on March 10, 2026: contributor

    ACK 46189fd5264580d0320976faf81aa2f45e1a7760

  19. furszy commented at 6:50 PM on March 10, 2026: member

    ACK 46189fd5264580d0320976faf81aa2f45e1a7760

  20. sedited approved
  21. sedited commented at 8:17 PM on March 10, 2026: contributor

    ACK 46189fd5264580d0320976faf81aa2f45e1a7760

  22. sedited merged this on Mar 10, 2026
  23. sedited closed this on Mar 10, 2026
Contributors
rkruxDrahtBotl0rincfanquakehebastotheStackfurszysedited
Labels
Docs

Milestone
31.0

Linked (view graph)
#3 Encrypt wallet#4 Export/Import wallet in a human readable, future-proof format
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-24 12:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me