test: Remove vulture from ci, Remove some --min-confidence=60 unused code #34816

maflcko commented at 12:34 PM on March 12, 2026: member

Currently, vulture is run with --min-confidence=100, which reduces its checks to dead code after control statements, which is nice, but not really a common nor severe issue. See the discussion in #34810 (comment) and commit 5c005363a880c136cc44ff2456a402e398fcbf44, which had to remove dead code manually.

Reducing the confidence has shown to be too brittle/tedious in the past, so remove the tool for now from CI.

Of course, removing this from CI does not prevent anyone from running it locally and removing dead code.

Fixes https://github.com/bitcoin/bitcoin/issues/34810

ci: Remove vulture fab5072ce1

DrahtBot added the label Tests on Mar 12, 2026

DrahtBot commented at 12:35 PM on March 12, 2026: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	willcl-ark, fanquake
Stale ACK	l0rinc

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#34547 (lint: modernise lint tooling by willcl-ark)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

l0rinc commented at 12:40 PM on March 12, 2026: contributor

code review ACK fab5072ce1396484b9caa7320da4dc3c98070adc

maflcko renamed this:
~~ci: Remove vulture~~
test: Remove vulture from ci, Remove some --min-confidence=60 unused code
on Mar 12, 2026

maflcko commented at 2:09 PM on March 12, 2026: member

Of course, removing this from CI does not prevent anyone from running it locally and removing dead code.

Went ahead and did this myself. I ran vulture $( git ls-files -- '*.py' ) and then manually went through the ~200 lines and removed the stuff that was really unused.

DrahtBot added the label CI failed on Mar 12, 2026

willcl-ark commented at 2:45 PM on March 12, 2026: member

I see this locally?

F401 [*] `test_framework.script_util.key_to_p2pk_script` imported but unused
  --> test/functional/feature_segwit.py:32:5
   |
30 | )
31 | from test_framework.script_util import (
32 |     key_to_p2pk_script,
   |     ^^^^^^^^^^^^^^^^^^
33 |     key_to_p2wpkh_script,
34 |     keys_to_multisig_script,
   |
help: Remove unused import

F401 [*] `test_framework.script_util.key_to_p2wpkh_script` imported but unused
  --> test/functional/feature_segwit.py:33:5
   |
31 | from test_framework.script_util import (
32 |     key_to_p2pk_script,
33 |     key_to_p2wpkh_script,
   |     ^^^^^^^^^^^^^^^^^^^^
34 |     keys_to_multisig_script,
35 |     script_to_p2sh_script,
   |
help: Remove unused import

F401 [*] `test_framework.script_util.script_to_p2sh_script` imported but unused
  --> test/functional/feature_segwit.py:35:5
   |
33 |     key_to_p2wpkh_script,
34 |     keys_to_multisig_script,
35 |     script_to_p2sh_script,
   |     ^^^^^^^^^^^^^^^^^^^^^
36 |     script_to_p2wsh_script,
37 | )
   |
help: Remove unused import

F401 [*] `test_framework.script_util.script_to_p2wsh_script` imported but unused
  --> test/functional/feature_segwit.py:36:5
   |
34 |     keys_to_multisig_script,
35 |     script_to_p2sh_script,
36 |     script_to_p2wsh_script,
   |     ^^^^^^^^^^^^^^^^^^^^^^
37 | )
38 | from test_framework.test_framework import BitcoinTestFramework
   |
help: Remove unused import

F401 [*] `enum` imported but unused
  --> test/functional/test_framework/address.py:11:8
   |
 9 | - bech32m segwit v1 P2TR addresses."""
10 |
11 | import enum
   |        ^^^^
12 | import unittest
   |
help: Remove unused import: `enum`

Found 5 errors.
[*] 5 fixable with the `--fix` option.
^^^
`ruff` found errors!
^---- ⚠️ Failure generated from lint check 'py_lint' (Lint Python code)!


src/crc32c in HEAD currently refers to tree 28f07d0bd5d6fcd3273d9651ff3c960ad344c202
src/crc32c in HEAD was last updated in commit 9a5d29711afcdc4609da4786673758e641958bb4 (tree 28f07d0bd5d6fcd3273d9651ff3c960ad344c202)
GOOD
src/crypto/ctaes in HEAD currently refers to tree 1b6c31139a71f80245c09597c343936a8e41d021
src/crypto/ctaes in HEAD was last updated in commit 8501bedd7508ac514385806e191aec21ee978891 (tree 1b6c31139a71f80245c09597c343936a8e41d021)
GOOD
src/ipc/libmultiprocess in HEAD currently refers to tree f88433d756e02de05276361a5c7e41c71dd58231
src/ipc/libmultiprocess in HEAD was last updated in commit b7ca3bf061b51108d155283c1ad503c0af7eab0d (tree f88433d756e02de05276361a5c7e41c71dd58231)
GOOD
src/leveldb in HEAD currently refers to tree fe97d24767d36e3d80902af8da83a46f68c34b96
src/leveldb in HEAD was last updated in commit 2f2952c5f2e367ccac34025a159c9fbaffd7f172 (tree fe97d24767d36e3d80902af8da83a46f68c34b96)
GOOD
src/minisketch in HEAD currently refers to tree f1581edd423bcf531d0d956149eb8abe45f75570
src/minisketch in HEAD was last updated in commit 4543a3bde26ff2440c16b06cc1dcf1994dc85720 (tree f1581edd423bcf531d0d956149eb8abe45f75570)
GOOD
src/secp256k1 in HEAD currently refers to tree 15001ae05f06101b13596633fad8c75dcec693b0
src/secp256k1 in HEAD was last updated in commit 9d4c9b00356e02de223033adb7680b47b743caab (tree 15001ae05f06101b13596633fad8c75dcec693b0)
GOOD
test/functional/feature_segwit.py:70: error: Need type annotation for "txs_mined" (hint: "txs_mined: dict[<type>, <type>] = ...")  [var-annotated]
Found 1 error in 1 file (checked 311 source files)
^---- ⚠️ Failure generated from lint-python.py
^^^

^---- ⚠️ Failure generated from lint check 'all_python_linters' (Run all linters of the form: test/lint/lint-*.py)!

test: Remove unused AddressType

unused after commit c847dee1488a294c9a9632a00ba1134b21e41947

fa803710e2

test: Remove unused self.p2p_conn_index = 1

Was never used

fa388a3585

test: Remove unused wait_for_addr, firstAddrnServices, on_addr

Unused after commit be25ac3092b7755e26e1ec6c33a27cd0e3dd9eac

fa7bac94d8

test: Remove unused CUSTOM_._COUNT

Unused after commit cf3ab8e1d0a2f2bdf72e61e2c2dcb35987e5b9bd

fa6b05c96f

test: Remove unused feature_segwit.py functions

Unused after commit c847dee1488a294c9a9632a00ba1134b21e41947

fa90b21430

maflcko force-pushed on Mar 12, 2026

maflcko commented at 3:06 PM on March 12, 2026: member

I see this locally?

Thx, removed all those lines as well. Let's see if lint CI passes ... edit: passed

DrahtBot removed the label CI failed on Mar 12, 2026

willcl-ark approved

willcl-ark commented at 10:30 AM on March 14, 2026: member

ACK fa90b21430b4f3bae6f4092a27e611bb06f2777f

Changes LGTM.

Of course, removing this from CI does not prevent anyone from running it locally and removing dead code.

Well, its free to run on GHA so stuck it in my nightly repo at confidence level 100.

Could probably set it to run monthly at confidence=60 and have claude prune the output for false positives, but not sure there is enough demand/benefit.

DrahtBot requested review from l0rinc on Mar 14, 2026

fanquake commented at 4:33 AM on March 16, 2026: member

ACK fa90b21430b4f3bae6f4092a27e611bb06f2777f

fanquake merged this on Mar 16, 2026

fanquake closed this on Mar 16, 2026

maflcko deleted the branch on Mar 16, 2026

maflcko commented at 6:42 AM on March 16, 2026: member

Could probably set it to run monthly at confidence=60 and have claude prune the output for false positives, but not sure there is enough demand/benefit.

I was thinking about once before every branch-off (6 months), or just once every time we find one dead function manually, re-run the tool for all code.