ci: Retry on intermittent Windows generate download failures #34859

1. 
   maflcko commented at 8:21 am on March 19, 2026: member

   The CI Windows step to generate the build system is problematic, because with a clean cache, it will download artifacts over the network. This may intermittently fail due to intermittent network issues.

   Fix this issue, like all other network issues in CI, by retrying once.

2. ci: Avoid intermittent Windows generate download failures fa71c6e84c
3. DrahtBot added the label Tests on Mar 19, 2026
4. 
   DrahtBot commented at 8:21 am on March 19, 2026: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	hodlinator, hebasto

   If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #31507 (build: Use clang-cl to build on Windows natively by hebasto)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

5. fanquake added the label Needs Backport (31.x) on Mar 19, 2026
6. 
   fanquake commented at 11:33 am on March 19, 2026: member

   cc @hodlinator @hebasto
7. 
   hodlinator commented at 2:30 pm on March 19, 2026: contributor

   ACK fa71c6e84c16418ffc5568c06aed863027cb238f

   Modified the cmake parameters to provoke failure and verify behaviour.

    0₿ ./.github/ci-windows.py standard generate
    1+ cmake - build -Werror=dev --preset vs2026 -DBUILD_BENCH=ON -DBUILD_KERNEL_LIB=ON -DBUILD_UTIL_CHAINSTATE=ON -DCMAKE_COMPILE_WARNING_AS_ERROR=ON
    2CMake Error: Unknown argument -
    3CMake Error: Run 'cmake --help' for all supported options.
    4=== ⚠️ ===
    5Generate failure! Network issue? Retry once ...
    6=== ⚠️ ===
    7+ cmake - build -Werror=dev --preset vs2026 -DBUILD_BENCH=ON -DBUILD_KERNEL_LIB=ON -DBUILD_UTIL_CHAINSTATE=ON -DCMAKE_COMPILE_WARNING_AS_ERROR=ON
    8CMake Error: Unknown argument -
    9CMake Error: Run 'cmake --help' for all supported options.
   10Command '['cmake', '-', 'build', '-Werror=dev', '--preset', 'vs2026', '-DBUILD_BENCH=ON', '-DBUILD_KERNEL_LIB=ON', '-DBUILD_UTIL_CHAINSTATE=ON', '-DCMAKE_COMPILE_WARNING_AS_ERROR=ON']' returned non-zero exit status 1.
   

8. hebasto approved
9. 
   hebasto commented at 8:06 pm on March 19, 2026: member

   ACK fa71c6e84c16418ffc5568c06aed863027cb238f, I have reviewed the code and it looks OK.

   nanonit: s/Avoid/Mitigate/

10. maflcko renamed this:
    ci: Avoid intermittent Windows generate download failures
    ci: Retry on intermittent Windows generate download failures
    on Mar 19, 2026
11. 
    maflcko commented at 8:32 pm on March 19, 2026: member

    nanonit: s/Avoid/Mitigate/

    Sure, changed title a bit

12. fanquake merged this on Mar 20, 2026
13. fanquake closed this on Mar 20, 2026

    ---

14. fanquake referenced this in commit d9a57912c6 on Mar 20, 2026
15. fanquake removed the label Needs Backport (31.x) on Mar 20, 2026
16. 
    fanquake commented at 1:21 am on March 20, 2026: member

    Backported to 31.x in #34800.
17. maflcko deleted the branch on Mar 20, 2026

Contributors
maflcko DrahtBot fanquake hodlinator hebasto

Labels
Tests