The CI Windows step to generate the build system is problematic, because with a clean cache, it will download artifacts over the network. This may intermittently fail due to intermittent network issues.
Fix this issue, like all other network issues in CI, by retrying once.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | hodlinator, hebasto |
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--174a7506f384e20aa4161008e828411d-->
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
ACK fa71c6e84c16418ffc5568c06aed863027cb238f
Modified the cmake parameters to provoke failure and verify behaviour.
₿ ./.github/ci-windows.py standard generate
+ cmake - build -Werror=dev --preset vs2026 -DBUILD_BENCH=ON -DBUILD_KERNEL_LIB=ON -DBUILD_UTIL_CHAINSTATE=ON -DCMAKE_COMPILE_WARNING_AS_ERROR=ON
CMake Error: Unknown argument -
CMake Error: Run 'cmake --help' for all supported options.
=== ⚠️ ===
Generate failure! Network issue? Retry once ...
=== ⚠️ ===
+ cmake - build -Werror=dev --preset vs2026 -DBUILD_BENCH=ON -DBUILD_KERNEL_LIB=ON -DBUILD_UTIL_CHAINSTATE=ON -DCMAKE_COMPILE_WARNING_AS_ERROR=ON
CMake Error: Unknown argument -
CMake Error: Run 'cmake --help' for all supported options.
Command '['cmake', '-', 'build', '-Werror=dev', '--preset', 'vs2026', '-DBUILD_BENCH=ON', '-DBUILD_KERNEL_LIB=ON', '-DBUILD_UTIL_CHAINSTATE=ON', '-DCMAKE_COMPILE_WARNING_AS_ERROR=ON']' returned non-zero exit status 1.
ACK fa71c6e84c16418ffc5568c06aed863027cb238f, I have reviewed the code and it looks OK.
nanonit: s/Avoid/Mitigate/
nanonit: s/Avoid/Mitigate/
Sure, changed title a bit