rpc, refactor: gettxoutsetinfo race condition fix follow-ups #34908

1. 
   rkrux commented at 11:09 am on March 24, 2026: contributor

   This patch addresses my own review comments from the review of PR 34451. If these are found helpful, it makes sense to do them now after the previous PR was merged and backported.

   Pasting the comments below that also explains the changes:

   • Move the pindex declaration below now that it is not used earlier.
   • stats was being generated partially in both these ComputeUTXOStats functions, which reads oddly to me. Now that the pcursor is also moved and passed to this function, which reads oddly as well, I believe we can refactor this function to completely build the stats inside this function. A side benefit is that by removing the stats and pcursor arguments, the function signature becomes quite similar to its namesake, which in turn becomes a straightforward wrapper of this function.
2. rpc, refactor: gettxoutsetinfo race condition fix follow-ups

   This patch addresses my own review comments from the review of PR 34451.
   If these are found helpful, it makes sense to do them now after the previous
   PR was merged and backported.
   
   Pasting the comments below that also explains the changes:
   
   - Move the pindex declaration below now that it is not used earlier.
   - stats was being generated partially in both these ComputeUTXOStats functions,
   which reads oddly to me. Now that the pcursor is also moved and passed to this
   function, which reads oddly as well, I believe we can refactor this function
   to completely build the stats inside this function. A side benefit is that by
   removing the stats and pcursor arguments, the function signature becomes quite
   similar to its namesake, which in turn becomes a straightforward wrapper of
   this function.

   3e5dc61035
3. 
   DrahtBot commented at 11:09 am on March 24, 2026: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	w0xlt

   If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #34729 (Reduce log noise by ajtowns)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. 
   w0xlt commented at 5:43 pm on March 25, 2026: contributor

   ACK 3e5dc610353ef16b0e7f391faaac77da6f4a0fab

   I would recommend running Antithesis again against this change.

5. 
   fanquake commented at 11:34 pm on March 25, 2026: member

   cc @dergoegge

Contributors
rkrux DrahtBot w0xlt fanquake