wallet: mark bip125-replaceable deprecated, remove walletrbf argument #34917

pull rkrux wants to merge 2 commits into bitcoin:master from rkrux:wallet-rbf changing 11 files +20 −28
  1. rkrux commented at 9:53 AM on March 25, 2026: contributor

    This patch set is in line with the deprecation & removal of outdated BIP 125 opt-in RBF signalling in wallet transactions.

    <!-- *** Please remove the following help text before submitting: *** Pull requests without a rationale and clear improvement may be closed immediately. GUI-related pull requests should be opened against https://github.com/bitcoin-core/gui first. See CONTRIBUTING.md -->

    <!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible. * Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they *significantly* improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. -->

    <!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. -->

  2. wallet: mark `bip125-replaceable` key as deprecated in transaction RPCs
    Transactions are replaceable by default since v28 and the corresponding
tweaking argument has been removed since v29. The related key from the
mempool RPC has been marked deprecated as well since v29, this patch
does the same for the wallet.
    849e13c8b0
  3. wallet: remove `-walletrbf` argument
    All transactions are by default replaceable since v28, the wallet need not have
a configuration option to opt into RBF signalling because it seems redundant
now. The default behaviour of opting into RBF signalling is retained - for now.

Users still have the option to opt out of RBF signalling via the individual
transaction creation RPC request options.
    8c0a7d6f14
  4. DrahtBot added the label Wallet on Mar 25, 2026
  5. DrahtBot commented at 9:53 AM on March 25, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #bitcoin-core/gui/911 (Adds non-mempool wallet balance to overview by ajtowns)
    • #34897 (indexes: Don't commit ahead of the flushed chainstate by mzumsande)
    • #34400 (wallet: parallel fast rescan (approx 5x speed up with 8 threads) by Eunovo)
    • #33671 (wallet: Add separate balance info for non-mempool wallet txs by ajtowns)
    • #29278 (Wallet: Add maxfeerate wallet startup option by ismaelsadeeq)
    • #21283 (Implement BIP 370 PSBTv2 by achow101)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

    LLM Linter (✨ experimental)

    Possible typos and grammar issues:

    • explcitly -> explicitly [Typo in the added comment: # ...and check the result - it's not explcitly opt-in makes the text unclear.]

    <sup>2026-03-25 09:53:59</sup>

  6. in src/wallet/init.cpp:77 in 8c0a7d6f14 
      73 | @@ -74,8 +74,6 @@ void WalletInit::AddWalletOptions(ArgsManager& argsman) const
  74 |  #if HAVE_SYSTEM
  75 |      argsman.AddArg("-walletnotify=<cmd>", "Execute command when a wallet transaction changes. %s in cmd is replaced by TxID, %w is replaced by wallet name, %b is replaced by the hash of the block including the transaction (set to 'unconfirmed' if the transaction is not included) and %h is replaced by the block height (-1 if not included). %w is not currently implemented on windows. On systems where %w is supported, it should NOT be quoted because this would break shell escaping used to invoke the command.", ArgsManager::ALLOW_ANY, OptionsCategory::WALLET);
  76 |  #endif
  77 | -    argsman.AddArg("-walletrbf", strprintf("Send transactions with full-RBF opt-in enabled (RPC only, default: %u)", DEFAULT_WALLET_RBF), ArgsManager::ALLOW_ANY, OptionsCategory::WALLET);
    w0xlt commented at 5:48 PM on March 25, 2026:

    Removing the -walletrbf registration introduces an upgrade regression: existing configs or service arguments that still set it will now prevent the node from starting. Shouldn't it remain accepted as a hidden/deprecated no-op rather than being removed outright ?

Contributors
rkruxDrahtBotw0xlt
Labels
Wallet
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me