make, such as Ubuntu 20.04 (4.2.1). It’s likely that any distros being used for Darwin and Windows cross compilation, are shipping a newer make at this point.
make, such as Ubuntu 20.04 (4.2.1). It’s likely that any distros being used for Darwin and Windows cross compilation, are shipping a newer make at this point.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| Concept ACK | hebasto |
If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.
make as well?
depends/README.md that GNU Make >= 4.3 is expected?
Isn’t depends explicitly supported for building on older systems lacking the required dependency versions? (Not just for cross-compiking)
Could you clarify how that relates to this PR?
For context, depends/hosts/mingw32.mk is strictly for cross-compiling. While depends/hosts/darwin.mk handles both cross-compiling and native static builds, using GNU Make provided by Homebrew is documented for the that use case.
This was introduced for distros shipping older make, such as
Ubuntu 20.04 (4.2.1). It's likely that all distros being used for
Darwin and Qindows cross compilation, are shipping a newer make at
this point.