depends: remove workaround for Make older than 4.2.90 #34923

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:drop_make_cross_workaround changing 3 files +19 −33
  1. fanquake commented at 1:47 am on March 26, 2026: member
    This was introduced for distros shipping older make, such as Ubuntu 20.04 (4.2.1). It’s likely that any distros being used for Darwin and Windows cross compilation, are shipping a newer make at this point.
  2. DrahtBot added the label Build system on Mar 26, 2026
  3. DrahtBot commented at 1:47 am on March 26, 2026: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    Concept ACK hebasto

    If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

  4. fanquake added the label DrahtBot Guix build requested on Mar 26, 2026
  5. fanquake force-pushed on Mar 26, 2026
  6. DrahtBot added the label CI failed on Mar 26, 2026
  7. maflcko commented at 8:34 am on March 26, 2026: member
    What about macOS. IIRC it tends to ship ancient stuff, like ancient Bash, and possibly make as well?
  8. hebasto commented at 8:57 am on March 26, 2026: member

    What about macOS. IIRC it tends to ship ancient stuff, like ancient Bash, and possibly make as well?

    Isn’t this already addressed in #32086?

  9. hebasto commented at 2:37 pm on March 26, 2026: member
    Concept ACK.
  10. hebasto commented at 2:42 pm on March 26, 2026: member
    Maybe add a note to depends/README.md that GNU Make >= 4.3 is expected?
  11. luke-jr commented at 2:14 pm on March 27, 2026: member
    Isn’t depends explicitly supported for building on older systems lacking the required dependency versions? (Not just for cross-compiking)
  12. hebasto commented at 2:59 pm on March 27, 2026: member

    Isn’t depends explicitly supported for building on older systems lacking the required dependency versions? (Not just for cross-compiking)

    Could you clarify how that relates to this PR?

    For context, depends/hosts/mingw32.mk is strictly for cross-compiling. While depends/hosts/darwin.mk handles both cross-compiling and native static builds, using GNU Make provided by Homebrew is documented for the that use case.

  13. depends: remove workaround for Make older than 4.2.90
    This was introduced for distros shipping older make, such as
    Ubuntu 20.04 (4.2.1). It's likely that all distros being used for
    Darwin and Qindows cross compilation, are shipping a newer make at
    this point.
    e9a9706061
  14. fanquake force-pushed on Mar 29, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-03-30 00:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me