guix: Split manifest into build and codesign manifests #34948

hebasto commented at 3:41 PM on March 29, 2026: member

This PR narrows the scope of the Guix environments to include only the minimum dependencies required for specific tasks, namely building and codesigning.

hebasto added the label Build system on Mar 29, 2026

DrahtBot commented at 3:41 PM on March 29, 2026: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34948.

Reviews

See the guideline for information on the review process.

Type	Reviewers
Concept ACK	janb84, fanquake

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#35131 (guix, refactor: Minor script cleanups and improvements by hebasto)
#35098 (guix: Compile GUI separately from other binaries by hebasto)
#32764 (guix: Build for macOS using Clang only by hebasto)
#25573 (guix: produce a -static-pie bitcoind by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

hebasto commented at 9:23 PM on March 29, 2026: member

My Guix build:

aarch64
3348c81ecb304113310754ec4825de796bb73a7e4d0dc821dc05e9b57f9e33a4  guix-build-04569c75de6d/output/aarch64-linux-gnu/SHA256SUMS.part
57cbe34a8e582d74970fc7208ef44f2695b2dbde6d7aac828f2d23f1cece5242  guix-build-04569c75de6d/output/aarch64-linux-gnu/bitcoin-04569c75de6d-aarch64-linux-gnu-debug.tar.gz
5f8200455074cf269e7f9f7bd6f42d345c4d6ec27b1a63c05598e2d159a1f4ff  guix-build-04569c75de6d/output/aarch64-linux-gnu/bitcoin-04569c75de6d-aarch64-linux-gnu.tar.gz
83636a1432e8590fe2f68c579f18697561410fb4715c062ce6c14c53f465c36b  guix-build-04569c75de6d/output/arm-linux-gnueabihf/SHA256SUMS.part
f48621ee451b8d35ee3e039b50d34fa16034403aae65ca2b3e781c65e812ecd7  guix-build-04569c75de6d/output/arm-linux-gnueabihf/bitcoin-04569c75de6d-arm-linux-gnueabihf-debug.tar.gz
18e7775303a598adf8050cd81d66ae7c9bd52868b8cf8773725d844fcd16faf2  guix-build-04569c75de6d/output/arm-linux-gnueabihf/bitcoin-04569c75de6d-arm-linux-gnueabihf.tar.gz
09cfcb8e6a202ec6c1c2836df76f588c5f9c41772d65a0afca684dae0fe3ccbd  guix-build-04569c75de6d/output/arm64-apple-darwin/SHA256SUMS.part
172910973066f1ec34984e28841ade0ded0bf6abec3c7490e60852fff8ca41c3  guix-build-04569c75de6d/output/arm64-apple-darwin/bitcoin-04569c75de6d-arm64-apple-darwin-codesigning.tar.gz
548c67b881daf3ff9c259b5f7f65aae17ac0dc2b7131c5b11bb273c787dda564  guix-build-04569c75de6d/output/arm64-apple-darwin/bitcoin-04569c75de6d-arm64-apple-darwin-unsigned.tar.gz
9445c4952c40a20593a56ae3f8701a303150c9d61e4bc84adbe12868c7b184a1  guix-build-04569c75de6d/output/arm64-apple-darwin/bitcoin-04569c75de6d-arm64-apple-darwin-unsigned.zip
eb6401c79be2ccf9f03841ff2627672a5a98cd4882c6dc7df4c0429b4167f517  guix-build-04569c75de6d/output/dist-archive/bitcoin-04569c75de6d.tar.gz
ff1d14fffc1d0ba803ec41042fcc255c034b3c11f114b2a55d4daab13ef94eba  guix-build-04569c75de6d/output/powerpc64-linux-gnu/SHA256SUMS.part
40ce8e6ed2fddb0ed0739129b10d261a73db1b3ab590730a523c975c483668cc  guix-build-04569c75de6d/output/powerpc64-linux-gnu/bitcoin-04569c75de6d-powerpc64-linux-gnu-debug.tar.gz
645f73d94105107b2ad6cfb36b24d201bd7f0453a33b1023137361de8d952c20  guix-build-04569c75de6d/output/powerpc64-linux-gnu/bitcoin-04569c75de6d-powerpc64-linux-gnu.tar.gz
b219b6b03a8d7fe7cdcd5075a1b02a0b68383500a7c58dbfcef94f7b76cc3e89  guix-build-04569c75de6d/output/riscv64-linux-gnu/SHA256SUMS.part
59f5f3740f1b3df5f4cb1d1b57e724bcd8cb268a6a16f3086c50c7a9569c4f82  guix-build-04569c75de6d/output/riscv64-linux-gnu/bitcoin-04569c75de6d-riscv64-linux-gnu-debug.tar.gz
d975eb894b6f4abd92a849adf036112898725156cff386672bc93adb3775ba57  guix-build-04569c75de6d/output/riscv64-linux-gnu/bitcoin-04569c75de6d-riscv64-linux-gnu.tar.gz
0623ef789456600dec1e533863ff03b2fc8131c1b1953715c312319190dfa9eb  guix-build-04569c75de6d/output/x86_64-apple-darwin/SHA256SUMS.part
4c238b210e0bdb06494de1c473acb0841aa626352834eacbcfdc8f5ebbf82038  guix-build-04569c75de6d/output/x86_64-apple-darwin/bitcoin-04569c75de6d-x86_64-apple-darwin-codesigning.tar.gz
37c0248128f762d544041ee466bd6f1b99cafb676991f60c58640f1dafe9be09  guix-build-04569c75de6d/output/x86_64-apple-darwin/bitcoin-04569c75de6d-x86_64-apple-darwin-unsigned.tar.gz
3cecf73fef4138e81cb19ad0da4a399739268fd1ed452b6da7d50509ca64f727  guix-build-04569c75de6d/output/x86_64-apple-darwin/bitcoin-04569c75de6d-x86_64-apple-darwin-unsigned.zip
32eb3d62556ab5bcb292e24eb6a0e78484a16c4354c27e1dcd4482bf5c243996  guix-build-04569c75de6d/output/x86_64-linux-gnu/SHA256SUMS.part
970baa169a7ae0347f15bf0261ea495c53806c5f12b1b66547e40a54638f728a  guix-build-04569c75de6d/output/x86_64-linux-gnu/bitcoin-04569c75de6d-x86_64-linux-gnu-debug.tar.gz
61fcf963cf38368b92cf888d3e065abb0aacebb946196d4f2c19716ad8bc1f51  guix-build-04569c75de6d/output/x86_64-linux-gnu/bitcoin-04569c75de6d-x86_64-linux-gnu.tar.gz
b04e03989bbcbe47ad79932d353cd694f5b892b552121ec221d3da9ee5b20223  guix-build-04569c75de6d/output/x86_64-w64-mingw32/SHA256SUMS.part
f03b3e23dba091b6a73a4d51f0e4002743b618d4977ed0a3270ab5542a956167  guix-build-04569c75de6d/output/x86_64-w64-mingw32/bitcoin-04569c75de6d-win64-codesigning.tar.gz
dbc06899ac55a66e41bc04f2a07302881f5da2b365df2654ca16d70ddaa99040  guix-build-04569c75de6d/output/x86_64-w64-mingw32/bitcoin-04569c75de6d-win64-debug.zip
ca52502ca823ba875804a051e2e605f749ae4ac60f5d24dd3743a329fb8f5271  guix-build-04569c75de6d/output/x86_64-w64-mingw32/bitcoin-04569c75de6d-win64-setup-unsigned.exe
d48b60773dc8657adfa047df55c281e79ff80fa05c6592ec6f2c24dad6c7bc63  guix-build-04569c75de6d/output/x86_64-w64-mingw32/bitcoin-04569c75de6d-win64-unsigned.zip

janb84 commented at 2:25 PM on March 31, 2026: contributor

my Guix Build Output

Host architecture: aarch64 Commit: 04569c7

3348c81ecb304113310754ec4825de796bb73a7e4d0dc821dc05e9b57f9e33a4  guix-build-04569c75de6d/output/aarch64-linux-gnu/SHA256SUMS.part
57cbe34a8e582d74970fc7208ef44f2695b2dbde6d7aac828f2d23f1cece5242  guix-build-04569c75de6d/output/aarch64-linux-gnu/bitcoin-04569c75de6d-aarch64-linux-gnu-debug.tar.gz
5f8200455074cf269e7f9f7bd6f42d345c4d6ec27b1a63c05598e2d159a1f4ff  guix-build-04569c75de6d/output/aarch64-linux-gnu/bitcoin-04569c75de6d-aarch64-linux-gnu.tar.gz
83636a1432e8590fe2f68c579f18697561410fb4715c062ce6c14c53f465c36b  guix-build-04569c75de6d/output/arm-linux-gnueabihf/SHA256SUMS.part
f48621ee451b8d35ee3e039b50d34fa16034403aae65ca2b3e781c65e812ecd7  guix-build-04569c75de6d/output/arm-linux-gnueabihf/bitcoin-04569c75de6d-arm-linux-gnueabihf-debug.tar.gz
18e7775303a598adf8050cd81d66ae7c9bd52868b8cf8773725d844fcd16faf2  guix-build-04569c75de6d/output/arm-linux-gnueabihf/bitcoin-04569c75de6d-arm-linux-gnueabihf.tar.gz
09cfcb8e6a202ec6c1c2836df76f588c5f9c41772d65a0afca684dae0fe3ccbd  guix-build-04569c75de6d/output/arm64-apple-darwin/SHA256SUMS.part
172910973066f1ec34984e28841ade0ded0bf6abec3c7490e60852fff8ca41c3  guix-build-04569c75de6d/output/arm64-apple-darwin/bitcoin-04569c75de6d-arm64-apple-darwin-codesigning.tar.gz
548c67b881daf3ff9c259b5f7f65aae17ac0dc2b7131c5b11bb273c787dda564  guix-build-04569c75de6d/output/arm64-apple-darwin/bitcoin-04569c75de6d-arm64-apple-darwin-unsigned.tar.gz
9445c4952c40a20593a56ae3f8701a303150c9d61e4bc84adbe12868c7b184a1  guix-build-04569c75de6d/output/arm64-apple-darwin/bitcoin-04569c75de6d-arm64-apple-darwin-unsigned.zip
eb6401c79be2ccf9f03841ff2627672a5a98cd4882c6dc7df4c0429b4167f517  guix-build-04569c75de6d/output/dist-archive/bitcoin-04569c75de6d.tar.gz
ff1d14fffc1d0ba803ec41042fcc255c034b3c11f114b2a55d4daab13ef94eba  guix-build-04569c75de6d/output/powerpc64-linux-gnu/SHA256SUMS.part
40ce8e6ed2fddb0ed0739129b10d261a73db1b3ab590730a523c975c483668cc  guix-build-04569c75de6d/output/powerpc64-linux-gnu/bitcoin-04569c75de6d-powerpc64-linux-gnu-debug.tar.gz
645f73d94105107b2ad6cfb36b24d201bd7f0453a33b1023137361de8d952c20  guix-build-04569c75de6d/output/powerpc64-linux-gnu/bitcoin-04569c75de6d-powerpc64-linux-gnu.tar.gz
b219b6b03a8d7fe7cdcd5075a1b02a0b68383500a7c58dbfcef94f7b76cc3e89  guix-build-04569c75de6d/output/riscv64-linux-gnu/SHA256SUMS.part
59f5f3740f1b3df5f4cb1d1b57e724bcd8cb268a6a16f3086c50c7a9569c4f82  guix-build-04569c75de6d/output/riscv64-linux-gnu/bitcoin-04569c75de6d-riscv64-linux-gnu-debug.tar.gz
d975eb894b6f4abd92a849adf036112898725156cff386672bc93adb3775ba57  guix-build-04569c75de6d/output/riscv64-linux-gnu/bitcoin-04569c75de6d-riscv64-linux-gnu.tar.gz
0623ef789456600dec1e533863ff03b2fc8131c1b1953715c312319190dfa9eb  guix-build-04569c75de6d/output/x86_64-apple-darwin/SHA256SUMS.part
4c238b210e0bdb06494de1c473acb0841aa626352834eacbcfdc8f5ebbf82038  guix-build-04569c75de6d/output/x86_64-apple-darwin/bitcoin-04569c75de6d-x86_64-apple-darwin-codesigning.tar.gz
37c0248128f762d544041ee466bd6f1b99cafb676991f60c58640f1dafe9be09  guix-build-04569c75de6d/output/x86_64-apple-darwin/bitcoin-04569c75de6d-x86_64-apple-darwin-unsigned.tar.gz
3cecf73fef4138e81cb19ad0da4a399739268fd1ed452b6da7d50509ca64f727  guix-build-04569c75de6d/output/x86_64-apple-darwin/bitcoin-04569c75de6d-x86_64-apple-darwin-unsigned.zip
32eb3d62556ab5bcb292e24eb6a0e78484a16c4354c27e1dcd4482bf5c243996  guix-build-04569c75de6d/output/x86_64-linux-gnu/SHA256SUMS.part
970baa169a7ae0347f15bf0261ea495c53806c5f12b1b66547e40a54638f728a  guix-build-04569c75de6d/output/x86_64-linux-gnu/bitcoin-04569c75de6d-x86_64-linux-gnu-debug.tar.gz
61fcf963cf38368b92cf888d3e065abb0aacebb946196d4f2c19716ad8bc1f51  guix-build-04569c75de6d/output/x86_64-linux-gnu/bitcoin-04569c75de6d-x86_64-linux-gnu.tar.gz
b04e03989bbcbe47ad79932d353cd694f5b892b552121ec221d3da9ee5b20223  guix-build-04569c75de6d/output/x86_64-w64-mingw32/SHA256SUMS.part
f03b3e23dba091b6a73a4d51f0e4002743b618d4977ed0a3270ab5542a956167  guix-build-04569c75de6d/output/x86_64-w64-mingw32/bitcoin-04569c75de6d-win64-codesigning.tar.gz
dbc06899ac55a66e41bc04f2a07302881f5da2b365df2654ca16d70ddaa99040  guix-build-04569c75de6d/output/x86_64-w64-mingw32/bitcoin-04569c75de6d-win64-debug.zip
ca52502ca823ba875804a051e2e605f749ae4ac60f5d24dd3743a329fb8f5271  guix-build-04569c75de6d/output/x86_64-w64-mingw32/bitcoin-04569c75de6d-win64-setup-unsigned.exe
d48b60773dc8657adfa047df55c281e79ff80fa05c6592ec6f2c24dad6c7bc63  guix-build-04569c75de6d/output/x86_64-w64-mingw32/bitcoin-04569c75de6d-win64-unsigned.zip

janb84 commented at 2:28 PM on March 31, 2026: contributor

Concept ACK 04569c75de6df1612ecce0f7035f4822fd1040ae

This seems like a good step to the goal of "the plan"

DrahtBot added the label Needs rebase on Apr 1, 2026

hebasto force-pushed on Apr 1, 2026

hebasto commented at 9:31 AM on April 1, 2026: member

Rebased on top of the merged #34944.

fanquake commented at 9:48 AM on April 1, 2026: member

~0 on the second commit, until we have an idea how the split builds will actually work. i.e different manifests will mean having to rebuild depends between compilations? I don't think there's a need to refactor code for no benefit, at this point.

hebasto commented at 10:01 AM on April 1, 2026: member

~0 on the second commit, until we have an idea how the split builds will actually work

These two commits were split from my WIP branch with the entire solution, which I'll submit as draft PR shortly.

... i.e different manifests will mean having to rebuild depends between compilations?

Yes, because of a different GUIX_ENVIRONMENT value.

fanquake commented at 10:02 AM on April 1, 2026: member

which I'll submit as draft PR shortly.

I don't think any more changes should be made, without seeing the final branch.

Yes, because of a different GUIX_ENVIRONMENT value.

Yes, and I don't think having to build depends twice, is good.

DrahtBot removed the label Needs rebase on Apr 1, 2026

hebasto commented at 2:27 PM on April 13, 2026: member

Yes, because of a different GUIX_ENVIRONMENT value.

Yes, and I don't think having to build depends twice, is good.

This has been addressed in this commit from my WIP branch.

hebasto force-pushed on Apr 13, 2026

hebasto renamed this:
~~guix: Split manifests~~
guix: Split manifest into build and codesign manifests
on Apr 13, 2026

hebasto commented at 3:11 PM on April 13, 2026: member

~0 on the second commit

Dropped.

DrahtBot added the label CI failed on Apr 13, 2026

DrahtBot removed the label CI failed on Apr 13, 2026

DrahtBot added the label Needs rebase on Apr 16, 2026

hebasto force-pushed on Apr 16, 2026

DrahtBot added the label CI failed on Apr 16, 2026

DrahtBot removed the label Needs rebase on Apr 16, 2026

DrahtBot removed the label CI failed on Apr 16, 2026

hebasto commented at 9:09 AM on April 17, 2026: member

Rebased to resolve a conflict.

My Guix build:

aarch64
fd4d83768d1c01eca82e4fb17ee9285241b0981e93c5eca7a382352ecca55cc9  guix-build-4eeaf205a3ab/output/aarch64-linux-gnu/SHA256SUMS.part
3aa3d8a812c79c6ddcf8758d22cfc66e4733c40c03dc87edb9c3b172106fc3cb  guix-build-4eeaf205a3ab/output/aarch64-linux-gnu/bitcoin-4eeaf205a3ab-aarch64-linux-gnu-debug.tar.gz
10a51e24e7108697d89fa50bad35f26289035eb64a5f25ceddc734372059d167  guix-build-4eeaf205a3ab/output/aarch64-linux-gnu/bitcoin-4eeaf205a3ab-aarch64-linux-gnu.tar.gz
68d062dfdeef0a1f2ba22e8cd3e799b49328aa810fb2dd5bf21778a0553d2140  guix-build-4eeaf205a3ab/output/arm-linux-gnueabihf/SHA256SUMS.part
741a61c8e421240e8e6ea5cb4be90db98042a4e99f98440ae337e45fda9ef411  guix-build-4eeaf205a3ab/output/arm-linux-gnueabihf/bitcoin-4eeaf205a3ab-arm-linux-gnueabihf-debug.tar.gz
002edb1311f314977b86c3b84d4398a9f7b66f8df5a5a7d1a8872babafda75f2  guix-build-4eeaf205a3ab/output/arm-linux-gnueabihf/bitcoin-4eeaf205a3ab-arm-linux-gnueabihf.tar.gz
b28f5489c0165d965895374d0068e53b2b331aaefdd1dc30ac199251431f81a2  guix-build-4eeaf205a3ab/output/arm64-apple-darwin/SHA256SUMS.part
f34734f39a0a22349da6cb5e9ede37ced08669914be5bf97514398130834605f  guix-build-4eeaf205a3ab/output/arm64-apple-darwin/bitcoin-4eeaf205a3ab-arm64-apple-darwin-codesigning.tar.gz
2ee4b22823c4705c8012049687bc9ed879c344101a768f116c6385541c700153  guix-build-4eeaf205a3ab/output/arm64-apple-darwin/bitcoin-4eeaf205a3ab-arm64-apple-darwin-unsigned.tar.gz
2afc4cbb7e3a3d8232c38b419228f62553d7d10120f0b40d306a5f9c37086d55  guix-build-4eeaf205a3ab/output/arm64-apple-darwin/bitcoin-4eeaf205a3ab-arm64-apple-darwin-unsigned.zip
4c198a6173219ed651a6f7f998efab77f48e96891da2c450b32a44269fd7973e  guix-build-4eeaf205a3ab/output/dist-archive/bitcoin-4eeaf205a3ab.tar.gz
5a6c961c10a8d553b873194756e053bae1a15f3a2a247cc20f08b82cc6aaaa1b  guix-build-4eeaf205a3ab/output/powerpc64-linux-gnu/SHA256SUMS.part
544a5991cf3c6165915ba58ff912d561b9e035ae34daf74780042f3187d92b99  guix-build-4eeaf205a3ab/output/powerpc64-linux-gnu/bitcoin-4eeaf205a3ab-powerpc64-linux-gnu-debug.tar.gz
2a5cbde7cb65ed373294fca8a7e374ca6a4ae8ac53b2105b45e69d4d6681f24e  guix-build-4eeaf205a3ab/output/powerpc64-linux-gnu/bitcoin-4eeaf205a3ab-powerpc64-linux-gnu.tar.gz
6a1d064cf22011d05645f7236dae5c20e8dd79420dcfcd9ce5238243612da545  guix-build-4eeaf205a3ab/output/riscv64-linux-gnu/SHA256SUMS.part
ab4f85d39d356879feb4d0a287db51b95b5eae570411a59fd261fc2cf2cacee7  guix-build-4eeaf205a3ab/output/riscv64-linux-gnu/bitcoin-4eeaf205a3ab-riscv64-linux-gnu-debug.tar.gz
f203fc624ab5b9421a0a82958da0bd8190261b29a78950939ab2bfbb3384daa0  guix-build-4eeaf205a3ab/output/riscv64-linux-gnu/bitcoin-4eeaf205a3ab-riscv64-linux-gnu.tar.gz
7a091eefa2a8d9c6b78576f522f5e603c7e45353e0b3e92c5eca7a23757b555b  guix-build-4eeaf205a3ab/output/x86_64-apple-darwin/SHA256SUMS.part
0a4e1afb2d468b89aa961765c3fac29aaa6f93bb7901003cddddf6d052a34466  guix-build-4eeaf205a3ab/output/x86_64-apple-darwin/bitcoin-4eeaf205a3ab-x86_64-apple-darwin-codesigning.tar.gz
5e925b032b3c2418b3848d2134f67cbd3f36984a73b00bc9f9df9f076676c37d  guix-build-4eeaf205a3ab/output/x86_64-apple-darwin/bitcoin-4eeaf205a3ab-x86_64-apple-darwin-unsigned.tar.gz
c64fc69be436d4cab3896573358c2606936aa6d6a4170b0e1f942719b3644467  guix-build-4eeaf205a3ab/output/x86_64-apple-darwin/bitcoin-4eeaf205a3ab-x86_64-apple-darwin-unsigned.zip
ddb8a58a8262b48aaf861553d6afc29fc70498ad26a87bd672d2333c81bb0975  guix-build-4eeaf205a3ab/output/x86_64-linux-gnu/SHA256SUMS.part
6f5c22d12c41b5cfa233835412ee6953879034d71b99ed860baa489d25178ab5  guix-build-4eeaf205a3ab/output/x86_64-linux-gnu/bitcoin-4eeaf205a3ab-x86_64-linux-gnu-debug.tar.gz
bca5704eadae70b03373954dba647ead1fa776d1c240d75a3d05d2e744eaad94  guix-build-4eeaf205a3ab/output/x86_64-linux-gnu/bitcoin-4eeaf205a3ab-x86_64-linux-gnu.tar.gz
bf2a2152cf29164ceb5449f2eaf8824d2f6c74435e25bd94fc247e1cc9470247  guix-build-4eeaf205a3ab/output/x86_64-w64-mingw32/SHA256SUMS.part
de539b3a64f4f16c59592e922ab934c39305b4385caccbd5a1158a27244a57d8  guix-build-4eeaf205a3ab/output/x86_64-w64-mingw32/bitcoin-4eeaf205a3ab-win64-codesigning.tar.gz
120deb6f47af81619dcd2a3fc53f45d124552c52fb9a9c77f7c3476c1b55d993  guix-build-4eeaf205a3ab/output/x86_64-w64-mingw32/bitcoin-4eeaf205a3ab-win64-debug.zip
f7bcdc2fc7722f9e313fa1bcb30223e171d1b7a0d1e2f03f7f3f87730d7fff0e  guix-build-4eeaf205a3ab/output/x86_64-w64-mingw32/bitcoin-4eeaf205a3ab-win64-setup-unsigned.exe
320bc03353bfdc19823a0fdea00ee7b63063e13ccf24dc96fca06c52d9dcf4a8  guix-build-4eeaf205a3ab/output/x86_64-w64-mingw32/bitcoin-4eeaf205a3ab-win64-unsigned.zip

fanquake commented at 9:35 AM on April 17, 2026: member

which I'll submit as draft PR shortly.

Is this available somewhere? Seems like more changes are being split up and PR'd (#35072).

hebasto commented at 10:53 AM on April 17, 2026: member

which I'll submit as draft PR shortly.

Is this available somewhere? Seems like more changes are being split up and PR'd (#35072).

Yes, I just opened it here: #35098.

fanquake commented at 2:41 PM on May 11, 2026: member

Concept ACK - can you rebase on master.

hebasto force-pushed on May 11, 2026

hebasto commented at 4:26 PM on May 11, 2026: member

Concept ACK - can you rebase on master.

Rebased.

fanquake commented at 6:21 PM on May 11, 2026: member

Guix Build (x86_64):

dd1b45ada04c2b1b2199011a754fcaccc54f06ef70a8493a9a0a4e278de37d8d  guix-build-241b60b8267b/output/aarch64-linux-gnu/SHA256SUMS.part
aad00bce2f54c98e6e02fe3dc9607bced5b77f4e0ba093cd7c44aef10f92ceb7  guix-build-241b60b8267b/output/aarch64-linux-gnu/bitcoin-241b60b8267b-aarch64-linux-gnu-debug.tar.gz
fb2479a774b41c54d9b7b854c9d0dc2da24d39c00bd52641474050bc03ac3906  guix-build-241b60b8267b/output/aarch64-linux-gnu/bitcoin-241b60b8267b-aarch64-linux-gnu.tar.gz
5b530e5d179c4c5f7bf894a0cb91716220e7e2bbf355225430bc034e444a8e5a  guix-build-241b60b8267b/output/arm-linux-gnueabihf/SHA256SUMS.part
bbfb279a02bd878f2e84d8496cb41d68bcbeb0ddde8a8857b9b7b4e873d7708f  guix-build-241b60b8267b/output/arm-linux-gnueabihf/bitcoin-241b60b8267b-arm-linux-gnueabihf-debug.tar.gz
3e93f097e3c6373f8ad4dd3822c9743a67c7591eca1a179220ab455ffd49f8a9  guix-build-241b60b8267b/output/arm-linux-gnueabihf/bitcoin-241b60b8267b-arm-linux-gnueabihf.tar.gz
b5dba3bb2ca70640a5260d704b01fc914eb6145e9ae56124236b543214a917fe  guix-build-241b60b8267b/output/arm64-apple-darwin/SHA256SUMS.part
a2b316ddb54f7c04fb2773bfd0ed066505d155a71a1b80175d69075be6326755  guix-build-241b60b8267b/output/arm64-apple-darwin/bitcoin-241b60b8267b-arm64-apple-darwin-codesigning.tar.gz
ef89f719a6b52996ef62d92d25b9e0117a74038faef09c247e11cb59ff54ba68  guix-build-241b60b8267b/output/arm64-apple-darwin/bitcoin-241b60b8267b-arm64-apple-darwin-unsigned.tar.gz
4cc44be56bf58ef98e52001d17b8cd3bd7520444f706084444555a2cf7fa6ef1  guix-build-241b60b8267b/output/arm64-apple-darwin/bitcoin-241b60b8267b-arm64-apple-darwin-unsigned.zip
34cffde87d8a8caf5614adcd5460f1d73f09e5c0b9b6fbddad0e646ce8ef3ab5  guix-build-241b60b8267b/output/dist-archive/bitcoin-241b60b8267b.tar.gz
1db718a699cf6c216ad1915163583e25d0a01af52e6d934ac09df67896e83a85  guix-build-241b60b8267b/output/powerpc64-linux-gnu/SHA256SUMS.part
cbe6cf9c92483a2b0175716de10a0392a8b6ed434127abc2549bb7f8073a3bd4  guix-build-241b60b8267b/output/powerpc64-linux-gnu/bitcoin-241b60b8267b-powerpc64-linux-gnu-debug.tar.gz
cc0b28881570d875a5878339ff9995095d7a29c64013718da8ec87bf8bb3fed7  guix-build-241b60b8267b/output/powerpc64-linux-gnu/bitcoin-241b60b8267b-powerpc64-linux-gnu.tar.gz
7ebff85c8b70006a4e8e4e59c621307c3c0445c2d6e88f2d2291da3f58dc4a52  guix-build-241b60b8267b/output/riscv64-linux-gnu/SHA256SUMS.part
be2068683f9ec6a0efe1b7fcb0f7987dcb6db883c8f3f3d8552d24fca71779f7  guix-build-241b60b8267b/output/riscv64-linux-gnu/bitcoin-241b60b8267b-riscv64-linux-gnu-debug.tar.gz
f02974ac6193946cecb4d245ff1b803eb4d0ed0d4fa106447a94dce57392986a  guix-build-241b60b8267b/output/riscv64-linux-gnu/bitcoin-241b60b8267b-riscv64-linux-gnu.tar.gz
ba77d37ac258347ac94f05abc604ef488809ac69c93010da673f29176d791c52  guix-build-241b60b8267b/output/x86_64-apple-darwin/SHA256SUMS.part
b27416cad4406982972550496a9c6622422ea024ade0fe74821b25bdbf3cebbb  guix-build-241b60b8267b/output/x86_64-apple-darwin/bitcoin-241b60b8267b-x86_64-apple-darwin-codesigning.tar.gz
8a44c2998f03e8b7f50335b3f80ad9dc900a1842d200b23c538d16444c75a644  guix-build-241b60b8267b/output/x86_64-apple-darwin/bitcoin-241b60b8267b-x86_64-apple-darwin-unsigned.tar.gz
dda50ad073558869d2822ccfffefde08fa41a69927f367478986579cd4b94917  guix-build-241b60b8267b/output/x86_64-apple-darwin/bitcoin-241b60b8267b-x86_64-apple-darwin-unsigned.zip
9932d0651ff95a3c17d770a2138d97dc9bed939fdb82ce4388b65eccb6edffa3  guix-build-241b60b8267b/output/x86_64-linux-gnu/SHA256SUMS.part
4146df1eb0ef138f20c4f2892aa4e5591024c74c5f3565a6b56a5fd3e934c143  guix-build-241b60b8267b/output/x86_64-linux-gnu/bitcoin-241b60b8267b-x86_64-linux-gnu-debug.tar.gz
07ab766e89cb630f370a803bba525596b2f4a2b58f8959a76315c4571c8797ba  guix-build-241b60b8267b/output/x86_64-linux-gnu/bitcoin-241b60b8267b-x86_64-linux-gnu.tar.gz
c3fcf4603ca1ffd30a1a78437f1814cd89a0d315fea68e5b1ab9a88aff2174ac  guix-build-241b60b8267b/output/x86_64-w64-mingw32/SHA256SUMS.part
b523147d863881df87c9ea7eab97f200bb00b72e6660809990fbf84e1f3936e3  guix-build-241b60b8267b/output/x86_64-w64-mingw32/bitcoin-241b60b8267b-win64-codesigning.tar.gz
c28bbf9a96551ebdf5b565d42b536ad08b0218f8c61fe641e71a37c19f0a9fbd  guix-build-241b60b8267b/output/x86_64-w64-mingw32/bitcoin-241b60b8267b-win64-debug.zip
43190f078e7b7ccf979637f07d4ca6229b53b5ef568970d81a05b4cbdf4d26e1  guix-build-241b60b8267b/output/x86_64-w64-mingw32/bitcoin-241b60b8267b-win64-setup-unsigned.exe
5000b9b126500ff31b8a84f9bde0e780ff80e5554429c6efd9eb66fe9b42af4d  guix-build-241b60b8267b/output/x86_64-w64-mingw32/bitcoin-241b60b8267b-win64-unsigned.zip

hebasto commented at 6:23 PM on May 11, 2026: member

My Guix build:

aarch64
dd1b45ada04c2b1b2199011a754fcaccc54f06ef70a8493a9a0a4e278de37d8d  guix-build-241b60b8267b/output/aarch64-linux-gnu/SHA256SUMS.part
aad00bce2f54c98e6e02fe3dc9607bced5b77f4e0ba093cd7c44aef10f92ceb7  guix-build-241b60b8267b/output/aarch64-linux-gnu/bitcoin-241b60b8267b-aarch64-linux-gnu-debug.tar.gz
fb2479a774b41c54d9b7b854c9d0dc2da24d39c00bd52641474050bc03ac3906  guix-build-241b60b8267b/output/aarch64-linux-gnu/bitcoin-241b60b8267b-aarch64-linux-gnu.tar.gz
5b530e5d179c4c5f7bf894a0cb91716220e7e2bbf355225430bc034e444a8e5a  guix-build-241b60b8267b/output/arm-linux-gnueabihf/SHA256SUMS.part
bbfb279a02bd878f2e84d8496cb41d68bcbeb0ddde8a8857b9b7b4e873d7708f  guix-build-241b60b8267b/output/arm-linux-gnueabihf/bitcoin-241b60b8267b-arm-linux-gnueabihf-debug.tar.gz
3e93f097e3c6373f8ad4dd3822c9743a67c7591eca1a179220ab455ffd49f8a9  guix-build-241b60b8267b/output/arm-linux-gnueabihf/bitcoin-241b60b8267b-arm-linux-gnueabihf.tar.gz
b5dba3bb2ca70640a5260d704b01fc914eb6145e9ae56124236b543214a917fe  guix-build-241b60b8267b/output/arm64-apple-darwin/SHA256SUMS.part
a2b316ddb54f7c04fb2773bfd0ed066505d155a71a1b80175d69075be6326755  guix-build-241b60b8267b/output/arm64-apple-darwin/bitcoin-241b60b8267b-arm64-apple-darwin-codesigning.tar.gz
ef89f719a6b52996ef62d92d25b9e0117a74038faef09c247e11cb59ff54ba68  guix-build-241b60b8267b/output/arm64-apple-darwin/bitcoin-241b60b8267b-arm64-apple-darwin-unsigned.tar.gz
4cc44be56bf58ef98e52001d17b8cd3bd7520444f706084444555a2cf7fa6ef1  guix-build-241b60b8267b/output/arm64-apple-darwin/bitcoin-241b60b8267b-arm64-apple-darwin-unsigned.zip
34cffde87d8a8caf5614adcd5460f1d73f09e5c0b9b6fbddad0e646ce8ef3ab5  guix-build-241b60b8267b/output/dist-archive/bitcoin-241b60b8267b.tar.gz
1db718a699cf6c216ad1915163583e25d0a01af52e6d934ac09df67896e83a85  guix-build-241b60b8267b/output/powerpc64-linux-gnu/SHA256SUMS.part
cbe6cf9c92483a2b0175716de10a0392a8b6ed434127abc2549bb7f8073a3bd4  guix-build-241b60b8267b/output/powerpc64-linux-gnu/bitcoin-241b60b8267b-powerpc64-linux-gnu-debug.tar.gz
cc0b28881570d875a5878339ff9995095d7a29c64013718da8ec87bf8bb3fed7  guix-build-241b60b8267b/output/powerpc64-linux-gnu/bitcoin-241b60b8267b-powerpc64-linux-gnu.tar.gz
7ebff85c8b70006a4e8e4e59c621307c3c0445c2d6e88f2d2291da3f58dc4a52  guix-build-241b60b8267b/output/riscv64-linux-gnu/SHA256SUMS.part
be2068683f9ec6a0efe1b7fcb0f7987dcb6db883c8f3f3d8552d24fca71779f7  guix-build-241b60b8267b/output/riscv64-linux-gnu/bitcoin-241b60b8267b-riscv64-linux-gnu-debug.tar.gz
f02974ac6193946cecb4d245ff1b803eb4d0ed0d4fa106447a94dce57392986a  guix-build-241b60b8267b/output/riscv64-linux-gnu/bitcoin-241b60b8267b-riscv64-linux-gnu.tar.gz
ba77d37ac258347ac94f05abc604ef488809ac69c93010da673f29176d791c52  guix-build-241b60b8267b/output/x86_64-apple-darwin/SHA256SUMS.part
b27416cad4406982972550496a9c6622422ea024ade0fe74821b25bdbf3cebbb  guix-build-241b60b8267b/output/x86_64-apple-darwin/bitcoin-241b60b8267b-x86_64-apple-darwin-codesigning.tar.gz
8a44c2998f03e8b7f50335b3f80ad9dc900a1842d200b23c538d16444c75a644  guix-build-241b60b8267b/output/x86_64-apple-darwin/bitcoin-241b60b8267b-x86_64-apple-darwin-unsigned.tar.gz
dda50ad073558869d2822ccfffefde08fa41a69927f367478986579cd4b94917  guix-build-241b60b8267b/output/x86_64-apple-darwin/bitcoin-241b60b8267b-x86_64-apple-darwin-unsigned.zip
9932d0651ff95a3c17d770a2138d97dc9bed939fdb82ce4388b65eccb6edffa3  guix-build-241b60b8267b/output/x86_64-linux-gnu/SHA256SUMS.part
4146df1eb0ef138f20c4f2892aa4e5591024c74c5f3565a6b56a5fd3e934c143  guix-build-241b60b8267b/output/x86_64-linux-gnu/bitcoin-241b60b8267b-x86_64-linux-gnu-debug.tar.gz
07ab766e89cb630f370a803bba525596b2f4a2b58f8959a76315c4571c8797ba  guix-build-241b60b8267b/output/x86_64-linux-gnu/bitcoin-241b60b8267b-x86_64-linux-gnu.tar.gz
c3fcf4603ca1ffd30a1a78437f1814cd89a0d315fea68e5b1ab9a88aff2174ac  guix-build-241b60b8267b/output/x86_64-w64-mingw32/SHA256SUMS.part
b523147d863881df87c9ea7eab97f200bb00b72e6660809990fbf84e1f3936e3  guix-build-241b60b8267b/output/x86_64-w64-mingw32/bitcoin-241b60b8267b-win64-codesigning.tar.gz
c28bbf9a96551ebdf5b565d42b536ad08b0218f8c61fe641e71a37c19f0a9fbd  guix-build-241b60b8267b/output/x86_64-w64-mingw32/bitcoin-241b60b8267b-win64-debug.zip
43190f078e7b7ccf979637f07d4ca6229b53b5ef568970d81a05b4cbdf4d26e1  guix-build-241b60b8267b/output/x86_64-w64-mingw32/bitcoin-241b60b8267b-win64-setup-unsigned.exe
5000b9b126500ff31b8a84f9bde0e780ff80e5554429c6efd9eb66fe9b42af4d  guix-build-241b60b8267b/output/x86_64-w64-mingw32/bitcoin-241b60b8267b-win64-unsigned.zip

fanquake commented at 6:24 PM on May 11, 2026: member

@pinheadmz can you test codesigning with the changes here?

pinheadmz commented at 6:28 PM on May 11, 2026: member

@pinheadmz can you test codesigning with the changes here?

👍 starting a build...

pinheadmz commented at 12:09 AM on May 12, 2026: member

guix build non codesigned

aad00bce2f54c98e6e02fe3dc9607bced5b77f4e0ba093cd7c44aef10f92ceb7  bitcoin-241b60b8267b-aarch64-linux-gnu-debug.tar.gz
fb2479a774b41c54d9b7b854c9d0dc2da24d39c00bd52641474050bc03ac3906  bitcoin-241b60b8267b-aarch64-linux-gnu.tar.gz
bbfb279a02bd878f2e84d8496cb41d68bcbeb0ddde8a8857b9b7b4e873d7708f  bitcoin-241b60b8267b-arm-linux-gnueabihf-debug.tar.gz
3e93f097e3c6373f8ad4dd3822c9743a67c7591eca1a179220ab455ffd49f8a9  bitcoin-241b60b8267b-arm-linux-gnueabihf.tar.gz
a2b316ddb54f7c04fb2773bfd0ed066505d155a71a1b80175d69075be6326755  bitcoin-241b60b8267b-arm64-apple-darwin-codesigning.tar.gz
ef89f719a6b52996ef62d92d25b9e0117a74038faef09c247e11cb59ff54ba68  bitcoin-241b60b8267b-arm64-apple-darwin-unsigned.tar.gz
4cc44be56bf58ef98e52001d17b8cd3bd7520444f706084444555a2cf7fa6ef1  bitcoin-241b60b8267b-arm64-apple-darwin-unsigned.zip
34cffde87d8a8caf5614adcd5460f1d73f09e5c0b9b6fbddad0e646ce8ef3ab5  bitcoin-241b60b8267b.tar.gz
cbe6cf9c92483a2b0175716de10a0392a8b6ed434127abc2549bb7f8073a3bd4  bitcoin-241b60b8267b-powerpc64-linux-gnu-debug.tar.gz
cc0b28881570d875a5878339ff9995095d7a29c64013718da8ec87bf8bb3fed7  bitcoin-241b60b8267b-powerpc64-linux-gnu.tar.gz
be2068683f9ec6a0efe1b7fcb0f7987dcb6db883c8f3f3d8552d24fca71779f7  bitcoin-241b60b8267b-riscv64-linux-gnu-debug.tar.gz
f02974ac6193946cecb4d245ff1b803eb4d0ed0d4fa106447a94dce57392986a  bitcoin-241b60b8267b-riscv64-linux-gnu.tar.gz
b27416cad4406982972550496a9c6622422ea024ade0fe74821b25bdbf3cebbb  bitcoin-241b60b8267b-x86_64-apple-darwin-codesigning.tar.gz
8a44c2998f03e8b7f50335b3f80ad9dc900a1842d200b23c538d16444c75a644  bitcoin-241b60b8267b-x86_64-apple-darwin-unsigned.tar.gz
dda50ad073558869d2822ccfffefde08fa41a69927f367478986579cd4b94917  bitcoin-241b60b8267b-x86_64-apple-darwin-unsigned.zip
4146df1eb0ef138f20c4f2892aa4e5591024c74c5f3565a6b56a5fd3e934c143  bitcoin-241b60b8267b-x86_64-linux-gnu-debug.tar.gz
07ab766e89cb630f370a803bba525596b2f4a2b58f8959a76315c4571c8797ba  bitcoin-241b60b8267b-x86_64-linux-gnu.tar.gz
b523147d863881df87c9ea7eab97f200bb00b72e6660809990fbf84e1f3936e3  bitcoin-241b60b8267b-win64-codesigning.tar.gz
c28bbf9a96551ebdf5b565d42b536ad08b0218f8c61fe641e71a37c19f0a9fbd  bitcoin-241b60b8267b-win64-debug.zip
43190f078e7b7ccf979637f07d4ca6229b53b5ef568970d81a05b4cbdf4d26e1  bitcoin-241b60b8267b-win64-setup-unsigned.exe
5000b9b126500ff31b8a84f9bde0e780ff80e5554429c6efd9eb66fe9b42af4d  bitcoin-241b60b8267b-win64-unsigned.zip

pinheadmz commented at 12:13 AM on May 12, 2026: member

Detached OSX sigs: https://github.com/pinheadmz/bitcoin-detached-sigs/tree/pr34948

pinheadmz commented at 12:18 AM on May 12, 2026: member

Error attaching sigs, not sure if this is my issue or yours:

$ HOSTS="arm64-apple-darwin x86_64-apple-darwin" ./contrib/guix/guix-codesign
Checking that we can connect to the guix-daemon...

Hint: If this hangs, you may want to try turning your guix-daemon off and on
      again.

INFO: Codesigning 241b60b8267b for platform triple arm64-apple-darwin:
      ...using reference timestamp: 1774694365
      ...from worktree directory: '/home/zip/bitcoin'
          ...bind-mounted in container to: '/bitcoin'
      ...in build directory: '/home/zip/bitcoin/guix-build-241b60b8267b/distsrc-241b60b8267b-arm64-apple-darwin-codesigned'
          ...bind-mounted in container to: '/distsrc-base/distsrc-241b60b8267b-arm64-apple-darwin-codesigned'
      ...outputting in: '/home/zip/bitcoin/guix-build-241b60b8267b/output/arm64-apple-darwin-codesigned'
          ...bind-mounted in container to: '/outdir-base/arm64-apple-darwin-codesigned'
      ...using detached signatures in: '/home/zip/bitcoin-detached-sigs/'
          ...bind-mounted in container to: '/detached-sigs'
Required environment variables as seen inside the container:
    CODESIGNING_TARBALL: /outdir-base/arm64-apple-darwin/bitcoin-241b60b8267b-arm64-apple-darwin-codesigning.tar.gz
    DETACHED_SIGS_REPO: /detached-sigs
    DIST_ARCHIVE_BASE: /outdir-base/dist-archive
    DISTNAME: bitcoin-241b60b8267b
    HOST: arm64-apple-darwin
    SOURCE_DATE_EPOCH: 1774694365
    DISTSRC: /distsrc-base/distsrc-241b60b8267b-arm64-apple-darwin-codesigned
    OUTDIR: /outdir-base/arm64-apple-darwin-codesigned
tar (child): gzip: Cannot exec: No such file or directory
tar (child): Error is not recoverable: exiting now
tar: Child returned status 2
tar: Error is not recoverable: exiting now

pinheadmz commented at 12:37 AM on May 12, 2026: member

I tried adding gzip:

diff --git a/contrib/guix/manifest_codesign.scm b/contrib/guix/manifest_codesign.scm
index 89d9c04b18..b4ecb2575e 100644
--- a/contrib/guix/manifest_codesign.scm
+++ b/contrib/guix/manifest_codesign.scm
@@ -1,5 +1,5 @@
 (use-modules ((gnu packages bash) #:select (bash-minimal))
-             ((gnu packages compression) #:select (zip))
+             ((gnu packages compression) #:select (zip gzip))
              ((gnu packages crypto) #:select (osslsigncode))
              ((gnu packages python-build) #:select (python-poetry-core))
              ((gnu packages python-crypto) #:select (python-asn1crypto python-oscrypto))
@@ -158,6 +158,7 @@ inspecting signatures in Mach-O binaries.")
         ;; Compression and archiving
         tar
         zip
+       gzip
         ;; Git
         git-minimal)
   (let ((target (getenv "HOST")))

the next sig attach failed differently 🤷 This is from signapple I think:


INFO: Codesigning 241b60b8267b for platform triple arm64-apple-darwin:
      ...using reference timestamp: 1774694365
      ...from worktree directory: '/home/zip/bitcoin'
          ...bind-mounted in container to: '/bitcoin'
      ...in build directory: '/home/zip/bitcoin/guix-build-241b60b8267b/distsrc-241b60b8267b-arm64-apple-darwin-codesigned'
          ...bind-mounted in container to: '/distsrc-base/distsrc-241b60b8267b-arm64-apple-darwin-codesigned'
      ...outputting in: '/home/zip/bitcoin/guix-build-241b60b8267b/output/arm64-apple-darwin-codesigned'
          ...bind-mounted in container to: '/outdir-base/arm64-apple-darwin-codesigned'
      ...using detached signatures in: '/home/zip/bitcoin-detached-sigs/'
          ...bind-mounted in container to: '/detached-sigs'
Required environment variables as seen inside the container:
    CODESIGNING_TARBALL: /outdir-base/arm64-apple-darwin/bitcoin-241b60b8267b-arm64-apple-darwin-codesigning.tar.gz
    DETACHED_SIGS_REPO: /detached-sigs
    DIST_ARCHIVE_BASE: /outdir-base/dist-archive
    DISTNAME: bitcoin-241b60b8267b
    HOST: arm64-apple-darwin
    SOURCE_DATE_EPOCH: 1774694365
    DISTSRC: /distsrc-base/distsrc-241b60b8267b-arm64-apple-darwin-codesigned
    OUTDIR: /outdir-base/arm64-apple-darwin-codesigned
Traceback (most recent call last):
  File "/gnu/store/i6qbmw0h2nk1x55w6k2zi6wgj1dvjpmg-python-signapple-0.2.0-1.85bfcec/bin/.signapple-real", line 6, in <module>
    obj = importlib.import_module('signapple')
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/gnu/store/flhgd6kvf4dr7s2pc2zv71swgaicdvia-python-3.11.14/lib/python3.11/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1204, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1147, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/gnu/store/i6qbmw0h2nk1x55w6k2zi6wgj1dvjpmg-python-signapple-0.2.0-1.85bfcec/lib/python3.11/site-packages/signapple/__init__.py", line 5, in <module>
    from .notarize import notarize
  File "/gnu/store/i6qbmw0h2nk1x55w6k2zi6wgj1dvjpmg-python-signapple-0.2.0-1.85bfcec/lib/python3.11/site-packages/signapple/notarize.py", line 14, in <module>
    from oscrypto.asymmetric import load_private_key, ecdsa_sign
  File "/gnu/store/02x76gq25z3gdamp22h9wldwhjif2ppd-python-oscrypto-1.3.0/lib/python3.11/site-packages/oscrypto/asymmetric.py", line 19, in <module>
    from ._asymmetric import _unwrap_private_key_info
  File "/gnu/store/02x76gq25z3gdamp22h9wldwhjif2ppd-python-oscrypto-1.3.0/lib/python3.11/site-packages/oscrypto/_asymmetric.py", line 27, in <module>
    from .kdf import pbkdf1, pbkdf2, pkcs12_kdf
  File "/gnu/store/02x76gq25z3gdamp22h9wldwhjif2ppd-python-oscrypto-1.3.0/lib/python3.11/site-packages/oscrypto/kdf.py", line 9, in <module>
    from .util import rand_bytes
  File "/gnu/store/02x76gq25z3gdamp22h9wldwhjif2ppd-python-oscrypto-1.3.0/lib/python3.11/site-packages/oscrypto/util.py", line 14, in <module>
    from ._openssl.util import rand_bytes
  File "/gnu/store/02x76gq25z3gdamp22h9wldwhjif2ppd-python-oscrypto-1.3.0/lib/python3.11/site-packages/oscrypto/_openssl/util.py", line 6, in <module>
    from ._libcrypto import libcrypto, libcrypto_version_info, handle_openssl_error
  File "/gnu/store/02x76gq25z3gdamp22h9wldwhjif2ppd-python-oscrypto-1.3.0/lib/python3.11/site-packages/oscrypto/_openssl/_libcrypto.py", line 15, in <module>
    from ._libcrypto_ctypes import (
  File "/gnu/store/02x76gq25z3gdamp22h9wldwhjif2ppd-python-oscrypto-1.3.0/lib/python3.11/site-packages/oscrypto/_openssl/_libcrypto_ctypes.py", line 28, in <module>
    raise LibraryNotFoundError('The library libcrypto could not be found')
oscrypto.errors.LibraryNotFoundError: The library libcrypto could not be found

fanquake commented at 9:44 AM on May 12, 2026: member

Error attaching sigs, not sure if this is my issue or yours:

Thanks for testing, looks like more changes are needed in this PR.

fanquake commented at 9:34 AM on May 13, 2026: member

Yes, and I don't think having to build depends twice, is good.

I think this might actually be unavoidable, regardless of changes here, or in #35072.

guix: Hard-code paths to OpenSSL's libraries

Due to Python's `ctypes.util.find_library()` implementation details,
the `python-signapple` package implicitly depends on `clang-toolchain`.

This regression was inadvertently introduced in commit
2276426bb1b9c028d842bf26dcf8004613e9eae9.

Fixing this regression is a prerequisite for the subsequent commit.

04a06cbcf2

guix: Split manifest into build and codesign manifests 1ac3b43c13

hebasto force-pushed on May 13, 2026

hebasto commented at 4:41 PM on May 13, 2026: member

@pinheadmz

Could you please check out the updated branch?

in contrib/guix/patches/signapple-hard-code-openssl.patch:2 in 1ac3b43c13

   0 | @@ -0,0 +1,19 @@
   1 | +The `oscrypto` library searches for the OpenSSL runtime dependency using
   2 | +`ctypes.util.find_library()`, which implicitly requires a toolchain.

fanquake commented at 4:58 PM on May 13, 2026:

In 04a06cbcf2bdb7830678e56c8d790672900ff17d: Not sure I follow the explanation here. If a toolchain is for some reason needed, for python-oscrypto to function properly, then that should be fixed upstream (i.e how does it work for a Python only consumer, with no compiler installed, or, some other guix consumer of the package?).

pinheadmz commented at 9:23 PM on May 13, 2026: member

Just built darwin this time:

7a20f6580d824fe1c57125058f42343308043a106a0ea3a53e8a3564d03bea40  bitcoin-1ac3b43c1319-arm64-apple-darwin-codesigning.tar.gz
529025b62d3d6ea4cea639c37630d62c61c485b53716bf20e3cd906c0266e0e0  bitcoin-1ac3b43c1319-arm64-apple-darwin-unsigned.tar.gz
246bc585ccc4fd8dfa098dd7a8404fe05e54ea04da3420c8533655c7f948ee83  bitcoin-1ac3b43c1319-arm64-apple-darwin-unsigned.zip
26b7c87355fe0311bdbd1bc2743d3ad771ef31b365ea9663397d433d2472945e  bitcoin-1ac3b43c1319.tar.gz
94536befb8392d6ba94b4f6a53f055ec8ce4091463645c3770256b9a8b589e03  bitcoin-1ac3b43c1319-x86_64-apple-darwin-codesigning.tar.gz
e196a919c9d2b5b3ed33a0850587d042f47cc5f4d3631f79dd80f5fd370ff728  bitcoin-1ac3b43c1319-x86_64-apple-darwin-unsigned.tar.gz
b48f3193f374246d9d32f4b6fa676a3a7b08b4818c50316d390c8cc2af0fa935  bitcoin-1ac3b43c1319-x86_64-apple-darwin-unsigned.zip

pinheadmz commented at 9:24 PM on May 13, 2026: member

updated osx sigs: https://github.com/pinheadmz/bitcoin-detached-sigs/tree/pr34948

pinheadmz commented at 9:30 PM on May 13, 2026: member

success!

c4c46062d81b2e99b73e7023cd1408f7c5d5672ef1027d93873bb4d263c5e365  bitcoin-1ac3b43c1319-arm64-apple-darwin.tar.gz
9a4885805e5c3cc4ee7e5198f603d18ffdc49b798d95ff798ec37c335fccb2df  bitcoin-1ac3b43c1319-arm64-apple-darwin.zip
7a20f6580d824fe1c57125058f42343308043a106a0ea3a53e8a3564d03bea40  bitcoin-1ac3b43c1319-arm64-apple-darwin-codesigning.tar.gz
529025b62d3d6ea4cea639c37630d62c61c485b53716bf20e3cd906c0266e0e0  bitcoin-1ac3b43c1319-arm64-apple-darwin-unsigned.tar.gz
246bc585ccc4fd8dfa098dd7a8404fe05e54ea04da3420c8533655c7f948ee83  bitcoin-1ac3b43c1319-arm64-apple-darwin-unsigned.zip
1141f333b2e4238e5bc8c01170475e393abbab0be2d3f6509f8973e7716a5b01  bitcoin-1ac3b43c1319-codesignatures-f5a74e3ff9ba.tar.gz
26b7c87355fe0311bdbd1bc2743d3ad771ef31b365ea9663397d433d2472945e  bitcoin-1ac3b43c1319.tar.gz
83c4db4c02c7ccaf0ca91767f946270114fce12543f8aaa4b749066b2445354a  bitcoin-1ac3b43c1319-x86_64-apple-darwin.tar.gz
690171ad5847d53a8f5e0361f33bb243c2e796b73c5a70532dbf4920e06ba29d  bitcoin-1ac3b43c1319-x86_64-apple-darwin.zip
94536befb8392d6ba94b4f6a53f055ec8ce4091463645c3770256b9a8b589e03  bitcoin-1ac3b43c1319-x86_64-apple-darwin-codesigning.tar.gz
e196a919c9d2b5b3ed33a0850587d042f47cc5f4d3631f79dd80f5fd370ff728  bitcoin-1ac3b43c1319-x86_64-apple-darwin-unsigned.tar.gz
b48f3193f374246d9d32f4b6fa676a3a7b08b4818c50316d390c8cc2af0fa935  bitcoin-1ac3b43c1319-x86_64-apple-darwin-unsigned.zip

hebasto commented at 9:36 PM on May 13, 2026: member

My Guix build:

aarch64
349973a4153c47ce60f94ff5e46335d08f04d5aa3d601c47b34fb6064c0ac5c3  guix-build-1ac3b43c1319/output/aarch64-linux-gnu/SHA256SUMS.part
664d8c887a3af6163748191d8fc6e56c2903d8a30339f022ceaad181a24daf4d  guix-build-1ac3b43c1319/output/aarch64-linux-gnu/bitcoin-1ac3b43c1319-aarch64-linux-gnu-debug.tar.gz
9bbb54fd7ec2c0905db3720e59b32959c9bba0568a5a8178f9a9a6f0c5cb0f24  guix-build-1ac3b43c1319/output/aarch64-linux-gnu/bitcoin-1ac3b43c1319-aarch64-linux-gnu.tar.gz
8e137abd768b9b028c4b26d2d520de62aa1ffcdbdb58f0849d894b751fb9ae59  guix-build-1ac3b43c1319/output/arm-linux-gnueabihf/SHA256SUMS.part
f480e53bdac2e5801ecfc9dcda6bc95638fd23209d74aee3de2af5d1410e59ef  guix-build-1ac3b43c1319/output/arm-linux-gnueabihf/bitcoin-1ac3b43c1319-arm-linux-gnueabihf-debug.tar.gz
f92e63c2a086936180bd975bd98b626decbf7198a6d936f2a23e097c7c5bc501  guix-build-1ac3b43c1319/output/arm-linux-gnueabihf/bitcoin-1ac3b43c1319-arm-linux-gnueabihf.tar.gz
d98fa8f81ec3a4effd3f6af3397d6baf373392a3a12eead9a179f96d9d67fb6e  guix-build-1ac3b43c1319/output/arm64-apple-darwin/SHA256SUMS.part
7a20f6580d824fe1c57125058f42343308043a106a0ea3a53e8a3564d03bea40  guix-build-1ac3b43c1319/output/arm64-apple-darwin/bitcoin-1ac3b43c1319-arm64-apple-darwin-codesigning.tar.gz
529025b62d3d6ea4cea639c37630d62c61c485b53716bf20e3cd906c0266e0e0  guix-build-1ac3b43c1319/output/arm64-apple-darwin/bitcoin-1ac3b43c1319-arm64-apple-darwin-unsigned.tar.gz
246bc585ccc4fd8dfa098dd7a8404fe05e54ea04da3420c8533655c7f948ee83  guix-build-1ac3b43c1319/output/arm64-apple-darwin/bitcoin-1ac3b43c1319-arm64-apple-darwin-unsigned.zip
26b7c87355fe0311bdbd1bc2743d3ad771ef31b365ea9663397d433d2472945e  guix-build-1ac3b43c1319/output/dist-archive/bitcoin-1ac3b43c1319.tar.gz
33cf55aa14bb01d204fd89167c01e310edd7f90c69724d6ff58e7ce2a5d72902  guix-build-1ac3b43c1319/output/powerpc64-linux-gnu/SHA256SUMS.part
3ec787cae5c0d1f393c8ebaa4096c3e0c8cd60998c1a543c5f63b74de93fd349  guix-build-1ac3b43c1319/output/powerpc64-linux-gnu/bitcoin-1ac3b43c1319-powerpc64-linux-gnu-debug.tar.gz
b45f7de85b42ea6bd8130e9732e1ac83676954a7ed4cdec81aab4304a660866a  guix-build-1ac3b43c1319/output/powerpc64-linux-gnu/bitcoin-1ac3b43c1319-powerpc64-linux-gnu.tar.gz
392a31672cdc0f7def8491ccbb2b2774094347da33fb1829126eb7fce190933c  guix-build-1ac3b43c1319/output/riscv64-linux-gnu/SHA256SUMS.part
78fc78dbbb643cff81286e7bc70be18fef4273ad884d08366987f7cffc61bc16  guix-build-1ac3b43c1319/output/riscv64-linux-gnu/bitcoin-1ac3b43c1319-riscv64-linux-gnu-debug.tar.gz
4e5aa10fdc5e26c372f5274fb319dd4426d22124433c37635019700c905c39f4  guix-build-1ac3b43c1319/output/riscv64-linux-gnu/bitcoin-1ac3b43c1319-riscv64-linux-gnu.tar.gz
9a4cfecbe79d7c62ee2d0b54b69f528ef30b2fb3fa4b38abb084c805478c6132  guix-build-1ac3b43c1319/output/x86_64-apple-darwin/SHA256SUMS.part
94536befb8392d6ba94b4f6a53f055ec8ce4091463645c3770256b9a8b589e03  guix-build-1ac3b43c1319/output/x86_64-apple-darwin/bitcoin-1ac3b43c1319-x86_64-apple-darwin-codesigning.tar.gz
e196a919c9d2b5b3ed33a0850587d042f47cc5f4d3631f79dd80f5fd370ff728  guix-build-1ac3b43c1319/output/x86_64-apple-darwin/bitcoin-1ac3b43c1319-x86_64-apple-darwin-unsigned.tar.gz
b48f3193f374246d9d32f4b6fa676a3a7b08b4818c50316d390c8cc2af0fa935  guix-build-1ac3b43c1319/output/x86_64-apple-darwin/bitcoin-1ac3b43c1319-x86_64-apple-darwin-unsigned.zip
9409625a81f12f8d79510bd620366c69442fde7ac4d70167c6cd046ed9bd7487  guix-build-1ac3b43c1319/output/x86_64-linux-gnu/SHA256SUMS.part
198cc86710cf7f71fb07413770d9d189815d91087b11f35d962c2b59d24acc3c  guix-build-1ac3b43c1319/output/x86_64-linux-gnu/bitcoin-1ac3b43c1319-x86_64-linux-gnu-debug.tar.gz
236b68a718ce596a7b083326ce456902c3bcb627d94ed3c58404af8a7a034200  guix-build-1ac3b43c1319/output/x86_64-linux-gnu/bitcoin-1ac3b43c1319-x86_64-linux-gnu.tar.gz
e0453bd9f370aa825d4346239a87a657f1b6a342f6a98b12a241d06526c9f6d8  guix-build-1ac3b43c1319/output/x86_64-w64-mingw32/SHA256SUMS.part
b07cd2078365117f591c69a799b45bd6d6886828ba73fa47e59491f95b43e0d9  guix-build-1ac3b43c1319/output/x86_64-w64-mingw32/bitcoin-1ac3b43c1319-win64-codesigning.tar.gz
db0b94ee39662a5e5f403b720c2fe8f8e102f55cbd725087ed5527d3c0139a67  guix-build-1ac3b43c1319/output/x86_64-w64-mingw32/bitcoin-1ac3b43c1319-win64-debug.zip
bff789631d26c8793af9fde3481abe2622b2e10e3f085b3fb1df5f81becc2603  guix-build-1ac3b43c1319/output/x86_64-w64-mingw32/bitcoin-1ac3b43c1319-win64-setup-unsigned.exe
00b47f1afff58723e952ffed0dc857427f75ad682db683fcf578f5c626fab9f1  guix-build-1ac3b43c1319/output/x86_64-w64-mingw32/bitcoin-1ac3b43c1319-win64-unsigned.zip

I'll response all comments tomorrow.