ci: add --usecli when using --extended #34998

pull polespinasa wants to merge 1 commits into bitcoin:master from polespinasa:2026-04-03-add-usecli-extended changing 2 files +2 −2
  1. polespinasa commented at 8:37 PM on April 3, 2026: member

    The current CI doesn't cover the case of running all tests with --extended if using --usecli. This led to a test failing (feature_index_prune.py) if run with --usecli and the CI not catching it. See #34991 for context.

    This PR improves the CI test coverage by also running now all functional tests (--extended) with the flag --usecli. The CI obviously will fail in this PR until #34991 is merged into master.

    ~I don't know if this is the best approach; I just looked for a ci using --usecli and added the --extended flag to cover these scenarios.~ I'm open to changing the approach.

  2. DrahtBot added the label Tests on Apr 3, 2026
  3. DrahtBot commented at 8:38 PM on April 3, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #34931 (validation: abort on DB unreadable coins instead of treating them as missing by furszy)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. polespinasa commented at 8:38 PM on April 3, 2026: member

    Friendly pinging you here @fanquake

  5. DrahtBot added the label CI failed on Apr 3, 2026
  6. fanquake commented at 8:11 AM on April 4, 2026: member

    I think it would be better to pick one of the jobs already using --extended, and add --usecli.

  7. polespinasa force-pushed on Apr 7, 2026
  8. polespinasa commented at 5:47 PM on April 7, 2026: member

    I think it would be better to pick one of the jobs already using --extended, and add --usecli.

    Done

  9. maflcko commented at 8:21 AM on April 9, 2026: member

    I think the flag can now be removed from the other CI task

  10. ci: add --usecli when using --extended
    Add the flag --usecli to a test (00_setup_env_native_previous_releases.sh) with the --extended flag to cover all tests with --usecli.
    At the same time drop --usecli in 00_setup_env_i686_no_ipc.sh as the cases are now already coverd by the other test.
    d8161ed926
  11. polespinasa force-pushed on Apr 9, 2026
  12. polespinasa renamed this:
    ci: add --extended when using --usecli
    ci: add --usecli when using --extended
    on Apr 9, 2026
  13. polespinasa commented at 11:15 AM on April 9, 2026: member

    I think the flag can now be removed from the other CI task

    Make sense, done :)

  14. polespinasa commented at 6:30 AM on April 24, 2026: member

    Closing because I have cherry picked this commit into the PR that is fixing the test that breakes this new CI behavior #34991

  15. polespinasa closed this on Apr 24, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-28 00:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me