Without the factor, the test may fail when run cross-arch, possibly with sanitizers. E.g. in qemu-aarch64 in docker in a x86-VM.
test: Add missing self.options.timeout_factor scale in tool_bitcoin_chainstate.py #35080
pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2604-test-time-factor changing 1 files +3 −3-
maflcko commented at 7:37 AM on April 15, 2026: member
-
fa02eb87df
test: Add missing self.options.timeout_factor scale in tool_bitcoin_chainstate.py
Apply the timeout factor inside the add_block function. Also, force named args for the two expected strings. Also, add trailing comma for style.
- DrahtBot added the label Tests on Apr 15, 2026
-
DrahtBot commented at 7:37 AM on April 15, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK fanquake If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
fanquake commented at 1:30 PM on April 15, 2026: member
ACK fa02eb87df0b4a615a3e027711326f5506e5507a
- fanquake added the label Needs Backport (31.x) on Apr 15, 2026
- fanquake added the label Needs backport (30.x) on Apr 15, 2026
- fanquake merged this on Apr 15, 2026
- fanquake closed this on Apr 15, 2026
- fanquake referenced this in commit 7a5b017621 on Apr 15, 2026
- fanquake removed the label Needs Backport (31.x) on Apr 15, 2026
- fanquake referenced this in commit 81af29e6fb on Apr 15, 2026
- fanquake referenced this in commit 561d072e05 on Apr 15, 2026
- fanquake removed the label Needs backport (30.x) on Apr 15, 2026
- maflcko deleted the branch on Apr 15, 2026
Labels