wallet: remove outdated arguments from wallet scanning methods #35123

pull rkrux wants to merge 4 commits into bitcoin:master from rkrux:remove-fupdate changing 7 files +21 −24
  1. rkrux commented at 2:42 PM on April 20, 2026: contributor

    This caught my attention while going through #32993.

    The corresponding boolean arguments from CWallet methods related to updating transactions during the blockchain scanning have been removed because effectively these arguments were always passed as true making the need for the boolean arguments unnecessary. The only falsy call sites were in the unit tests that don't need to test scenarios that never happen in actuality.

    <!-- *** Please remove the following help text before submitting: *** Pull requests without a rationale and clear improvement may be closed immediately. GUI-related pull requests should be opened against https://github.com/bitcoin-core/gui first. See CONTRIBUTING.md -->

    <!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible. * Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they *significantly* improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. -->

    <!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. -->

  2. wallet: remove update argument from RescanFromTime method
    Its only usage passes true.
    54e4c0be8f
  3. wallet: remove fUpdate argument from ScanForWalletTransactions
    Only the unit test code passes false, the actual code passes
true always. I don't see a reason why the tests need to exercise
a behaviour that never happens in production.
    6e796e1f47
  4. wallet: remove update_tx argument from SyncTransaction
    Its only usage passes true.
    94845df073
  5. wallet: remove fUpdate argument from AddToWalletIfInvolvingMe
    Its only usage passes true.
    dc84a31014
  6. DrahtBot renamed this:
    wallet: remove outdated arguments from wallet scanning methods
    wallet: remove outdated arguments from wallet scanning methods
    on Apr 20, 2026
  7. DrahtBot added the label Wallet on Apr 20, 2026
  8. DrahtBot commented at 2:42 PM on April 20, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK Bicaru20

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #34861 (wallet: Add importdescriptors interface by polespinasa)
    • #34681 (wallet: refactor ScanForWalletTransactions by Eunovo)
    • #34400 (wallet: parallel fast rescan (approx 5x speed up with 8 threads) by Eunovo)
    • #33392 (wallet, rpc: add UTXO set check and incremental rescan to importdescriptors by musaHaruna)
    • #27865 (wallet: Track no-longer-spendable TXOs separately by achow101)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  9. Bicaru20 commented at 9:49 PM on April 20, 2026: none

    ACK dc84a3101430cdc0353f610835966f4e4942ff03. I also think that makes sense to remove the update argument if it is not used.

Contributors
rkruxDrahtBotBicaru20
Labels
Wallet
Linked (view graph)
#32993 fuzz: wallet: add target for tx scanning
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 09:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me