CalculateMaximumSignedInputSize() accepted an outpoint but passed an empty CTxIn into MaxInputWeight().
Remove the unused COutPoint parameter.
wallet: remove the unused `COutPoint` parameter #35228
pull l0rinc wants to merge 1 commits into bitcoin:master from l0rinc:l0rinc/wallet-remove-outpoint changing 2 files +5 −5-
l0rinc commented at 9:23 PM on May 6, 2026: contributor
-
fd5bb5f94f
wallet: remove the unused `COutPoint` parameter.
`CalculateMaximumSignedInputSize()` accepted an `outpoint` but passed an empty `CTxIn` into `MaxInputWeight()`.
- DrahtBot added the label Wallet on May 6, 2026
- l0rinc renamed this:
wallet: remove the unused `COutPoint` parameter.
wallet: remove the unused `COutPoint` parameter
on May 6, 2026 -
DrahtBot commented at 9:23 PM on May 6, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35228.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK w0xlt, stickies-v, pablomartin4btc If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
w0xlt commented at 7:12 AM on May 7, 2026: contributor
ACK fd5bb5f94f181274c3797f65de679fa7f5b5b81a
- stickies-v approved
-
stickies-v commented at 7:59 AM on May 7, 2026: contributor
ACK fd5bb5f94f181274c3797f65de679fa7f5b5b81a
-
pablomartin4btc commented at 8:29 AM on May 7, 2026: member
ACK fd5bb5f94f181274c3797f65de679fa7f5b5b81a
-
achow101 commented at 8:56 AM on May 7, 2026: member
Actually I'm not sure that this is correct. I thought there was a test for the thing that the parameter would have controlled, but it seems like there maybe isn't. Will need to look at this further in more detail.
- l0rinc marked this as a draft on May 7, 2026
-
l0rinc commented at 9:35 AM on May 7, 2026: contributor
I'm not sure that this is correct.
The original take was to use the dead method instead, see: https://github.com/l0rinc/bitcoin/pull/161/changes#diff-6e06b309cd494ef5da4e78aa0929a980767edd12342137f268b9219167064d13R97
-
pablomartin4btc commented at 9:42 AM on May 7, 2026: member
I can see the param use within the function was removed in commit 9b7ec39 at #26567, perhaps the function signature should have been updated there?
-
Labels