test: add LineReader edge cases relevant to HTTP parsing #35135

pull b-l-u-e wants to merge 1 commits into bitcoin:master from b-l-u-e:test/linereader-http-edge-cases changing 1 files +20 −0

b-l-u-e commented at 9:18 PM on April 21, 2026: contributor
This PR adds two small test cases to line_reader_test in src/test/util_string_tests.cpp to lock in util::LineReader behavior that upcoming HTTP request parsing will depend on.

What the new cases check:
- CRLF and trailing bare \r Consecutive CRLFs produce an empty line (this is how HTTP signals end of headers). A lone \r at the end of the buffer is not treated as a line terminator, so the rest can still be read with ReadLength().
- State after a max_line_length exception After the exception, the iterator is reset and both Consumed() and Remaining() reflect that reset. This means callers can safely fall back to ReadLength() without losing position.
LineReader was added in #34242 (commit 1911db8c) with the max_line_length + iterator-reset semantics exercised here. Consumed() was added later in #34905 (commit 81720992) so callers could observe position after an exception.

These utilities are consumed by the in-progress libevent replacement (#32061). Adding these edge cases reduces risk and ambiguity

test: add LineReader edge cases relevant to HTTP parsing

Add two small test cases to line_reader_test that lock in
current behavior LineReader-based HTTP parsing will depend on:

- Consecutive CRLFs produce an empty line and a trailing bare \r
  is not treated as a line terminator.
- Consumed()/Remaining() stay consistent with the reset iterator
  after a max_line_length exception, so ReadLength() can be used
  to recover.

Signed-off-by: b-l-u-e <8102260+blue@users.noreply.github.com>

72a8cfc31e

DrahtBot added the label Tests on Apr 21, 2026
DrahtBot commented at 9:18 PM on April 21, 2026: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process. A summary of reviews will appear here.

Contributors

b-l-u-e

DrahtBot

Labels

Tests

Linked (view graph)

#32061 Replace libevent with our own HTTP and socket-handling implementation #34242 Prepare string and net utils for future HTTP operations #34905 Update string and net utils for future HTTP operations

test: add LineReader edge cases relevant to HTTP parsing #35135

Reviews