[28.x] Backports #35214

pull fanquake wants to merge 3 commits into bitcoin:28.x from fanquake:backport_35202 changing 7 files +22 −50
  1. fanquake commented at 1:48 PM on May 5, 2026: member

    Backports:

  2. DrahtBot added the label Backport on May 5, 2026
  3. DrahtBot commented at 1:48 PM on May 5, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35214.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK achow101

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. ci: unconfine seccomp for i686 no IPC
    Docker 29.4.2 blocks `socketcall(2)` in the default seccomp profile:
    https://docs.docker.com/engine/release-notes/29/#2942
    https://github.com/moby/profiles/releases/tag/seccomp%2Fv0.2.2
    https://github.com/moby/moby/pull/52501
    
    That affects the `i686, no IPC` job because it runs 32-bit Linux test binaries inside Docker.
    
    Add Docker's documented `--security-opt seccomp=unconfined` workaround to this job's `CI_CONTAINER_CAP` - the hook `ci/test/02_run_container.py` already appends to `docker run`.
    
    This restores socket availability for the 32-bit test binaries throughout the job:
    https://docs.docker.com/engine/security/seccomp/#run-without-the-default-seccomp-profile
    
    Github-Pull: #35202
    Rebased-From: 11c9ef92a8daf030f75f88f324396b2248c65a64
    2d3edd9640
  5. fanquake force-pushed on May 5, 2026
  6. fanquake requested review from willcl-ark on May 5, 2026
  7. achow101 commented at 7:40 AM on May 6, 2026: member

    #35175 please so I can compile this

  8. multi_index: fix compilation failure with boost >= 1.91
    This effectively reverts a3cb309e7c31853f272bffaa65fb6ab0a7cc4083 from PR #30194.
    
    That PR reduced the multi_index type signatures as recommended upstream, but
    this is no longer supported as of boost 1.91 because it is no longer necessary.
    1.91 drops support for the pre-c++11 work-arounds that bloated the type
    signatures to begin with.
    
    The upstream `BOOST_MULTI_INDEX_ENABLE_MPL_SUPPORT` define is meant to provide
    compatibility with removed features, but it does not work for this case. Using
    `indexed_by` directly when defining the `multi_index` (as opposed to inheriting
    from it) works with all versions, and avoids the use of the back-compat define.
    
    This is a slight regression when building against boost < 1.91 because the
    bloated type signatures are reintroduced in that case, but it's not significant
    enough to go to the trouble of introducing version detection and ifdefs.
    
    Github-Pull: #35175
    Rebased-From: 0bc9d354dfd8074d1c36a891a69b6585a8775c65
    2c5242d24f
  9. doc: update release notes for v28.x c1c2184f45
  10. fanquake force-pushed on May 6, 2026
  11. achow101 commented at 7:50 AM on May 6, 2026: member

    ACK c1c2184f45c172392a54b7474e60616d13f6256a

  12. achow101 merged this on May 6, 2026
  13. achow101 closed this on May 6, 2026

  14. fanquake deleted the branch on May 6, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-11 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me