This PR follows up on #35222.
According to the CMake documentation for CTEST_NIGHTLY_START_TIME:
... this variable must always be set for a nightly build in a dashboard script.
Examples of nightly build reports utilizing this configuration can be found on the Bitcoin Core CDash board, based on this commit.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35241.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | ferminquant, purpleKarrot |
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
Seems fine, but I wonder if Nightly is the right choice here. It seems we want "Continuous", because that will actually give the exact revision, instead of some obscure meaning of "some time in the day", which will break when the builds are done more often per day, of less than once per day.
See also https://my.cdash.org/index.php?project=bitcoin-core&date=2026-05-07 for reference of some continuous nighly builds with revision.
Seems fine, but I wonder if Nightly is the right choice here. It seems we want "Continuous", because that will actually give the exact revision, instead of some obscure meaning of "some time in the day", which will break when the builds are done more often per day, of less than once per day.
See also https://my.cdash.org/index.php?project=bitcoin-core&date=2026-05-07 for reference of some continuous nighly builds with revision.
The ctest_update command is responsible for reporting the revision, and it is up to the submitters to put it into their CTest scripts.
ACK 4defc466a2232f2e60587d4127eefc356d957ac1
Reviewed the linked #35222 context and CTest/CDash behavior. CTEST_NIGHTLY_START_TIME is required for Nightly dashboard runs, and setting it in CTestConfig.cmake lets ctest_start(Nightly) work while still allowing submitter scripts to choose Continuous or Experimental. Also checked that ctest_start(Nightly) fails without this setting and passes with this PR.
ACK 4defc466a2232f2e60587d4127eefc356d957ac1