The minimum required Xcode command-line tools version was not documented, which can lead to confusion.
So document it in doc/dependencies.md (along with adding a note one msvc there as well). This also allows to slim down the error message in the configure C++ feature check by referring to doc/dependencies.md#compiler.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35270.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | polespinasa |
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
Not sure. Xcode is not required at all, so it seems confusing to document it as a requirement. How about documenting the minimum required command line tools version instead? (or the relevant Apple Clang version).
11 | @@ -12,6 +12,9 @@ Bitcoin Core requires one of the following compilers. 12 | | --- | --- | 13 | | [Clang](https://clang.llvm.org) | [17.0](https://github.com/bitcoin/bitcoin/pull/33555) | 14 | | [GCC](https://gcc.gnu.org) | [12.1](https://github.com/bitcoin/bitcoin/pull/33842) | 15 | +| [Xcode](https://developer.apple.com/xcode/) | [16.2](https://github.com/bitcoin/bitcoin/pull/33932) |
| [Xcode CLT](https://developer.apple.com/documentation/xcode/installing-the-command-line-tools) | [16.2](https://github.com/bitcoin/bitcoin/pull/33932) |
Sure, happy to clarify CLT. Does this diff lgty?
Sure, just want to avoid confusing anyone into thinking they need to download the (many GB) Xcode blob, when the Command Line Tools are sufficient.
I don't have xcode so did not check 16.2 is the min version for Xcode, but changes look fine to me and seems useful.
ACK fad1d0fd31a540ea04bc74aadf35d3090877d925
Thanks for addressing the nits from the other PR :)
I don't have xcode so did not check 16.2 is the min version for Xcode
IIRC someone tested CLT 15 in #35134 (comment). Happy to test other versions, if someone wants me to.