ci: Enable ruff ambiguous-unicode-character checks #35277

1. 
   maflcko commented at 7:52 AM on May 13, 2026: member

   Ambiguous unicode chars are unused and confusing. Worst, they can lead to bugs.

   So enable the ruff checks to catch them. Can be tested via:

   echo 'ZGlmZiAtLWdpdCBhL3Rlc3QvZnVuY3Rpb25hbC93YWxsZXRfZGlzYWJsZS5weSBiL3Rlc3QvZnVu
   Y3Rpb25hbC93YWxsZXRfZGlzYWJsZS5weQppbmRleCBkYmNjY2Q0Li4wYjhjNDQ2IDEwMDc1NQot
   LS0gYS90ZXN0L2Z1bmN0aW9uYWwvd2FsbGV0X2Rpc2FibGUucHkKKysrIGIvdGVzdC9mdW5jdGlv
   bmFsL3dhbGxldF9kaXNhYmxlLnB5CkBAIC0yMSwzICsyMSw4IEBAIGNsYXNzIERpc2FibGVXYWxs
   ZXRUZXN0IChCaXRjb2luVGVzdEZyYW1ld29yayk6CiAgICAgZGVmIHJ1bl90ZXN0IChzZWxmKToK
   KyAgICAgICAgIiIiQSBsb3ZlbHkgZG9jc3RyaW5nICh3aXRoIGEgYFUrRkYwOWAgcGFyZW50aGVz
   aXPvvIkuIiIiCiAgICAgICAgICMgTWFrZSBzdXJlIHdhbGxldCBpcyByZWFsbHkgZGlzYWJsZWQK
   KyAgICAgICAgIyBu0L5xYSAgIzwtIGlzIEN5cmlsbGljIChgVSswNDNFYCkKKyAgICAgICAgcHJp
   bnQoIs6XZWxsbywgd29ybGQhIikgICMgPC0gaXMgdGhlIEdyZWVrIGV0YSAoYFUrMDM5N2ApLgor
   ICAgICAgICBleGFtcGxlID0gInjigI8iICogMTAwICAjICAgICLigI94IiBpcyBhc3NpZ25lZAor
   ICAgICAgICBleGFtcGxlPU5vbmUjbm9xYQogICAgICAgICBhc3NlcnRfcmFpc2VzX3JwY19lcnJv
   cigtMzI2MDEsICdNZXRob2Qgbm90IGZvdW5kJywgc2VsZi5ub2Rlc1swXS5nZXR3YWxsZXRpbmZv
   KQo=' | base64 --decode | git apply
   
   git diff
   
   ruff check ./test/functional/*.py
   

   It should print 4 error types.

2. DrahtBot renamed this:
   ci: Enable ruff ambiguous-unicode-character checks
   ci: Enable ruff ambiguous-unicode-character checks
   on May 13, 2026
3. DrahtBot added the label Tests on May 13, 2026
4. 
   DrahtBot commented at 7:52 AM on May 13, 2026: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35277.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	stickies-v, willcl-ark
   Concept ACK	fanquake

   If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

   <!--5faf32d7da4f0f540f40219e4f7537a3-->

5. ci: Enable ruff ambiguous-unicode-character checks fa9b01adec
6. maflcko force-pushed on May 13, 2026
7. DrahtBot added the label CI failed on May 13, 2026
8. 
   fanquake commented at 9:28 AM on May 13, 2026: member

   Concept ACK

9. fanquake requested review from willcl-ark on May 13, 2026
10. DrahtBot removed the label CI failed on May 13, 2026
11. willcl-ark approved
12. 
    willcl-ark commented at 10:11 AM on May 13, 2026: member

    ACK fa9b01adecce7d2e2f0091a363bcf98cf5d5c378

    Makes sense to disallow these.

13. DrahtBot requested review from fanquake on May 13, 2026
14. refactor: Use ignore-list over verbose select-list

    This refactor makes the ruff.toml easier to read, because it lists the
    ignored checks instead of having to enumerate all checks to select in a
    large collection of rules.

    fa9c919678
15. 
    maflcko commented at 10:25 AM on May 13, 2026: member

    Sorry, pushed a small refactor, which I think makes sense, but isn't worth to create a separate pull for. Let me know if I should drop it, though.

16. stickies-v approved
17. 
    stickies-v commented at 10:40 AM on May 13, 2026: contributor

    ACK fa9c919678c0d4926ff735eecf12562d99a7e691

18. DrahtBot requested review from willcl-ark on May 13, 2026
19. willcl-ark approved
20. 
    willcl-ark commented at 10:41 AM on May 13, 2026: member

    ACK fa9c919678c0d4926ff735eecf12562d99a7e691

    Only a ruleset tidy up added since last ACK.

21. fanquake merged this on May 13, 2026
22. fanquake closed this on May 13, 2026

    ---

23. rustaceanrob referenced this in commit 2459d614a6 on May 13, 2026
24. maflcko deleted the branch on May 13, 2026

Contributors

maflckoDrahtBotfanquakewillcl-arkstickies-v

Review Requested
fanquake