If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
#31507 (build: Use clang-cl to build on Windows natively by hebasto)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
hebasto
commented at 11:21 AM on May 18, 2026:
member
Yea. It looks like we'll need to do something there.
andrewtoth
commented at 10:08 PM on May 27, 2026:
contributor
I think we should backport github.com/bitcoin-core/leveldb-subtree/pull/61 to 29 (if we still support it), 30, and 31. Is there an easy way to do that without including the other patches here?
fanquake
commented at 10:18 PM on May 27, 2026:
member
I think we should backport
Thanks. I'll pull all the new subtree changes into here, and then split out changes for backport, to the maintained branches, along with the other backports.
Squashed 'src/leveldb/' changes from ab6c84e6f3..a7f9bdc611
a7f9bdc611 Merge bitcoin-core/leveldb-subtree#52: Revert "Increase maximum read-only mmap()s used from 1000 to 4096 on 64-bit systems"
a2f531d2d0 Merge bitcoin-core/leveldb-subtree#60: util: use [[fallthrough]] directly
1a166221cf Merge bitcoin-core/leveldb-subtree#61: Disable seek compaction
6bfdb6093b Disable seek compaction
42a5f29aa9 util: use [[fallthrough]] directly
c274b50867 Merge bitcoin-core/leveldb-subtree#53: refactor: Delete unused `ScopedHandle:operator=(ScopedHandle&&)`
68740f586f Merge bitcoin-core/leveldb-subtree#59: Fix Clang `-Wconditional-uninitialized` warning
70142e186b Merge bitcoin-core/leveldb-subtree#55: build: Require C++17
d123cf5a83 Effectively, this change
31361bf339 Allow different C/C++ standards when this is used as a subproject.
0711e6d082 Fix Clang `-Wconditional-uninitialized` warning
85665f9547 refactor: Delete unused `ScopedHandle:operator=(ScopedHandle&&)`
fd8f69657e Revert "Increase maximum read-only mmap()s used from 1000 to 4096 on 64-bit systems"
git-subtree-dir: src/leveldb
git-subtree-split: a7f9bdc6114fe6eeb848fda2980fe61d86ff2045
58cdb5c2e8
Update leveldb subtree to latest upstream5fe0615f7a
build: remove -Wno-conditional-uninitialized from leveldb build4d58c3271c
build: remove FALLTHROUGH_INTENDED from leveldb.cmake
No-longer needed after
https://github.com/bitcoin-core/leveldb-subtree/pull/60.
a9ac680af3
fanquake force-pushed on May 28, 2026
hebasto approved
hebasto
commented at 10:22 AM on May 28, 2026:
member
ACKa9ac680af30dd77689517f58ce7b811527ac5e13.
fanquake
commented at 11:02 AM on May 28, 2026:
member
sedited
commented at 12:41 PM on May 28, 2026:
contributor
ACKa9ac680af30dd77689517f58ce7b811527ac5e13
andrewtoth approved
andrewtoth
commented at 12:41 PM on May 28, 2026:
contributor
ACKa9ac680af30dd77689517f58ce7b811527ac5e13
$ git fetch origin refs/pull/35313/head:pr/35313
$ git fetch https://github.com/bitcoin-core/leveldb-subtree.git
$ test/lint/git-subtree-check.sh -r src/leveldb pr/35313
src/leveldb in pr/35313 currently refers to tree 11a61e9112d334f8889dbe5ee24ba595f56e7b7d
src/leveldb in pr/35313 was last updated in commit 58cdb5c2e835f219429351fe447ae6eeae3a96d8 (tree 11a61e9112d334f8889dbe5ee24ba595f56e7b7d)
src/leveldb in pr/35313 was last updated to upstream commit a7f9bdc6114fe6eeb848fda2980fe61d86ff2045 (tree 11a61e9112d334f8889dbe5ee24ba595f56e7b7d)
GOOD
fanquake merged this on May 28, 2026
fanquake closed this on May 28, 2026
fanquake deleted the branch on May 28, 2026
fanquake
commented at 2:02 PM on May 28, 2026:
member
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2026-05-31 18:51 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me