Cirrus is winding down, and github now offers more than 10GB cache.
Switch to GH cache for all runner-types. Simplify configure-docker action.
Cirrus is winding down, and github now offers more than 10GB cache.
Switch to GH cache for all runner-types. Simplify configure-docker action.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35348.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | maflcko |
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
21 | @@ -37,24 +22,12 @@ runs: 22 | shell: bash 23 | run: | 24 | # Configure docker build cache backend 25 | - # 26 | - # On forks the gha cache will work but will use Github's cache backend. 27 | - # Docker will check for variables $ACTIONS_CACHE_URL, $ACTIONS_RESULTS_URL and $ACTIONS_RUNTIME_TOKEN 28 | - # which are set automatically when running on GitHub infra: https://docs.docker.com/build/cache/backends/gha/#synopsis
nit: I think those two lines are still relevant and can be moved to the prior section "Expose actions cache variables"?
Agreed, fixed in c03107acf50aeada1bacdfdbf632ffce2957bff0
lgtm, just one nit/question (feel free to ignore).
This should hopefully fix the 500-err that are happening. E.g. https://github.com/bitcoin/bitcoin/actions/runs/26265910816/job/77308984926#step:6:45:
Redefining the ACTIONS_CACHE_URL and ACTIONS_RESULTS_URL to http://127.0.0.1:12321/ to make the cache faster...
Attempt 1 of 5 failed with error: Failed request: (500) Internal Server Error: GHA cache v2 failed to retrieve information about cache entry with key "ccache-ci_native_alpine_musl-26265910816" and version "5683fc144be6e87619d6825976b04d5025c6427ff80ba1400e061fc86e269d75": rpc error: code = Unknown desc = . Retrying request in 3000 ms...
Attempt 2 of 5 failed with error: Failed request: (500) Internal Server Error: GHA cache v2 failed to retrieve information about cache entry with key "ccache-ci_native_alpine_musl-26265910816" and version "5683fc144be6e87619d6825976b04d5025c6427ff80ba1400e061fc86e269d75": rpc error: code = Unknown desc = . Retrying request in 5029 ms...
Attempt 3 of 5 failed with error: Failed request: (500) Internal Server Error: GHA cache v2 failed to retrieve information about cache entry with key "ccache-ci_native_alpine_musl-26265910816" and version "5683fc144be6e87619d6825976b04d5025c6427ff80ba1400e061fc86e269d75": rpc error: code = Unknown desc = . Retrying request in 7560 ms...
Attempt 4 of 5 failed with error: Failed request: (500) Internal Server Error: GHA cache v2 failed to retrieve information about cache entry with key "ccache-ci_native_alpine_musl-26265910816" and version "5683fc144be6e87619d6825976b04d5025c6427ff80ba1400e061fc86e269d75": rpc error: code = Unknown desc = . Retrying request in 11554 ms...
Warning: Failed to restore: Failed to GetCacheEntryDownloadURL: Failed to make request after 5 attempts: Failed request: (500) Internal Server Error: GHA cache v2 failed to retrieve information about cache entry with key "ccache-ci_native_alpine_musl-26265910816" and version "5683fc144be6e87619d6825976b04d5025c6427ff80ba1400e061fc86e269d75": rpc error: code = Unknown desc =
Cache not found for input keys: ccache-ci_native_alpine_musl-26265910816, ccache-ci_native_alpine_musl-
Also, I guess this doesn't need a backport, because for those it shouldn't matter if the cache fails due to a 503, or a "normal" cache miss, which is expected. Though, a backport to all active branches should be harmless, if done for consistency.
review ACK a56dee26fa9cad983ac3b5b6841c341788942fd7 🔄
<details><summary>Show signature</summary>
Signature:
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: review ACK a56dee26fa9cad983ac3b5b6841c341788942fd7 🔄
lLIrQR+t89SIQkiqNoPRXlribJ0op0ppmqSklgRV30LdgZzii4Pnx9hs7+jxjdc4xJdfLOFExf0DGcQW+zP8Cg==
</details>
.
Cirrus is winding down and github now offers more than 10GB cache.
Switch to GH cache for all runner-types. Simplify docker build arg
construction, and reduce the number of needed action permissions.
review ACK c03107acf50aeada1bacdfdbf632ffce2957bff0 🚴
<details><summary>Show signature</summary>
Signature:
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: review ACK c03107acf50aeada1bacdfdbf632ffce2957bff0 🚴
JP2WEhbHeQ6cxtGAvVVEVrWmVUHRn2/JtGXZTIiCRL4Hp+ri7Ylw8AjFeWW8KPq6nGu54j8i4lTAMiaNM6dKCQ==
</details>
I'm going to put this in now, as the caches are pretty much cooked.