cmake: skip missing example targets in libmultiprocess.cmake #35454

pull ryanofsky wants to merge 1 commits into bitcoin:master from ryanofsky:pr/supportrm changing 1 files +5 −1
  1. ryanofsky commented at 11:39 PM on June 3, 2026: contributor

    bitcoin-core/libmultiprocess#287 is removing the mpcalculator, mpprinter, and mpexample targets, which causes a configuration error when Bitcoin Core is compiled against the updated upstream libmultiprocess:

    CMake Error at cmake/libmultiprocess.cmake:37 ... Can not find target to add properties to: mpcalculator
    

    Fix this by iterating over the targets and only calling set_target_properties if the target exists. This is not needed for subtree builds (where upstream changes do not apply directly), but is useful for custom builds with an external libmultiprocess, and is needed to keep Bitcoin Core CI jobs working in the libmultiprocess repository.

  2. cmake: skip missing example targets in libmultiprocess.cmake
    bitcoin-core/libmultiprocess#287 is removing the mpcalculator,
    mpprinter, and mpexample targets, which causes a configuration error
    when Bitcoin Core is compiled against the updated upstream libmultiprocess:
    
      CMake Error at cmake/libmultiprocess.cmake:37 ...
      Can not find target to add properties to: mpcalculator
    
    Fix this by iterating over the targets and only calling
    set_target_properties if the target exists. This is not needed for
    subtree builds (where upstream changes do not apply directly), but is
    useful for custom builds with an external libmultiprocess, and is needed
    to keep Bitcoin Core CI jobs working in the libmultiprocess repository.
    
    Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
    b29f764890
  3. DrahtBot added the label Build system on Jun 3, 2026
  4. DrahtBot commented at 11:39 PM on June 3, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35454.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #35418 (build: exclude mptest target from compile commands by Sanjana2906)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-06-04 07:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me