Some kernel paths read the current time (e.g. header validation's future-time check, and the btck_SynchronizationState carried by btck_NotifyBlockTip / btck_NotifyHeaderTip callbacks), which makes them awkward to exercise deterministically in tests. This PR exposes btck_set_mock_time as a wrapper over the existing SetMockTime, mirroring what the node has via the setmocktime RPC.
Prior IRC discussion: https://gnusha.org/bitcoin-kernel/2026-06-04.log
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35496.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| Concept ACK | sedited |
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--174a7506f384e20aa4161008e828411d-->
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
<!--85328a0da195eb286784d51f73fa0af9-->
🚧 At least one of the CI tasks failed.
<sub>Task No wallet: https://github.com/bitcoin/bitcoin/actions/runs/27215802797/job/80356864067</sub>
<sub>LLM reason (✨ experimental): CI failed due to a build linker error: test_kernel couldn’t link because NodeClock::now() had undefined references.</sub>
<details><summary>Hints</summary>
Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:
Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.
A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.
An intermittent issue.
Leave a comment here, if you need help tracking down a confusing failure.
</details>
Interesting, Concept ACK.
Force-pushed: the test now verifies the effect through the kernel API instead of reading Now<NodeSeconds>() directly. Depending on the build configuration, g_mock_time can end up duplicated between libbitcoinkernel and the test binary, so the test's read and the kernel's write hit different globals and the assertion fails even if the link issue is resolved by linking bitcoin_util into test_kernel.
Some kernel paths read the current time (e.g. header validation's future-time check, and the `btck_SynchronizationState` carried by `btck_NotifyBlockTip` / `btck_NotifyHeaderTip` callbacks), which makes them awkward to exercise deterministically in tests. This commit exposes `btck_set_mock_time` as a wrapper over the existing `SetMockTime`, mirroring what the node has via the `setmocktime` RPC.