This is a follow-up to #35269
different_key to different_field in assert_musig_signer_data (discussion)assert_equal for pubnonce/partial-sig length checks, matching the pattern already used for finalized["complete"] (discussion)MuSig2SessionID doc to say "signing pubkey" instead of "aggregate xonly key" (discussion)
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35504.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| Stale ACK | rkrux |
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
58 | @@ -59,7 +59,7 @@ class MuSig2SecNonce 59 | 60 | /** 61 | * Computes an arbitrary unique session ID to identify ongoing signing sessions. 62 | - * It is the SHA256 of the aggregate xonly key, the participant pubkey, the sighash, and the pubnonce 63 | + * It is the SHA256 of the signing pubkey, the participant pubkey, the sighash, and the pubnonce
- It is the SHA256 of the signing pubkey, the participant pubkey, the sighash, and the pubnonce
+ It is the SHA256 of the signing (aggregate) pubkey, the participant pubkey, the sighash, and the pubnonce
Can retain and put the aggregate term in braces because even in case of keypath, the tap-tweaked version works over the aggregate. Also, to differentiate it more clearly from the participant pubkeys.
Thanks for the review!
That makes sense, I pushed a fix in b337102
crACK be5bd5b269b9660d229b6ba660864e04ef88615a
Shared a suggestion.