test: fix `--perf` profiling #35509

pull theStack wants to merge 1 commits into bitcoin:master from theStack:202606-test-fix_perf_profiling changing 1 files +2 −2
  1. theStack commented at 2:28 AM on June 11, 2026: contributor

    Functional test profiling with --perf (introduced in #14519) is currently broken, as TestNode._start_perf accesses the self.binary attribute which doesn't exist anymore since commit 0d2eefca8bf3cb64e3f2f912ed32118524430967 / PR #31866. Fix that by using the proper field self.binaries.paths.bitcoind.

    Also, perf's error output for missing kernel permissions changed slightly in 2020 (s/tweaking/adjusting) (see https://github.com/torvalds/linux/commit/c1034eb069201f3f3c40f34f3d937ecb8049d0cf), so adapt our matching string as well in order to show the "couldn't collect data" warning if necessary. Relying on a certain output string is obviously brittle, so we might want to do something smarter there.

    This is a minimum-diff-fix that works on my machine (arm64, Ubuntu 25.04, Kernel 6.17.0-8-qcom-x1e, perf 6.1.174). I think the feature is useful in principle, but considering that no one noticed for more than a year that it's broken, it seems that no one really uses it, and an alternative might also be to remove it. Curious to hear opinions.

  2. test: fix `--perf` profiling
    Functional test profiling with `--perf` (introduced in #14519) is
    currently broken, as `TestNode._start_perf` accesses the `self.binary`
    attribute which doesn't exist anymore since commit
    0d2eefca8bf3cb64e3f2f912ed32118524430967 / PR #31866. Fix that by using
    the proper field `self.binaries.paths.bitcoind`.
    
    Also, perf's error output for missing kernel permissions changed
    slightly (s/tweaking/adjusting) [1], so adapt our matching string as well in
    order to show the "couldn't collect data" warning if necessary.
    
    [1] see https://github.com/torvalds/linux/commit/c1034eb069201f3f3c40f34f3d937ecb8049d0cf
    78fe5a4ace
  3. DrahtBot added the label Tests on Jun 11, 2026
  4. DrahtBot commented at 2:28 AM on June 11, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35509.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    Concept ACK w0xlt

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. w0xlt commented at 3:55 AM on June 11, 2026: contributor

    Concept ACK


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-06-11 08:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me