test: doc: remove `--perf` profiling from functional test framework #35528

pull theStack wants to merge 1 commits into bitcoin:master from theStack:202606-test-remove_perf_profiling changing 6 files +3 −163
  1. theStack commented at 9:40 PM on June 13, 2026: contributor

    This PR is an alternative to #35509. Rather than fixing, it removes the --perf option / profile_with_perf context manager features (both introduced in #14519) from the functional test framework. Given that no developer apparently even noticed that it's been broken for more than a year, we can conclude that it's largely unused and getting rid of it to reduce maintenance burden seems a reasonable choice. So far, neither in #35509 nor on IRC anyone has signaled strong interest to use or wanting to keep this feature.

    The corresponding test documentation is removed as well, though the mentioning of perf profiling is still kept in the general developer docs -- only the reference to functional test framework integration is removed there.

  2. test: doc: remove `--perf` profiling from functional test framework
    This feature was broken for more than a year and no developer apparently
    even noticed, so one can conclude that it is largely unused; it seems
    thus reasonable to remove it to reduce maintenance burden.
    9fae7e9886
  3. DrahtBot added the label Tests on Jun 13, 2026
  4. DrahtBot commented at 9:40 PM on June 13, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35528.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK l0rinc, maflcko

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #35509 (test: fix --perf profiling by theStack)
    • #35395 (doc: Improve test suite dependencies documentation by hebasto)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. l0rinc commented at 7:10 PM on June 14, 2026: contributor

    I saw this a while ago, but since it's not a cross-platform tool, I developed my own toolset since.

    lightweight code review ACK 9fae7e98865c9f42c197b496b7d4896f0a92dff8

  6. maflcko commented at 10:16 AM on June 15, 2026: member

    lgtm ACK 9fae7e98865c9f42c197b496b7d4896f0a92dff8 While this seems useful, no one using it is a good reason to remove it. If a user comes after this is merged, it should be trivial to revert.

  7. fanquake merged this on Jun 15, 2026
  8. fanquake closed this on Jun 15, 2026

  9. theStack deleted the branch on Jun 15, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-06-20 23:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me