build: QRencode cleanups #35603

hebasto commented at 2:34 PM on June 25, 2026: member

This PR addresses:

this comment:

If it works without pkg-config, then we should remove the usage of pkgconfig entirely, rather than say it will work without it, and leave the dependency in the code?
and this one:

While cleaning up this module, you may also get rid of SelectLibraryConfigurations. We don't want that QRencode_LIBRARY or QRencode_LIBRARIES is used anywhere; there is no need to set a variable with that name.

cmake: Drop optional `PkgConfig` use in `FindQRencode` module 402ba10b20

depends: Remove unused `lib/pkgconfig` in `qrencode` package 5c55606da9

hebasto added the label Build system on Jun 25, 2026

DrahtBot commented at 2:34 PM on June 25, 2026: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35603.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	purpleKarrot

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.

hebasto commented at 2:37 PM on June 25, 2026: member

@purpleKarrot also suggested:

While cleaning up this module, you may also get rid of SelectLibraryConfigurations. We don't want that QRencode_LIBRARY or QRencode_LIBRARIES is used anywhere; there is no need to set a variable with that name.

I'm not sure about that, as currently QRencode_LIBRARY is used as a main argument in the find_package_handle_standard_args invocation.

However, I'm still open for further discussion.

in cmake/module/FindQRencode.cmake:58 in 5c55606da9

purpleKarrot commented at 2:45 PM on June 25, 2026:

if(QRencode_FOUND AND NOT TARGET QRencode::QRencode)
  add_library(QRencode::QRencode UNKNOWN IMPORTED)
  set_target_properties(QRencode::QRencode PROPERTIES
    IMPORTED_CONFIGURATIONS RELEASE
    IMPORTED_LOCATION_RELEASE "${QRencode_LIBRARY_RELEASE}"
    INTERFACE_INCLUDE_DIRECTORIES "${QRencode_INCLUDE_DIR}"
    )
  if(QRencode_LIBRARY_DEBUG)
    set_property(TARGET QRencode::QRencode APPEND PROPERTY
      IMPORTED_CONFIGURATIONS DEBUG
      )
    set_target_properties(QRencode::QRencode PROPERTIES
      IMPORTED_LOCATION_DEBUG "${QRencode_LIBRARY_DEBUG}"
      )
  endif()
endif()

purpleKarrot commented at 2:46 PM on June 25, 2026: contributor

QRencode_LIBRARY_RELEASE should be required (checked in FPHSA) and QRencode_LIBRARY_DEBUG should be optional.

cmake: Remove `SelectLibraryConfigurations` from `FindQRencode` module

Co-authored-by: Daniel Pfeifer <daniel@pfeifer-mail.de>

829255c8be

DrahtBot added the label CI failed on Jun 25, 2026

hebasto commented at 3:35 PM on June 25, 2026: member

QRencode_LIBRARY_RELEASE should be required (checked in FPHSA) and QRencode_LIBRARY_DEBUG should be optional.

Thanks! Taken.

DrahtBot removed the label CI failed on Jun 25, 2026

purpleKarrot commented at 8:16 AM on June 26, 2026: contributor

ACK 829255c8bedc033ddb518fae43050c4ca10caf6a

hebasto commented at 10:09 AM on June 26, 2026: member

My Guix build:

aarch64
39ed6fa2d8b901b7cca10eb297f422c0d9697191188e6ba97b8201c816d53798  guix-build-829255c8bedc/output/aarch64-linux-gnu/SHA256SUMS.part
61b9fdcce254bfd9f53b914ab525ba5309ec04344ed8c4546270f643c7fcd94e  guix-build-829255c8bedc/output/aarch64-linux-gnu/bitcoin-829255c8bedc-aarch64-linux-gnu-debug.tar.gz
f41b4ca07cfb18130c407d3bfc616f1229a16e74adb53f1db133907b5fda967c  guix-build-829255c8bedc/output/aarch64-linux-gnu/bitcoin-829255c8bedc-aarch64-linux-gnu.tar.gz
6f9d026d341471e0454d8289830b00515a07b4a723252707c270063d3ff34423  guix-build-829255c8bedc/output/arm-linux-gnueabihf/SHA256SUMS.part
ee2755a24a507534e965d1042ff4757dead76eac22bfe0755f611f357ad318af  guix-build-829255c8bedc/output/arm-linux-gnueabihf/bitcoin-829255c8bedc-arm-linux-gnueabihf-debug.tar.gz
e17db3f0e30aa4384f2399310637095b01c44db03a112bce1b873e8d0718457b  guix-build-829255c8bedc/output/arm-linux-gnueabihf/bitcoin-829255c8bedc-arm-linux-gnueabihf.tar.gz
ecb89ab07b51af033df4576d7a6030e139843673192f62cb464c9f633f699cfc  guix-build-829255c8bedc/output/arm64-apple-darwin/SHA256SUMS.part
8f63120989e6495c04f632e5b8173f5301fe5f30dac63c7dde1cc1cf5f40beb0  guix-build-829255c8bedc/output/arm64-apple-darwin/bitcoin-829255c8bedc-arm64-apple-darwin-codesigning.tar.gz
8a4edfef0052142acea349f487863e25688be65b52fb03488b4b835a7dcfba30  guix-build-829255c8bedc/output/arm64-apple-darwin/bitcoin-829255c8bedc-arm64-apple-darwin-unsigned.tar.gz
162451cd3a8875e37d9cbc0933271b77f61da28712d365c4568183fe6c4a4b99  guix-build-829255c8bedc/output/arm64-apple-darwin/bitcoin-829255c8bedc-arm64-apple-darwin-unsigned.zip
6ead25df09b663bd8211054b33d300485a1ae9742564ff261ff30d1099403942  guix-build-829255c8bedc/output/dist-archive/bitcoin-829255c8bedc.tar.gz
13d2c82ea40abebe5487f576eaaa5570bf547fa5881eb0848208e8e118587818  guix-build-829255c8bedc/output/powerpc64-linux-gnu/SHA256SUMS.part
36ec0bb067672eec90c48a76925fc7ae2aa961f76a0be2001899ddfb0ddec6e1  guix-build-829255c8bedc/output/powerpc64-linux-gnu/bitcoin-829255c8bedc-powerpc64-linux-gnu-debug.tar.gz
34004370719f4a9917ab0806fd6bfdc9b75ba0361d98ac49e41ecdc418715292  guix-build-829255c8bedc/output/powerpc64-linux-gnu/bitcoin-829255c8bedc-powerpc64-linux-gnu.tar.gz
5e8c722ff3c9b74aaf4f68fbf6a80cbc5dd3f3e088e94b78b4326d2928d40dfd  guix-build-829255c8bedc/output/riscv64-linux-gnu/SHA256SUMS.part
3b9b57a931fa7c0a09420ef1c4d14518ee96529d80395f8772979dba139069b4  guix-build-829255c8bedc/output/riscv64-linux-gnu/bitcoin-829255c8bedc-riscv64-linux-gnu-debug.tar.gz
da0ed79e7d9554531c98920013ab74b6df06b92a8084a09ed011ade395529eae  guix-build-829255c8bedc/output/riscv64-linux-gnu/bitcoin-829255c8bedc-riscv64-linux-gnu.tar.gz
696325fad13780bf1cc869c00f4eec1fc2a24674d81216c1ef27b18c599368f8  guix-build-829255c8bedc/output/x86_64-apple-darwin/SHA256SUMS.part
28df4d242ecdcb68740deb874f0c2da1412f13911d963734d67e15d0e2128375  guix-build-829255c8bedc/output/x86_64-apple-darwin/bitcoin-829255c8bedc-x86_64-apple-darwin-codesigning.tar.gz
d7ab6604a954a5e99c1dad3d0ee4778eca3309a7e1fa3488526910fe09660483  guix-build-829255c8bedc/output/x86_64-apple-darwin/bitcoin-829255c8bedc-x86_64-apple-darwin-unsigned.tar.gz
752b36f03ea4ce90ee63d55bfc2b5758f3d6068a3623ac05ec43d7094fe03bc0  guix-build-829255c8bedc/output/x86_64-apple-darwin/bitcoin-829255c8bedc-x86_64-apple-darwin-unsigned.zip
880b1c1b79e7ded03ad9c5187a90a2dafca93a78e4ed5cdea60ed29e9a35b4a9  guix-build-829255c8bedc/output/x86_64-linux-gnu/SHA256SUMS.part
0e4059a744c1f5438497eff9d454184eba5e2ea0e856b9b30772397a0a4ef1c3  guix-build-829255c8bedc/output/x86_64-linux-gnu/bitcoin-829255c8bedc-x86_64-linux-gnu-debug.tar.gz
9906fa3edbdac968b1dc4565f86cc648bc808397f710dea7bfb2d1a2b9d12014  guix-build-829255c8bedc/output/x86_64-linux-gnu/bitcoin-829255c8bedc-x86_64-linux-gnu.tar.gz
cbb875c7cf6cd77d3a72817006db2fffd04234608598a22ef49ddb67fd086700  guix-build-829255c8bedc/output/x86_64-w64-mingw32/SHA256SUMS.part
d0731990e6df986dd761c7481e48adc51d219a2d58c264f7889ec814ca58bc61  guix-build-829255c8bedc/output/x86_64-w64-mingw32/bitcoin-829255c8bedc-win64-codesigning.tar.gz
76d6e71266c9baab1f177e28492e82f7c461156d11c20598265a716bb9d8cf59  guix-build-829255c8bedc/output/x86_64-w64-mingw32/bitcoin-829255c8bedc-win64-debug.zip
7b41d6c37f34315eabee59cc6987f9811da2a8f0e51a9a56e93ad552d308848e  guix-build-829255c8bedc/output/x86_64-w64-mingw32/bitcoin-829255c8bedc-win64-setup-unsigned.exe
014b91d7d11bc46ef838d1c89a6baf65bdbbefcc03affcc38a038913040e5870  guix-build-829255c8bedc/output/x86_64-w64-mingw32/bitcoin-829255c8bedc-win64-unsigned.zip

fanquake commented at 1:23 PM on June 29, 2026: member

I've got this Guix build for x86_64 and aarch64, but it doesn't match yours for x86_64-linux-gnu:

39ed6fa2d8b901b7cca10eb297f422c0d9697191188e6ba97b8201c816d53798  guix-build-829255c8bedc/output/aarch64-linux-gnu/SHA256SUMS.part
61b9fdcce254bfd9f53b914ab525ba5309ec04344ed8c4546270f643c7fcd94e  guix-build-829255c8bedc/output/aarch64-linux-gnu/bitcoin-829255c8bedc-aarch64-linux-gnu-debug.tar.gz
f41b4ca07cfb18130c407d3bfc616f1229a16e74adb53f1db133907b5fda967c  guix-build-829255c8bedc/output/aarch64-linux-gnu/bitcoin-829255c8bedc-aarch64-linux-gnu.tar.gz
6f9d026d341471e0454d8289830b00515a07b4a723252707c270063d3ff34423  guix-build-829255c8bedc/output/arm-linux-gnueabihf/SHA256SUMS.part
ee2755a24a507534e965d1042ff4757dead76eac22bfe0755f611f357ad318af  guix-build-829255c8bedc/output/arm-linux-gnueabihf/bitcoin-829255c8bedc-arm-linux-gnueabihf-debug.tar.gz
e17db3f0e30aa4384f2399310637095b01c44db03a112bce1b873e8d0718457b  guix-build-829255c8bedc/output/arm-linux-gnueabihf/bitcoin-829255c8bedc-arm-linux-gnueabihf.tar.gz
ecb89ab07b51af033df4576d7a6030e139843673192f62cb464c9f633f699cfc  guix-build-829255c8bedc/output/arm64-apple-darwin/SHA256SUMS.part
8f63120989e6495c04f632e5b8173f5301fe5f30dac63c7dde1cc1cf5f40beb0  guix-build-829255c8bedc/output/arm64-apple-darwin/bitcoin-829255c8bedc-arm64-apple-darwin-codesigning.tar.gz
8a4edfef0052142acea349f487863e25688be65b52fb03488b4b835a7dcfba30  guix-build-829255c8bedc/output/arm64-apple-darwin/bitcoin-829255c8bedc-arm64-apple-darwin-unsigned.tar.gz
162451cd3a8875e37d9cbc0933271b77f61da28712d365c4568183fe6c4a4b99  guix-build-829255c8bedc/output/arm64-apple-darwin/bitcoin-829255c8bedc-arm64-apple-darwin-unsigned.zip
6ead25df09b663bd8211054b33d300485a1ae9742564ff261ff30d1099403942  guix-build-829255c8bedc/output/dist-archive/bitcoin-829255c8bedc.tar.gz
13d2c82ea40abebe5487f576eaaa5570bf547fa5881eb0848208e8e118587818  guix-build-829255c8bedc/output/powerpc64-linux-gnu/SHA256SUMS.part
36ec0bb067672eec90c48a76925fc7ae2aa961f76a0be2001899ddfb0ddec6e1  guix-build-829255c8bedc/output/powerpc64-linux-gnu/bitcoin-829255c8bedc-powerpc64-linux-gnu-debug.tar.gz
34004370719f4a9917ab0806fd6bfdc9b75ba0361d98ac49e41ecdc418715292  guix-build-829255c8bedc/output/powerpc64-linux-gnu/bitcoin-829255c8bedc-powerpc64-linux-gnu.tar.gz
5e8c722ff3c9b74aaf4f68fbf6a80cbc5dd3f3e088e94b78b4326d2928d40dfd  guix-build-829255c8bedc/output/riscv64-linux-gnu/SHA256SUMS.part
3b9b57a931fa7c0a09420ef1c4d14518ee96529d80395f8772979dba139069b4  guix-build-829255c8bedc/output/riscv64-linux-gnu/bitcoin-829255c8bedc-riscv64-linux-gnu-debug.tar.gz
da0ed79e7d9554531c98920013ab74b6df06b92a8084a09ed011ade395529eae  guix-build-829255c8bedc/output/riscv64-linux-gnu/bitcoin-829255c8bedc-riscv64-linux-gnu.tar.gz
696325fad13780bf1cc869c00f4eec1fc2a24674d81216c1ef27b18c599368f8  guix-build-829255c8bedc/output/x86_64-apple-darwin/SHA256SUMS.part
28df4d242ecdcb68740deb874f0c2da1412f13911d963734d67e15d0e2128375  guix-build-829255c8bedc/output/x86_64-apple-darwin/bitcoin-829255c8bedc-x86_64-apple-darwin-codesigning.tar.gz
d7ab6604a954a5e99c1dad3d0ee4778eca3309a7e1fa3488526910fe09660483  guix-build-829255c8bedc/output/x86_64-apple-darwin/bitcoin-829255c8bedc-x86_64-apple-darwin-unsigned.tar.gz
752b36f03ea4ce90ee63d55bfc2b5758f3d6068a3623ac05ec43d7094fe03bc0  guix-build-829255c8bedc/output/x86_64-apple-darwin/bitcoin-829255c8bedc-x86_64-apple-darwin-unsigned.zip
4e60cebd907974b9f292b23855e739bcf5490908ab3da045e2d88958df2b9aec  guix-build-829255c8bedc/output/x86_64-linux-gnu/SHA256SUMS.part
3272c7736a9300f65900d1c2f372e6e62c3bfab3a243732d11d66ef00de35696  guix-build-829255c8bedc/output/x86_64-linux-gnu/bitcoin-829255c8bedc-x86_64-linux-gnu-debug.tar.gz
6013d536d27db00c2209247024640e9ddc1ed84f607b55658496c5bc3cb75e6f  guix-build-829255c8bedc/output/x86_64-linux-gnu/bitcoin-829255c8bedc-x86_64-linux-gnu.tar.gz
cbb875c7cf6cd77d3a72817006db2fffd04234608598a22ef49ddb67fd086700  guix-build-829255c8bedc/output/x86_64-w64-mingw32/SHA256SUMS.part
d0731990e6df986dd761c7481e48adc51d219a2d58c264f7889ec814ca58bc61  guix-build-829255c8bedc/output/x86_64-w64-mingw32/bitcoin-829255c8bedc-win64-codesigning.tar.gz
76d6e71266c9baab1f177e28492e82f7c461156d11c20598265a716bb9d8cf59  guix-build-829255c8bedc/output/x86_64-w64-mingw32/bitcoin-829255c8bedc-win64-debug.zip
7b41d6c37f34315eabee59cc6987f9811da2a8f0e51a9a56e93ad552d308848e  guix-build-829255c8bedc/output/x86_64-w64-mingw32/bitcoin-829255c8bedc-win64-setup-unsigned.exe
014b91d7d11bc46ef838d1c89a6baf65bdbbefcc03affcc38a038913040e5870  guix-build-829255c8bedc/output/x86_64-w64-mingw32/bitcoin-829255c8bedc-win64-unsigned.zip

fanquake commented at 2:41 PM on June 29, 2026: member

I've got this Guix build for x86_64 and aarch64, but it doesn't match yours for x86_64-linux-gnu:

I think this was a local caching issue. Rebuilt on x86_64, and it matched.

fanquake merged this on Jun 29, 2026

fanquake closed this on Jun 29, 2026

hebasto deleted the branch on Jun 29, 2026

pinheadmz commented at 3:34 PM on June 29, 2026: member

post merge guix build hashes:


61b9fdcce254bfd9f53b914ab525ba5309ec04344ed8c4546270f643c7fcd94e  bitcoin-829255c8bedc-aarch64-linux-gnu-debug.tar.gz
f41b4ca07cfb18130c407d3bfc616f1229a16e74adb53f1db133907b5fda967c  bitcoin-829255c8bedc-aarch64-linux-gnu.tar.gz
ee2755a24a507534e965d1042ff4757dead76eac22bfe0755f611f357ad318af  bitcoin-829255c8bedc-arm-linux-gnueabihf-debug.tar.gz
e17db3f0e30aa4384f2399310637095b01c44db03a112bce1b873e8d0718457b  bitcoin-829255c8bedc-arm-linux-gnueabihf.tar.gz
8f63120989e6495c04f632e5b8173f5301fe5f30dac63c7dde1cc1cf5f40beb0  bitcoin-829255c8bedc-arm64-apple-darwin-codesigning.tar.gz
8a4edfef0052142acea349f487863e25688be65b52fb03488b4b835a7dcfba30  bitcoin-829255c8bedc-arm64-apple-darwin-unsigned.tar.gz
162451cd3a8875e37d9cbc0933271b77f61da28712d365c4568183fe6c4a4b99  bitcoin-829255c8bedc-arm64-apple-darwin-unsigned.zip
6ead25df09b663bd8211054b33d300485a1ae9742564ff261ff30d1099403942  bitcoin-829255c8bedc.tar.gz
36ec0bb067672eec90c48a76925fc7ae2aa961f76a0be2001899ddfb0ddec6e1  bitcoin-829255c8bedc-powerpc64-linux-gnu-debug.tar.gz
34004370719f4a9917ab0806fd6bfdc9b75ba0361d98ac49e41ecdc418715292  bitcoin-829255c8bedc-powerpc64-linux-gnu.tar.gz
3b9b57a931fa7c0a09420ef1c4d14518ee96529d80395f8772979dba139069b4  bitcoin-829255c8bedc-riscv64-linux-gnu-debug.tar.gz
da0ed79e7d9554531c98920013ab74b6df06b92a8084a09ed011ade395529eae  bitcoin-829255c8bedc-riscv64-linux-gnu.tar.gz
28df4d242ecdcb68740deb874f0c2da1412f13911d963734d67e15d0e2128375  bitcoin-829255c8bedc-x86_64-apple-darwin-codesigning.tar.gz
d7ab6604a954a5e99c1dad3d0ee4778eca3309a7e1fa3488526910fe09660483  bitcoin-829255c8bedc-x86_64-apple-darwin-unsigned.tar.gz
752b36f03ea4ce90ee63d55bfc2b5758f3d6068a3623ac05ec43d7094fe03bc0  bitcoin-829255c8bedc-x86_64-apple-darwin-unsigned.zip
0e4059a744c1f5438497eff9d454184eba5e2ea0e856b9b30772397a0a4ef1c3  bitcoin-829255c8bedc-x86_64-linux-gnu-debug.tar.gz
9906fa3edbdac968b1dc4565f86cc648bc808397f710dea7bfb2d1a2b9d12014  bitcoin-829255c8bedc-x86_64-linux-gnu.tar.gz
d0731990e6df986dd761c7481e48adc51d219a2d58c264f7889ec814ca58bc61  bitcoin-829255c8bedc-win64-codesigning.tar.gz
76d6e71266c9baab1f177e28492e82f7c461156d11c20598265a716bb9d8cf59  bitcoin-829255c8bedc-win64-debug.zip
7b41d6c37f34315eabee59cc6987f9811da2a8f0e51a9a56e93ad552d308848e  bitcoin-829255c8bedc-win64-setup-unsigned.exe
014b91d7d11bc46ef838d1c89a6baf65bdbbefcc03affcc38a038913040e5870  bitcoin-829255c8bedc-win64-unsigned.zip