cmake: Fix WITH_EXTERNAL_LIBMULTIPROCESS + BUILD_FUZZ_BINARY #35715

pull ryanofsky wants to merge 1 commits into bitcoin:master from ryanofsky:pr/mpext changing 1 files +1 −1
  1. ryanofsky commented at 8:38 PM on July 13, 2026: contributor

    CMake WITH_EXTERNAL_LIBMULTIPROCESS and BUILD_FUZZ_BINARY options stopped working together recently due to #35118 commit 037ad77071419367fd679da71d5c39853d1e622e because an non-namespaced Libmultiprocess::multiprocess target name was referenced.

    Fix by specifying the full target name which is better for readability anyway.

  2. ipc # build: Fix fuzz target CMakeLists.txt for external libmultiprocess
    **What failed:** Build error: 'mp/proxy-io.h' file not found when
    building the ipc fuzz target.
    
    **Root cause:** Upstream commit 037ad770714 (fuzz: add IPC round-trip
    target) added target_link_libraries(fuzz bitcoin_ipc_fuzz multiprocess)
    using the bare 'multiprocess' target, which only exists in subtree
    builds. With WITH_EXTERNAL_LIBMULTIPROCESS=ON, no 'multiprocess' cmake
    target is defined, so the INTERFACE_INCLUDE_DIRECTORIES from the
    installed libmultiprocess headers were never propagated to the fuzz
    target, causing the missing-header error.
    
    **Fix:** Changed to 'Libmultiprocess::multiprocess', which is the
    canonical namespaced target available in both subtree and external builds.
    
    Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
    db35b9238f
  3. DrahtBot added the label Build system on Jul 13, 2026
  4. DrahtBot commented at 8:38 PM on July 13, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35715.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK sedited, hebasto

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. sedited approved
  6. sedited commented at 8:42 PM on July 13, 2026: contributor

    ACK db35b9238fc903c1dcbc0d428b247250d46c3b41

  7. hebasto approved
  8. hebasto commented at 8:51 PM on July 13, 2026: member

    ACK db35b9238fc903c1dcbc0d428b247250d46c3b41, I have reviewed the code and it looks OK.

  9. sedited merged this on Jul 13, 2026
  10. sedited closed this on Jul 13, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-07-14 13:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me