util: atomically write banlist.json and rename WriteSettings to WriteJsonUnsafe #35763

pull kevkevinpal wants to merge 1 commits into bitcoin:master from kevkevinpal:banlist-atomic-write-json-unsafe changing 5 files +42 −10

kevkevinpal commented at 12:47 PM on July 21, 2026: contributor
Summary

This is a follow-up to #35384 (comment)
- CBanDB::Write now writes banlist.json.tmp and uses RenameOver, so a failed/interrupted write can’t leave a truncated banlist.json (same pattern as settings.json).
- Renamed common::WriteSettings → common::WriteJsonUnsafe and documented that callers must pair it with an atomic rename.
- Added a unit test that checks the write/read roundtrip and that the .tmp file is gone after success.
util: atomically write banlist.json and rename WriteSettings to WriteJsonUnsafe 07ec5af152
DrahtBot added the label Utils/log/libs on Jul 21, 2026
DrahtBot commented at 12:47 PM on July 21, 2026: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35763.



Reviews

See the guideline and AI policy for information on the review process.

Type Reviewers

Concept ACK winterrdog

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.
winterrdog commented at 5:42 PM on July 21, 2026: contributor

Concept ACK

Thanks for picking these up.

Type	Reviewers
Concept ACK	winterrdog

Contributors

Labels

Summary