scripted-diff: Use C.UTF-8 locale in all shell scripts #35778

pull hebasto wants to merge 3 commits into bitcoin:master from hebasto:260722-lint-subtree changing 13 files +14 −15
  1. hebasto commented at 3:49 PM on July 22, 2026: member

    This unifies the used locales across the entire codebase.

    Additionally, the test/lint/lint-shell-locale.py linter has been adjusted accordingly.

    Also see #35775 (comment).

  2. DrahtBot added the label Tests on Jul 22, 2026
  3. DrahtBot commented at 3:49 PM on July 22, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35778.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #35167 (Convert check-deps.sh to python by ajtowns)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. fanquake commented at 3:51 PM on July 22, 2026: member

    If you're planning on making a change that requires this, could just combine it with that change, so it's immediately obvious why it's needed?

  5. hebasto commented at 11:35 AM on July 23, 2026: member

    If you're planning on making a change that requires this, could just combine it with that change, so it's immediately obvious why it's needed?

    Sure. Drafted for now.

  6. hebasto marked this as a draft on Jul 23, 2026
  7. scripted-diff: Use C.UTF-8 locale in all shell scripts
    There is no reason to avoid it nowadays.
    
    -BEGIN VERIFY SCRIPT-
    
    sed -i "s/\<export LC_ALL=C\>/export LC_ALL=C.UTF-8/g" \
     $( git grep -l "^export LC_ALL=C$" -- ':!src/ipc/libmultiprocess' ':!src/minisketch' ':!src/secp256k1' )
    
    -END VERIFY SCRIPT-
    1194918a5d
  8. lint: Skip `libmultiprocess` subtree in `lint-shell-locale.py` 982ee64938
  9. lint: Use C.UTF-8 locale only in shell scripts fd0b0ed0f3
  10. hebasto force-pushed on Jul 26, 2026
  11. hebasto renamed this:
    lint: Skip `libmultiprocess` subtree in `lint-shell-locale.py`
    scripted-diff: Use C.UTF-8 locale in all shell scripts
    on Jul 26, 2026
  12. hebasto commented at 3:53 PM on July 26, 2026: member

    Reworked and undrafted.

  13. hebasto marked this as ready for review on Jul 26, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-07-31 20:50 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me