scripted-diff: Use C.UTF-8 locale in all shell scripts #35778

pull hebasto wants to merge 3 commits into bitcoin:master from hebasto:260722-lint-subtree changing 13 files +16 −17
  1. hebasto commented at 3:49 PM on July 22, 2026: member

    This unifies the used locales across the entire codebase.

    Additionally, the test/lint/lint-shell-locale.py linter has been adjusted accordingly.

    Also see #35775 (comment).

  2. DrahtBot added the label Tests on Jul 22, 2026
  3. DrahtBot commented at 3:49 PM on July 22, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35778.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK fanquake
    Stale ACK sedited

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #35167 (Convert check-deps.sh to python by ajtowns)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. fanquake commented at 3:51 PM on July 22, 2026: member

    If you're planning on making a change that requires this, could just combine it with that change, so it's immediately obvious why it's needed?

  5. hebasto commented at 11:35 AM on July 23, 2026: member

    If you're planning on making a change that requires this, could just combine it with that change, so it's immediately obvious why it's needed?

    Sure. Drafted for now.

  6. hebasto marked this as a draft on Jul 23, 2026
  7. scripted-diff: Use C.UTF-8 locale in all shell scripts
    There is no reason to avoid it nowadays.
    
    -BEGIN VERIFY SCRIPT-
    
    sed -i "s/\<export LC_ALL=C\>/export LC_ALL=C.UTF-8/g" \
     $( git grep -l "^export LC_ALL=C$" -- ':!src/ipc/libmultiprocess' ':!src/minisketch' ':!src/secp256k1' )
    
    -END VERIFY SCRIPT-
    1194918a5d
  8. lint: Skip `libmultiprocess` subtree in `lint-shell-locale.py` 982ee64938
  9. hebasto force-pushed on Jul 26, 2026
  10. hebasto renamed this:
    lint: Skip `libmultiprocess` subtree in `lint-shell-locale.py`
    scripted-diff: Use C.UTF-8 locale in all shell scripts
    on Jul 26, 2026
  11. hebasto commented at 3:53 PM on July 26, 2026: member

    Reworked and undrafted.

  12. hebasto marked this as ready for review on Jul 26, 2026
  13. sedited approved
  14. sedited commented at 9:42 AM on September 9, 2026: contributor

    ACK fd0b0ed0f3995b3cf0ef87db8a7e98ff4afd5c89

  15. lint: Use C.UTF-8 locale only in shell scripts 46654094be
  16. in test/lint/lint-shell-locale.py:9 in fd0b0ed0f3


    fanquake commented at 10:01 AM on September 9, 2026:

    Also need to update the docs here

    "opt out of locale dependence using export LC_ALL=C"


    hebasto commented at 10:09 AM on September 9, 2026:

    Thanks! Updated.

  17. hebasto force-pushed on Sep 9, 2026
  18. fanquake commented at 11:01 AM on September 9, 2026: member

    ACK 46654094beefb6d41cad477fc63e8ddbaa5387a2

  19. DrahtBot requested review from sedited on Sep 9, 2026
  20. fanquake merged this on Sep 9, 2026
  21. fanquake closed this on Sep 9, 2026

  22. hebasto deleted the branch on Sep 9, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-09-20 16:52 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me