guix: followups to #35537 #35821

pull fanquake wants to merge 5 commits into bitcoin:master from fanquake:guix_split_followups changing 7 files +114 −150
  1. fanquake commented at 11:22 AM on July 27, 2026: member

    This deduplicates setup code, as well as adds flags to turn linker warnings into errors, which is easier now that the GUI build has been split out (the gui link warns about shared libs during linking).

  2. DrahtBot added the label Build system on Jul 27, 2026
  3. DrahtBot commented at 11:22 AM on July 27, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35821.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK hebasto

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #25573 (guix: produce a -static-pie bitcoind by fanquake)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. hebasto commented at 11:26 AM on July 27, 2026: member

    Concept ACK.

  5. hebasto commented at 2:34 PM on July 27, 2026: member

    My Guix build:

    aarch64
    0fe222e2aa6feec6068dc2f5564f659d726f82f6dc4db7594e3a6c859a863bd0  guix-build-80a906ec67f0/output/aarch64-linux-gnu/SHA256SUMS.part
    1f6d4adc5e5fe386e5577abac0d768b0bdbb0218fa06e5ae22d2347c2412b1ce  guix-build-80a906ec67f0/output/aarch64-linux-gnu/bitcoin-80a906ec67f0-aarch64-linux-gnu-debug.tar.gz
    21788b20d274e5f9cf144faad5376ac6942d106f7c16709c4474fc969a9ab93e  guix-build-80a906ec67f0/output/aarch64-linux-gnu/bitcoin-80a906ec67f0-aarch64-linux-gnu.tar.gz
    c396ca016bce19f7e09d751857a47a55f71539fe9c25a7f24278a39fba556ef5  guix-build-80a906ec67f0/output/arm-linux-gnueabihf/SHA256SUMS.part
    5d089ff91c71bc4a4c1c1caab8d023d7ecc4102565a8cba7496327f006e585cc  guix-build-80a906ec67f0/output/arm-linux-gnueabihf/bitcoin-80a906ec67f0-arm-linux-gnueabihf-debug.tar.gz
    8095f7253f4d35f686b20f04e233d4308d4a3e00a8b12b52fe82d6d7fdcab473  guix-build-80a906ec67f0/output/arm-linux-gnueabihf/bitcoin-80a906ec67f0-arm-linux-gnueabihf.tar.gz
    5119191882b52485c0b0bcb0c0b11334cb2d0455e84b58503c206b9199e75307  guix-build-80a906ec67f0/output/arm64-apple-darwin/SHA256SUMS.part
    6050b0e8db91b1af48654d4eaa63d65e7d0dacd60592214a09a092e08e53c45a  guix-build-80a906ec67f0/output/arm64-apple-darwin/bitcoin-80a906ec67f0-arm64-apple-darwin-codesigning.tar.gz
    e52e645c0426a4613f3783edb1b96c5c8591ff3ae440505b3c2c784c25de035d  guix-build-80a906ec67f0/output/arm64-apple-darwin/bitcoin-80a906ec67f0-arm64-apple-darwin-unsigned.tar.gz
    647e7149fba57e1a1571402ee345f60e802eb525356f111c06961c5d4243ff37  guix-build-80a906ec67f0/output/arm64-apple-darwin/bitcoin-80a906ec67f0-arm64-apple-darwin-unsigned.zip
    53e5ab1363e0882c79427e1ae336f37d1ca1cc58d598d501316e8da9264c6f54  guix-build-80a906ec67f0/output/dist-archive/bitcoin-80a906ec67f0.tar.gz
    6539a2956cf22fc07d41428d5b31153a9d8858c747daca3449a649762ee6421b  guix-build-80a906ec67f0/output/powerpc64-linux-gnu/SHA256SUMS.part
    7af673e3dfaea9974f60ea376be366f94b4d1fbf6d48028c25a7725c7acf8d2e  guix-build-80a906ec67f0/output/powerpc64-linux-gnu/bitcoin-80a906ec67f0-powerpc64-linux-gnu-debug.tar.gz
    c769ee67f5aa38935d19f3f072c44385ec00345d6319e164abe606ae577725ea  guix-build-80a906ec67f0/output/powerpc64-linux-gnu/bitcoin-80a906ec67f0-powerpc64-linux-gnu.tar.gz
    c01057ffd7e963edc1627960372c66d2dead98d76d82f9244d02c9109030d7bc  guix-build-80a906ec67f0/output/riscv64-linux-gnu/SHA256SUMS.part
    65381372098d094a8bb00d55ea1d2714ddeb5caffc24dcf95048ad4861b84f59  guix-build-80a906ec67f0/output/riscv64-linux-gnu/bitcoin-80a906ec67f0-riscv64-linux-gnu-debug.tar.gz
    8b628356cdd3ee1390fbf6b15d0f4e6cbfde11df895c5e3574b952dd0ce5622a  guix-build-80a906ec67f0/output/riscv64-linux-gnu/bitcoin-80a906ec67f0-riscv64-linux-gnu.tar.gz
    7c0702229ee71fc7fd3bc67b6b214cf8c1679e0e3b95f54313c92109ec174ba0  guix-build-80a906ec67f0/output/x86_64-apple-darwin/SHA256SUMS.part
    e4aa88d31c72c0d98b5da49a82b9ba12c39bfdb98cb814e65a0cd843f1d2c5d9  guix-build-80a906ec67f0/output/x86_64-apple-darwin/bitcoin-80a906ec67f0-x86_64-apple-darwin-codesigning.tar.gz
    3ad1941d929c7d627a1cc1d6603344126c947ef343a57a56c85993ee4d29cf4c  guix-build-80a906ec67f0/output/x86_64-apple-darwin/bitcoin-80a906ec67f0-x86_64-apple-darwin-unsigned.tar.gz
    faf70fefe3913bcd7b56d5b38fe42ef6298d4efb5bff65afaa1bd8e6b782e608  guix-build-80a906ec67f0/output/x86_64-apple-darwin/bitcoin-80a906ec67f0-x86_64-apple-darwin-unsigned.zip
    013ab164aae9b5812170bc434ae657b027b71b2d6d5ebf6524f2be2546e7b258  guix-build-80a906ec67f0/output/x86_64-linux-gnu/SHA256SUMS.part
    ece4f79c4299253b21bdec929a26c0f5edc8bb02c5f5a31572d1c646409b63d9  guix-build-80a906ec67f0/output/x86_64-linux-gnu/bitcoin-80a906ec67f0-x86_64-linux-gnu-debug.tar.gz
    64856c291c8fb4ccd1ef1e365b8006f9338f137f0a31dac20b8048a53d0f3055  guix-build-80a906ec67f0/output/x86_64-linux-gnu/bitcoin-80a906ec67f0-x86_64-linux-gnu.tar.gz
    92b85a27c0bbe92a2af1c10159aa5e2cd5d6bf8d75a527a83fe6a7bb6bce470e  guix-build-80a906ec67f0/output/x86_64-w64-mingw32/SHA256SUMS.part
    0c224eeca1a9762d1ad44c24a54c8b065b9fbb276e67fbd5519fae46fdda6b0d  guix-build-80a906ec67f0/output/x86_64-w64-mingw32/bitcoin-80a906ec67f0-win64-codesigning.tar.gz
    30dec186e4ec791bee0f8bdfec0df8f50c06be44258b633b2338f05123fd7376  guix-build-80a906ec67f0/output/x86_64-w64-mingw32/bitcoin-80a906ec67f0-win64-debug.zip
    933d21d48a8af50c783931199ec86f616b552f3868d038a1bbbd422205bbbc14  guix-build-80a906ec67f0/output/x86_64-w64-mingw32/bitcoin-80a906ec67f0-win64-setup-unsigned.exe
    dff1ed9309ff52c917aad241653db9b2acbe0226bf5463f6a778daea77e93af0  guix-build-80a906ec67f0/output/x86_64-w64-mingw32/bitcoin-80a906ec67f0-win64-unsigned.zip
    
  6. fanquake marked this as ready for review on Jul 28, 2026
  7. fanquake commented at 1:01 PM on July 28, 2026: member

    Guix Build (x86_64):

    0fe222e2aa6feec6068dc2f5564f659d726f82f6dc4db7594e3a6c859a863bd0  guix-build-80a906ec67f0/output/aarch64-linux-gnu/SHA256SUMS.part
    1f6d4adc5e5fe386e5577abac0d768b0bdbb0218fa06e5ae22d2347c2412b1ce  guix-build-80a906ec67f0/output/aarch64-linux-gnu/bitcoin-80a906ec67f0-aarch64-linux-gnu-debug.tar.gz
    21788b20d274e5f9cf144faad5376ac6942d106f7c16709c4474fc969a9ab93e  guix-build-80a906ec67f0/output/aarch64-linux-gnu/bitcoin-80a906ec67f0-aarch64-linux-gnu.tar.gz
    c396ca016bce19f7e09d751857a47a55f71539fe9c25a7f24278a39fba556ef5  guix-build-80a906ec67f0/output/arm-linux-gnueabihf/SHA256SUMS.part
    5d089ff91c71bc4a4c1c1caab8d023d7ecc4102565a8cba7496327f006e585cc  guix-build-80a906ec67f0/output/arm-linux-gnueabihf/bitcoin-80a906ec67f0-arm-linux-gnueabihf-debug.tar.gz
    8095f7253f4d35f686b20f04e233d4308d4a3e00a8b12b52fe82d6d7fdcab473  guix-build-80a906ec67f0/output/arm-linux-gnueabihf/bitcoin-80a906ec67f0-arm-linux-gnueabihf.tar.gz
    5119191882b52485c0b0bcb0c0b11334cb2d0455e84b58503c206b9199e75307  guix-build-80a906ec67f0/output/arm64-apple-darwin/SHA256SUMS.part
    6050b0e8db91b1af48654d4eaa63d65e7d0dacd60592214a09a092e08e53c45a  guix-build-80a906ec67f0/output/arm64-apple-darwin/bitcoin-80a906ec67f0-arm64-apple-darwin-codesigning.tar.gz
    e52e645c0426a4613f3783edb1b96c5c8591ff3ae440505b3c2c784c25de035d  guix-build-80a906ec67f0/output/arm64-apple-darwin/bitcoin-80a906ec67f0-arm64-apple-darwin-unsigned.tar.gz
    647e7149fba57e1a1571402ee345f60e802eb525356f111c06961c5d4243ff37  guix-build-80a906ec67f0/output/arm64-apple-darwin/bitcoin-80a906ec67f0-arm64-apple-darwin-unsigned.zip
    53e5ab1363e0882c79427e1ae336f37d1ca1cc58d598d501316e8da9264c6f54  guix-build-80a906ec67f0/output/dist-archive/bitcoin-80a906ec67f0.tar.gz
    6539a2956cf22fc07d41428d5b31153a9d8858c747daca3449a649762ee6421b  guix-build-80a906ec67f0/output/powerpc64-linux-gnu/SHA256SUMS.part
    7af673e3dfaea9974f60ea376be366f94b4d1fbf6d48028c25a7725c7acf8d2e  guix-build-80a906ec67f0/output/powerpc64-linux-gnu/bitcoin-80a906ec67f0-powerpc64-linux-gnu-debug.tar.gz
    c769ee67f5aa38935d19f3f072c44385ec00345d6319e164abe606ae577725ea  guix-build-80a906ec67f0/output/powerpc64-linux-gnu/bitcoin-80a906ec67f0-powerpc64-linux-gnu.tar.gz
    c01057ffd7e963edc1627960372c66d2dead98d76d82f9244d02c9109030d7bc  guix-build-80a906ec67f0/output/riscv64-linux-gnu/SHA256SUMS.part
    65381372098d094a8bb00d55ea1d2714ddeb5caffc24dcf95048ad4861b84f59  guix-build-80a906ec67f0/output/riscv64-linux-gnu/bitcoin-80a906ec67f0-riscv64-linux-gnu-debug.tar.gz
    8b628356cdd3ee1390fbf6b15d0f4e6cbfde11df895c5e3574b952dd0ce5622a  guix-build-80a906ec67f0/output/riscv64-linux-gnu/bitcoin-80a906ec67f0-riscv64-linux-gnu.tar.gz
    7c0702229ee71fc7fd3bc67b6b214cf8c1679e0e3b95f54313c92109ec174ba0  guix-build-80a906ec67f0/output/x86_64-apple-darwin/SHA256SUMS.part
    e4aa88d31c72c0d98b5da49a82b9ba12c39bfdb98cb814e65a0cd843f1d2c5d9  guix-build-80a906ec67f0/output/x86_64-apple-darwin/bitcoin-80a906ec67f0-x86_64-apple-darwin-codesigning.tar.gz
    3ad1941d929c7d627a1cc1d6603344126c947ef343a57a56c85993ee4d29cf4c  guix-build-80a906ec67f0/output/x86_64-apple-darwin/bitcoin-80a906ec67f0-x86_64-apple-darwin-unsigned.tar.gz
    faf70fefe3913bcd7b56d5b38fe42ef6298d4efb5bff65afaa1bd8e6b782e608  guix-build-80a906ec67f0/output/x86_64-apple-darwin/bitcoin-80a906ec67f0-x86_64-apple-darwin-unsigned.zip
    013ab164aae9b5812170bc434ae657b027b71b2d6d5ebf6524f2be2546e7b258  guix-build-80a906ec67f0/output/x86_64-linux-gnu/SHA256SUMS.part
    ece4f79c4299253b21bdec929a26c0f5edc8bb02c5f5a31572d1c646409b63d9  guix-build-80a906ec67f0/output/x86_64-linux-gnu/bitcoin-80a906ec67f0-x86_64-linux-gnu-debug.tar.gz
    64856c291c8fb4ccd1ef1e365b8006f9338f137f0a31dac20b8048a53d0f3055  guix-build-80a906ec67f0/output/x86_64-linux-gnu/bitcoin-80a906ec67f0-x86_64-linux-gnu.tar.gz
    92b85a27c0bbe92a2af1c10159aa5e2cd5d6bf8d75a527a83fe6a7bb6bce470e  guix-build-80a906ec67f0/output/x86_64-w64-mingw32/SHA256SUMS.part
    0c224eeca1a9762d1ad44c24a54c8b065b9fbb276e67fbd5519fae46fdda6b0d  guix-build-80a906ec67f0/output/x86_64-w64-mingw32/bitcoin-80a906ec67f0-win64-codesigning.tar.gz
    30dec186e4ec791bee0f8bdfec0df8f50c06be44258b633b2338f05123fd7376  guix-build-80a906ec67f0/output/x86_64-w64-mingw32/bitcoin-80a906ec67f0-win64-debug.zip
    933d21d48a8af50c783931199ec86f616b552f3868d038a1bbbd422205bbbc14  guix-build-80a906ec67f0/output/x86_64-w64-mingw32/bitcoin-80a906ec67f0-win64-setup-unsigned.exe
    dff1ed9309ff52c917aad241653db9b2acbe0226bf5463f6a778daea77e93af0  guix-build-80a906ec67f0/output/x86_64-w64-mingw32/bitcoin-80a906ec67f0-win64-unsigned.zip
    
  8. in contrib/guix/libexec/setup.sh:92 in 80a906ec67 outdated
      85 | @@ -86,6 +86,84 @@ glibc_dynamic_linker() {
      86 |      esac
      87 |  }
      88 |  
      89 | +gcc_toolchain() {
      90 | +    # Set environment variables to point the NATIVE toolchain to the right
      91 | +    # includes/libs
      92 | +    local NATIVE_GCC NATIVE_GCC_STATIC CROSS_GLIBC CROSS_GLIBC_STATIC CROSS_KERNEL CROSS_GCC CROSS_GCC_LIB_STORE CROSS_GCC_LIBS CROSS_GCC_LIB
    


    hebasto commented at 9:04 PM on July 28, 2026:

    style nit: Local variable naming style could be consistent across all *_toolchain() functions.


    fanquake commented at 9:53 AM on July 29, 2026:

    Do you just mean making the local variables UPPERCASE?


    hebasto commented at 10:04 AM on July 29, 2026:

    Either UPPER_CASE or snake_case, just to be consistent.


    fanquake commented at 10:21 AM on July 29, 2026:

    Done

  9. hebasto commented at 9:05 PM on July 28, 2026: member

    3f70305cf8226f9b2b82cf00d2c9d4592f218768 "guix: turn linux/win linker warnings into errors"

    Why not in contrib/guix/libexec/build_linux_gui.sh as well?

    "warning: libgcc_s.so.1, needed by /bitcoin/depends/<host>/lib/libfontconfig.so, not found (try using -rpath or -rpath-link)" can be silenced by -Wl,-rpath-link=$(store_path "gcc-cross-${HOST}" lib)/${HOST}/lib.

  10. 0xB10C commented at 7:58 AM on July 29, 2026: contributor
    x86_64
    0fe222e2aa6feec6068dc2f5564f659d726f82f6dc4db7594e3a6c859a863bd0  guix-build-80a906ec67f0/output/aarch64-linux-gnu/SHA256SUMS.part
    1f6d4adc5e5fe386e5577abac0d768b0bdbb0218fa06e5ae22d2347c2412b1ce  guix-build-80a906ec67f0/output/aarch64-linux-gnu/bitcoin-80a906ec67f0-aarch64-linux-gnu-debug.tar.gz
    21788b20d274e5f9cf144faad5376ac6942d106f7c16709c4474fc969a9ab93e  guix-build-80a906ec67f0/output/aarch64-linux-gnu/bitcoin-80a906ec67f0-aarch64-linux-gnu.tar.gz
    c396ca016bce19f7e09d751857a47a55f71539fe9c25a7f24278a39fba556ef5  guix-build-80a906ec67f0/output/arm-linux-gnueabihf/SHA256SUMS.part
    5d089ff91c71bc4a4c1c1caab8d023d7ecc4102565a8cba7496327f006e585cc  guix-build-80a906ec67f0/output/arm-linux-gnueabihf/bitcoin-80a906ec67f0-arm-linux-gnueabihf-debug.tar.gz
    8095f7253f4d35f686b20f04e233d4308d4a3e00a8b12b52fe82d6d7fdcab473  guix-build-80a906ec67f0/output/arm-linux-gnueabihf/bitcoin-80a906ec67f0-arm-linux-gnueabihf.tar.gz
    5119191882b52485c0b0bcb0c0b11334cb2d0455e84b58503c206b9199e75307  guix-build-80a906ec67f0/output/arm64-apple-darwin/SHA256SUMS.part
    6050b0e8db91b1af48654d4eaa63d65e7d0dacd60592214a09a092e08e53c45a  guix-build-80a906ec67f0/output/arm64-apple-darwin/bitcoin-80a906ec67f0-arm64-apple-darwin-codesigning.tar.gz
    e52e645c0426a4613f3783edb1b96c5c8591ff3ae440505b3c2c784c25de035d  guix-build-80a906ec67f0/output/arm64-apple-darwin/bitcoin-80a906ec67f0-arm64-apple-darwin-unsigned.tar.gz
    647e7149fba57e1a1571402ee345f60e802eb525356f111c06961c5d4243ff37  guix-build-80a906ec67f0/output/arm64-apple-darwin/bitcoin-80a906ec67f0-arm64-apple-darwin-unsigned.zip
    53e5ab1363e0882c79427e1ae336f37d1ca1cc58d598d501316e8da9264c6f54  guix-build-80a906ec67f0/output/dist-archive/bitcoin-80a906ec67f0.tar.gz
    6539a2956cf22fc07d41428d5b31153a9d8858c747daca3449a649762ee6421b  guix-build-80a906ec67f0/output/powerpc64-linux-gnu/SHA256SUMS.part
    7af673e3dfaea9974f60ea376be366f94b4d1fbf6d48028c25a7725c7acf8d2e  guix-build-80a906ec67f0/output/powerpc64-linux-gnu/bitcoin-80a906ec67f0-powerpc64-linux-gnu-debug.tar.gz
    c769ee67f5aa38935d19f3f072c44385ec00345d6319e164abe606ae577725ea  guix-build-80a906ec67f0/output/powerpc64-linux-gnu/bitcoin-80a906ec67f0-powerpc64-linux-gnu.tar.gz
    c01057ffd7e963edc1627960372c66d2dead98d76d82f9244d02c9109030d7bc  guix-build-80a906ec67f0/output/riscv64-linux-gnu/SHA256SUMS.part
    65381372098d094a8bb00d55ea1d2714ddeb5caffc24dcf95048ad4861b84f59  guix-build-80a906ec67f0/output/riscv64-linux-gnu/bitcoin-80a906ec67f0-riscv64-linux-gnu-debug.tar.gz
    8b628356cdd3ee1390fbf6b15d0f4e6cbfde11df895c5e3574b952dd0ce5622a  guix-build-80a906ec67f0/output/riscv64-linux-gnu/bitcoin-80a906ec67f0-riscv64-linux-gnu.tar.gz
    7c0702229ee71fc7fd3bc67b6b214cf8c1679e0e3b95f54313c92109ec174ba0  guix-build-80a906ec67f0/output/x86_64-apple-darwin/SHA256SUMS.part
    e4aa88d31c72c0d98b5da49a82b9ba12c39bfdb98cb814e65a0cd843f1d2c5d9  guix-build-80a906ec67f0/output/x86_64-apple-darwin/bitcoin-80a906ec67f0-x86_64-apple-darwin-codesigning.tar.gz
    3ad1941d929c7d627a1cc1d6603344126c947ef343a57a56c85993ee4d29cf4c  guix-build-80a906ec67f0/output/x86_64-apple-darwin/bitcoin-80a906ec67f0-x86_64-apple-darwin-unsigned.tar.gz
    faf70fefe3913bcd7b56d5b38fe42ef6298d4efb5bff65afaa1bd8e6b782e608  guix-build-80a906ec67f0/output/x86_64-apple-darwin/bitcoin-80a906ec67f0-x86_64-apple-darwin-unsigned.zip
    013ab164aae9b5812170bc434ae657b027b71b2d6d5ebf6524f2be2546e7b258  guix-build-80a906ec67f0/output/x86_64-linux-gnu/SHA256SUMS.part
    ece4f79c4299253b21bdec929a26c0f5edc8bb02c5f5a31572d1c646409b63d9  guix-build-80a906ec67f0/output/x86_64-linux-gnu/bitcoin-80a906ec67f0-x86_64-linux-gnu-debug.tar.gz
    64856c291c8fb4ccd1ef1e365b8006f9338f137f0a31dac20b8048a53d0f3055  guix-build-80a906ec67f0/output/x86_64-linux-gnu/bitcoin-80a906ec67f0-x86_64-linux-gnu.tar.gz
    92b85a27c0bbe92a2af1c10159aa5e2cd5d6bf8d75a527a83fe6a7bb6bce470e  guix-build-80a906ec67f0/output/x86_64-w64-mingw32/SHA256SUMS.part
    0c224eeca1a9762d1ad44c24a54c8b065b9fbb276e67fbd5519fae46fdda6b0d  guix-build-80a906ec67f0/output/x86_64-w64-mingw32/bitcoin-80a906ec67f0-win64-codesigning.tar.gz
    30dec186e4ec791bee0f8bdfec0df8f50c06be44258b633b2338f05123fd7376  guix-build-80a906ec67f0/output/x86_64-w64-mingw32/bitcoin-80a906ec67f0-win64-debug.zip
    933d21d48a8af50c783931199ec86f616b552f3868d038a1bbbd422205bbbc14  guix-build-80a906ec67f0/output/x86_64-w64-mingw32/bitcoin-80a906ec67f0-win64-setup-unsigned.exe
    dff1ed9309ff52c917aad241653db9b2acbe0226bf5463f6a778daea77e93af0  guix-build-80a906ec67f0/output/x86_64-w64-mingw32/bitcoin-80a906ec67f0-win64-unsigned.zip
    
  11. fanquake commented at 10:16 AM on July 29, 2026: member

    Why not in contrib/guix/libexec/build_linux_gui.sh as well? can be silenced by -Wl,-rpath-link=$(store_path "gcc-cross-${HOST}" lib)/${HOST}/lib.

    I didn't really want to make changes to the GUI build/deps here, and I think it would be better to build the libs with -static-libgcc, rather than passing flags to silence (legitimate) output?

  12. guix: turn linux/win linker warnings into errors
    Can do this now that the GUI has been split out.
    
    riscv64-linux-gnu failus due to
    https://github.com/boostorg/test/issues/345:
    ```bash
    [102%] Linking CXX executable ../../bin/test_bitcoin
    /gnu/store/r03804zpq5i6wsalx0yaqrr5jb7pqrmv-binutils-cross-riscv64-linux-gnu-2.46.0/bin/riscv64-linux-gnu-ld: CMakeFiles/test_bitcoin.dir/main.cpp.o: in function `boost::fpe::disable(unsigned int)':
    /bitcoin/depends/riscv64-linux-gnu/boost/include/boost/test/impl/execution_monitor.ipp:1538:(.text+0x9dc8): warning: fedisableexcept is not implemented and will always fail
    /gnu/store/r03804zpq5i6wsalx0yaqrr5jb7pqrmv-binutils-cross-riscv64-linux-gnu-2.46.0/bin/riscv64-linux-gnu-ld: CMakeFiles/test_bitcoin.dir/main.cpp.o: in function `boost::fpe::enable(unsigned int)':
    /bitcoin/depends/riscv64-linux-gnu/boost/include/boost/test/impl/execution_monitor.ipp:1502:(.text+0x9d76): warning: feenableexcept is not implemented and will always fail
    collect2: error: ld returned 1 exit status
    ```
    
    Darwin could be done after something like
    https://github.com/bitcoin/bitcoin/pull/35756.
    b12a70f330
  13. guix: consolidate LLVM toolchain setup cc9b0f2266
  14. guix: consolidate mingw-w64 toolchain setup 288f76ed0f
  15. guix: consolidate gcc toolchain setup 665f11d04a
  16. guix: consolidate config flags 683ae4c520
  17. fanquake force-pushed on Jul 29, 2026
  18. hebasto approved
  19. hebasto commented at 10:26 AM on July 29, 2026: member

    ACK 683ae4c520b17d93e1fe7695506d1815ae200ded, I have reviewed the code and it looks OK.

  20. fanquake commented at 12:16 PM on July 29, 2026: member

    Guix Build (x86_64):

    50bb780fae3da8e43ba12779305293d91b948527427077bc5af8dabb60def90a  guix-build-683ae4c520b1/output/aarch64-linux-gnu/SHA256SUMS.part
    09680fd7dda45acdb9db419d2d2ffacf26744b3a92bec5a15b0ae1ba1f172b87  guix-build-683ae4c520b1/output/aarch64-linux-gnu/bitcoin-683ae4c520b1-aarch64-linux-gnu-debug.tar.gz
    244100e7c377e0dd88c2b25d8940930c8a08a67f2b7d52a920a981af348fb769  guix-build-683ae4c520b1/output/aarch64-linux-gnu/bitcoin-683ae4c520b1-aarch64-linux-gnu.tar.gz
    1be2ec92c364a35637efa720d36b7c3e0435078791c867f9ad01db536c1a051d  guix-build-683ae4c520b1/output/arm-linux-gnueabihf/SHA256SUMS.part
    284127a045a02a17a862b404d5cd823b117daf188b531e248bb6c4b03bf010dc  guix-build-683ae4c520b1/output/arm-linux-gnueabihf/bitcoin-683ae4c520b1-arm-linux-gnueabihf-debug.tar.gz
    e072dbae3b3b58b448d6a721d5b9d64594630e2188a2573cbd61cc72d95f2787  guix-build-683ae4c520b1/output/arm-linux-gnueabihf/bitcoin-683ae4c520b1-arm-linux-gnueabihf.tar.gz
    8a01c59b4ba8f954584b099f26b51391d2cc271f1da79ebc703d4a1efdc13c7a  guix-build-683ae4c520b1/output/arm64-apple-darwin/SHA256SUMS.part
    63d8b3b5e45d23592a4d8bd4734d7548827e79f42cc5bdeaf1d44aeb06cdb9af  guix-build-683ae4c520b1/output/arm64-apple-darwin/bitcoin-683ae4c520b1-arm64-apple-darwin-codesigning.tar.gz
    903c3f350cbf51c07fece7ef446fc4bdb4ad30f1c91b8d1c529e854c03657ae7  guix-build-683ae4c520b1/output/arm64-apple-darwin/bitcoin-683ae4c520b1-arm64-apple-darwin-unsigned.tar.gz
    b0b9dabad568da668ffa598346c12b66b59750d5faf0c1358321ae18f3e3c5d5  guix-build-683ae4c520b1/output/arm64-apple-darwin/bitcoin-683ae4c520b1-arm64-apple-darwin-unsigned.zip
    1e4c79a6965bb836315bbb192b91d8886dbca5c8f4a3f1ac29c801fb6e1afb7d  guix-build-683ae4c520b1/output/dist-archive/bitcoin-683ae4c520b1.tar.gz
    680e49f65caa68999e15de85318cbd6dbdaca1fb7ee21025e48846b6b16d128e  guix-build-683ae4c520b1/output/powerpc64-linux-gnu/SHA256SUMS.part
    88eb13ecd5e6546c4a09f55f3aeab634fcace15211e65485518aca7f1282a74e  guix-build-683ae4c520b1/output/powerpc64-linux-gnu/bitcoin-683ae4c520b1-powerpc64-linux-gnu-debug.tar.gz
    1bbb242709d283b18decd1799ba6c772750025dd88d0ae67aaa6c01d9edfb006  guix-build-683ae4c520b1/output/powerpc64-linux-gnu/bitcoin-683ae4c520b1-powerpc64-linux-gnu.tar.gz
    0e66a841c776448f1ecca55e1ff60f6b84a2bb4410afe2aa22aa9a1d001fffdb  guix-build-683ae4c520b1/output/riscv64-linux-gnu/SHA256SUMS.part
    14a1a61bd58ba56b099364038f36bb9d392cfa5236635c9a142989f0be5f3610  guix-build-683ae4c520b1/output/riscv64-linux-gnu/bitcoin-683ae4c520b1-riscv64-linux-gnu-debug.tar.gz
    d105387edc9bbf247862f1e7fac59bd2f7546e6c8d57cd707983375e7e3abf73  guix-build-683ae4c520b1/output/riscv64-linux-gnu/bitcoin-683ae4c520b1-riscv64-linux-gnu.tar.gz
    f49ba29efedf394b654de486aae585fafa99aea94e404139432a25009215a00b  guix-build-683ae4c520b1/output/x86_64-apple-darwin/SHA256SUMS.part
    ff241a32caeb20eeb7a4da54fecd3b236909953314b75fcfa3c1a8f01628553a  guix-build-683ae4c520b1/output/x86_64-apple-darwin/bitcoin-683ae4c520b1-x86_64-apple-darwin-codesigning.tar.gz
    077bdc6c8777ae6f1266f33aad1003dc706aaaa05f703fd284c4d6893658e49d  guix-build-683ae4c520b1/output/x86_64-apple-darwin/bitcoin-683ae4c520b1-x86_64-apple-darwin-unsigned.tar.gz
    8468931e8bcd43219615312831da01873cd8434b0f856ec77749a3824a246bf6  guix-build-683ae4c520b1/output/x86_64-apple-darwin/bitcoin-683ae4c520b1-x86_64-apple-darwin-unsigned.zip
    b429ed006ab3bc6639a3d0336f2ade117ecef102d2636246b0dc3e33d800309e  guix-build-683ae4c520b1/output/x86_64-linux-gnu/SHA256SUMS.part
    53a03b3b1f072fb2bc524059082ef8873ed45ee5514da7a5aad4c26e34f830d4  guix-build-683ae4c520b1/output/x86_64-linux-gnu/bitcoin-683ae4c520b1-x86_64-linux-gnu-debug.tar.gz
    f228ff9099aa4b4c8b1469f6211e323d04ad75b5182fd71b9edf583a7b33c07a  guix-build-683ae4c520b1/output/x86_64-linux-gnu/bitcoin-683ae4c520b1-x86_64-linux-gnu.tar.gz
    60d73b24ce766a73edd8f60340babe87182bd3695fdf580da975e589ca677d27  guix-build-683ae4c520b1/output/x86_64-w64-mingw32/SHA256SUMS.part
    1ea786507bda716d9c7b71a4ac2ff98cab4e5b3ec9430c1f3b1ab04e6c4e0538  guix-build-683ae4c520b1/output/x86_64-w64-mingw32/bitcoin-683ae4c520b1-win64-codesigning.tar.gz
    aa862b5c95e7c46bef7c46421232c19ff8a830c494b0f32b221dbe36f1bfd795  guix-build-683ae4c520b1/output/x86_64-w64-mingw32/bitcoin-683ae4c520b1-win64-debug.zip
    fc0f2b2ce4068f4384fd989553bb07dcb6af19e766dae85d7c5dbca6eb6c33a6  guix-build-683ae4c520b1/output/x86_64-w64-mingw32/bitcoin-683ae4c520b1-win64-setup-unsigned.exe
    a34889946c74f7ba6ad2e74946c8ee914417b440bb0427d460103c24b8738e6b  guix-build-683ae4c520b1/output/x86_64-w64-mingw32/bitcoin-683ae4c520b1-win64-unsigned.zip
    
  21. hebasto commented at 1:59 PM on July 29, 2026: member

    My Guix build:

    aarch64
    50bb780fae3da8e43ba12779305293d91b948527427077bc5af8dabb60def90a  guix-build-683ae4c520b1/output/aarch64-linux-gnu/SHA256SUMS.part
    09680fd7dda45acdb9db419d2d2ffacf26744b3a92bec5a15b0ae1ba1f172b87  guix-build-683ae4c520b1/output/aarch64-linux-gnu/bitcoin-683ae4c520b1-aarch64-linux-gnu-debug.tar.gz
    244100e7c377e0dd88c2b25d8940930c8a08a67f2b7d52a920a981af348fb769  guix-build-683ae4c520b1/output/aarch64-linux-gnu/bitcoin-683ae4c520b1-aarch64-linux-gnu.tar.gz
    1be2ec92c364a35637efa720d36b7c3e0435078791c867f9ad01db536c1a051d  guix-build-683ae4c520b1/output/arm-linux-gnueabihf/SHA256SUMS.part
    284127a045a02a17a862b404d5cd823b117daf188b531e248bb6c4b03bf010dc  guix-build-683ae4c520b1/output/arm-linux-gnueabihf/bitcoin-683ae4c520b1-arm-linux-gnueabihf-debug.tar.gz
    e072dbae3b3b58b448d6a721d5b9d64594630e2188a2573cbd61cc72d95f2787  guix-build-683ae4c520b1/output/arm-linux-gnueabihf/bitcoin-683ae4c520b1-arm-linux-gnueabihf.tar.gz
    8a01c59b4ba8f954584b099f26b51391d2cc271f1da79ebc703d4a1efdc13c7a  guix-build-683ae4c520b1/output/arm64-apple-darwin/SHA256SUMS.part
    63d8b3b5e45d23592a4d8bd4734d7548827e79f42cc5bdeaf1d44aeb06cdb9af  guix-build-683ae4c520b1/output/arm64-apple-darwin/bitcoin-683ae4c520b1-arm64-apple-darwin-codesigning.tar.gz
    903c3f350cbf51c07fece7ef446fc4bdb4ad30f1c91b8d1c529e854c03657ae7  guix-build-683ae4c520b1/output/arm64-apple-darwin/bitcoin-683ae4c520b1-arm64-apple-darwin-unsigned.tar.gz
    b0b9dabad568da668ffa598346c12b66b59750d5faf0c1358321ae18f3e3c5d5  guix-build-683ae4c520b1/output/arm64-apple-darwin/bitcoin-683ae4c520b1-arm64-apple-darwin-unsigned.zip
    1e4c79a6965bb836315bbb192b91d8886dbca5c8f4a3f1ac29c801fb6e1afb7d  guix-build-683ae4c520b1/output/dist-archive/bitcoin-683ae4c520b1.tar.gz
    680e49f65caa68999e15de85318cbd6dbdaca1fb7ee21025e48846b6b16d128e  guix-build-683ae4c520b1/output/powerpc64-linux-gnu/SHA256SUMS.part
    88eb13ecd5e6546c4a09f55f3aeab634fcace15211e65485518aca7f1282a74e  guix-build-683ae4c520b1/output/powerpc64-linux-gnu/bitcoin-683ae4c520b1-powerpc64-linux-gnu-debug.tar.gz
    1bbb242709d283b18decd1799ba6c772750025dd88d0ae67aaa6c01d9edfb006  guix-build-683ae4c520b1/output/powerpc64-linux-gnu/bitcoin-683ae4c520b1-powerpc64-linux-gnu.tar.gz
    0e66a841c776448f1ecca55e1ff60f6b84a2bb4410afe2aa22aa9a1d001fffdb  guix-build-683ae4c520b1/output/riscv64-linux-gnu/SHA256SUMS.part
    14a1a61bd58ba56b099364038f36bb9d392cfa5236635c9a142989f0be5f3610  guix-build-683ae4c520b1/output/riscv64-linux-gnu/bitcoin-683ae4c520b1-riscv64-linux-gnu-debug.tar.gz
    d105387edc9bbf247862f1e7fac59bd2f7546e6c8d57cd707983375e7e3abf73  guix-build-683ae4c520b1/output/riscv64-linux-gnu/bitcoin-683ae4c520b1-riscv64-linux-gnu.tar.gz
    f49ba29efedf394b654de486aae585fafa99aea94e404139432a25009215a00b  guix-build-683ae4c520b1/output/x86_64-apple-darwin/SHA256SUMS.part
    ff241a32caeb20eeb7a4da54fecd3b236909953314b75fcfa3c1a8f01628553a  guix-build-683ae4c520b1/output/x86_64-apple-darwin/bitcoin-683ae4c520b1-x86_64-apple-darwin-codesigning.tar.gz
    077bdc6c8777ae6f1266f33aad1003dc706aaaa05f703fd284c4d6893658e49d  guix-build-683ae4c520b1/output/x86_64-apple-darwin/bitcoin-683ae4c520b1-x86_64-apple-darwin-unsigned.tar.gz
    8468931e8bcd43219615312831da01873cd8434b0f856ec77749a3824a246bf6  guix-build-683ae4c520b1/output/x86_64-apple-darwin/bitcoin-683ae4c520b1-x86_64-apple-darwin-unsigned.zip
    b429ed006ab3bc6639a3d0336f2ade117ecef102d2636246b0dc3e33d800309e  guix-build-683ae4c520b1/output/x86_64-linux-gnu/SHA256SUMS.part
    53a03b3b1f072fb2bc524059082ef8873ed45ee5514da7a5aad4c26e34f830d4  guix-build-683ae4c520b1/output/x86_64-linux-gnu/bitcoin-683ae4c520b1-x86_64-linux-gnu-debug.tar.gz
    f228ff9099aa4b4c8b1469f6211e323d04ad75b5182fd71b9edf583a7b33c07a  guix-build-683ae4c520b1/output/x86_64-linux-gnu/bitcoin-683ae4c520b1-x86_64-linux-gnu.tar.gz
    60d73b24ce766a73edd8f60340babe87182bd3695fdf580da975e589ca677d27  guix-build-683ae4c520b1/output/x86_64-w64-mingw32/SHA256SUMS.part
    1ea786507bda716d9c7b71a4ac2ff98cab4e5b3ec9430c1f3b1ab04e6c4e0538  guix-build-683ae4c520b1/output/x86_64-w64-mingw32/bitcoin-683ae4c520b1-win64-codesigning.tar.gz
    aa862b5c95e7c46bef7c46421232c19ff8a830c494b0f32b221dbe36f1bfd795  guix-build-683ae4c520b1/output/x86_64-w64-mingw32/bitcoin-683ae4c520b1-win64-debug.zip
    fc0f2b2ce4068f4384fd989553bb07dcb6af19e766dae85d7c5dbca6eb6c33a6  guix-build-683ae4c520b1/output/x86_64-w64-mingw32/bitcoin-683ae4c520b1-win64-setup-unsigned.exe
    a34889946c74f7ba6ad2e74946c8ee914417b440bb0427d460103c24b8738e6b  guix-build-683ae4c520b1/output/x86_64-w64-mingw32/bitcoin-683ae4c520b1-win64-unsigned.zip
    
  22. hebasto merged this on Jul 29, 2026
  23. hebasto closed this on Jul 29, 2026

  24. fanquake deleted the branch on Jul 29, 2026
  25. rustaceanrob commented at 2:37 PM on July 29, 2026: member

    Post merge build:

    x86_64
    50bb780fae3da8e43ba12779305293d91b948527427077bc5af8dabb60def90a  guix-build-683ae4c520b1/output/aarch64-linux-gnu/SHA256SUMS.part
    09680fd7dda45acdb9db419d2d2ffacf26744b3a92bec5a15b0ae1ba1f172b87  guix-build-683ae4c520b1/output/aarch64-linux-gnu/bitcoin-683ae4c520b1-aarch64-linux-gnu-debug.tar.gz
    244100e7c377e0dd88c2b25d8940930c8a08a67f2b7d52a920a981af348fb769  guix-build-683ae4c520b1/output/aarch64-linux-gnu/bitcoin-683ae4c520b1-aarch64-linux-gnu.tar.gz
    1be2ec92c364a35637efa720d36b7c3e0435078791c867f9ad01db536c1a051d  guix-build-683ae4c520b1/output/arm-linux-gnueabihf/SHA256SUMS.part
    284127a045a02a17a862b404d5cd823b117daf188b531e248bb6c4b03bf010dc  guix-build-683ae4c520b1/output/arm-linux-gnueabihf/bitcoin-683ae4c520b1-arm-linux-gnueabihf-debug.tar.gz
    e072dbae3b3b58b448d6a721d5b9d64594630e2188a2573cbd61cc72d95f2787  guix-build-683ae4c520b1/output/arm-linux-gnueabihf/bitcoin-683ae4c520b1-arm-linux-gnueabihf.tar.gz
    8a01c59b4ba8f954584b099f26b51391d2cc271f1da79ebc703d4a1efdc13c7a  guix-build-683ae4c520b1/output/arm64-apple-darwin/SHA256SUMS.part
    63d8b3b5e45d23592a4d8bd4734d7548827e79f42cc5bdeaf1d44aeb06cdb9af  guix-build-683ae4c520b1/output/arm64-apple-darwin/bitcoin-683ae4c520b1-arm64-apple-darwin-codesigning.tar.gz
    903c3f350cbf51c07fece7ef446fc4bdb4ad30f1c91b8d1c529e854c03657ae7  guix-build-683ae4c520b1/output/arm64-apple-darwin/bitcoin-683ae4c520b1-arm64-apple-darwin-unsigned.tar.gz
    b0b9dabad568da668ffa598346c12b66b59750d5faf0c1358321ae18f3e3c5d5  guix-build-683ae4c520b1/output/arm64-apple-darwin/bitcoin-683ae4c520b1-arm64-apple-darwin-unsigned.zip
    1e4c79a6965bb836315bbb192b91d8886dbca5c8f4a3f1ac29c801fb6e1afb7d  guix-build-683ae4c520b1/output/dist-archive/bitcoin-683ae4c520b1.tar.gz
    680e49f65caa68999e15de85318cbd6dbdaca1fb7ee21025e48846b6b16d128e  guix-build-683ae4c520b1/output/powerpc64-linux-gnu/SHA256SUMS.part
    88eb13ecd5e6546c4a09f55f3aeab634fcace15211e65485518aca7f1282a74e  guix-build-683ae4c520b1/output/powerpc64-linux-gnu/bitcoin-683ae4c520b1-powerpc64-linux-gnu-debug.tar.gz
    1bbb242709d283b18decd1799ba6c772750025dd88d0ae67aaa6c01d9edfb006  guix-build-683ae4c520b1/output/powerpc64-linux-gnu/bitcoin-683ae4c520b1-powerpc64-linux-gnu.tar.gz
    0e66a841c776448f1ecca55e1ff60f6b84a2bb4410afe2aa22aa9a1d001fffdb  guix-build-683ae4c520b1/output/riscv64-linux-gnu/SHA256SUMS.part
    14a1a61bd58ba56b099364038f36bb9d392cfa5236635c9a142989f0be5f3610  guix-build-683ae4c520b1/output/riscv64-linux-gnu/bitcoin-683ae4c520b1-riscv64-linux-gnu-debug.tar.gz
    d105387edc9bbf247862f1e7fac59bd2f7546e6c8d57cd707983375e7e3abf73  guix-build-683ae4c520b1/output/riscv64-linux-gnu/bitcoin-683ae4c520b1-riscv64-linux-gnu.tar.gz
    f49ba29efedf394b654de486aae585fafa99aea94e404139432a25009215a00b  guix-build-683ae4c520b1/output/x86_64-apple-darwin/SHA256SUMS.part
    ff241a32caeb20eeb7a4da54fecd3b236909953314b75fcfa3c1a8f01628553a  guix-build-683ae4c520b1/output/x86_64-apple-darwin/bitcoin-683ae4c520b1-x86_64-apple-darwin-codesigning.tar.gz
    077bdc6c8777ae6f1266f33aad1003dc706aaaa05f703fd284c4d6893658e49d  guix-build-683ae4c520b1/output/x86_64-apple-darwin/bitcoin-683ae4c520b1-x86_64-apple-darwin-unsigned.tar.gz
    8468931e8bcd43219615312831da01873cd8434b0f856ec77749a3824a246bf6  guix-build-683ae4c520b1/output/x86_64-apple-darwin/bitcoin-683ae4c520b1-x86_64-apple-darwin-unsigned.zip
    b429ed006ab3bc6639a3d0336f2ade117ecef102d2636246b0dc3e33d800309e  guix-build-683ae4c520b1/output/x86_64-linux-gnu/SHA256SUMS.part
    53a03b3b1f072fb2bc524059082ef8873ed45ee5514da7a5aad4c26e34f830d4  guix-build-683ae4c520b1/output/x86_64-linux-gnu/bitcoin-683ae4c520b1-x86_64-linux-gnu-debug.tar.gz
    f228ff9099aa4b4c8b1469f6211e323d04ad75b5182fd71b9edf583a7b33c07a  guix-build-683ae4c520b1/output/x86_64-linux-gnu/bitcoin-683ae4c520b1-x86_64-linux-gnu.tar.gz
    60d73b24ce766a73edd8f60340babe87182bd3695fdf580da975e589ca677d27  guix-build-683ae4c520b1/output/x86_64-w64-mingw32/SHA256SUMS.part
    1ea786507bda716d9c7b71a4ac2ff98cab4e5b3ec9430c1f3b1ab04e6c4e0538  guix-build-683ae4c520b1/output/x86_64-w64-mingw32/bitcoin-683ae4c520b1-win64-codesigning.tar.gz
    aa862b5c95e7c46bef7c46421232c19ff8a830c494b0f32b221dbe36f1bfd795  guix-build-683ae4c520b1/output/x86_64-w64-mingw32/bitcoin-683ae4c520b1-win64-debug.zip
    fc0f2b2ce4068f4384fd989553bb07dcb6af19e766dae85d7c5dbca6eb6c33a6  guix-build-683ae4c520b1/output/x86_64-w64-mingw32/bitcoin-683ae4c520b1-win64-setup-unsigned.exe
    a34889946c74f7ba6ad2e74946c8ee914417b440bb0427d460103c24b8738e6b  guix-build-683ae4c520b1/output/x86_64-w64-mingw32/bitcoin-683ae4c520b1-win64-unsigned.zip
    

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-07-31 20:50 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me