This is a follow-up to bitcoin/bitcoin#35221. The MakeAndPushFeature member function template has no callers yet, which triggers -Wunused-template now that Clang 23 enables it as part of -Wall.
Related PRs:
refactor: Annotate `MakeAndPushFeature` with `[[maybe_unused]]` #35871
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:260803-unused-mapf changing 1 files +1 −1-
hebasto commented at 4:22 PM on August 3, 2026: member
-
0238aebf61
refactor: Annotate `MakeAndPushFeature` with `[[maybe_unused]]`
This is a follow-up to bitcoin/bitcoin#35221. The `MakeAndPushFeature` member function template has no callers yet, which triggers `-Wunused-template` now that Clang 23 enables it as part of `-Wall`.
- hebasto added the label Refactoring on Aug 3, 2026
-
DrahtBot commented at 4:22 PM on August 3, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35871.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process.
Type Reviewers ACK maflcko If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
maflcko commented at 4:30 PM on August 3, 2026: member
lgtm ACK 0238aebf619013a761c06ad3c57a56ee50f4541c
-
l0rinc commented at 6:05 PM on August 3, 2026: contributor
Why not remove it with the commented out call instead? We don't usually leave commented and unused code lingering around ... https://github.com/bitcoin/bitcoin/blob/b33a7fcd7bd896da7175a28802bac9ca53fa238d/src/net_processing.cpp#L3972
-
hebasto commented at 6:19 PM on August 3, 2026: member
Why not remove it with the commented out call instead? We don't usually leave commented and unused code lingering around ... https://github.com/bitcoin/bitcoin/blob/b33a7fcd7bd896da7175a28802bac9ca53fa238d/src/net_processing.cpp#L3972
cc @ajtowns
