doc: use overwrite (>) instead of append (>>) for one-shot PSBT files in offline-signing-tutorial.md #35890

pull GuTS805 wants to merge 1 commits into bitcoin:master from GuTS805:fix-offline-signing-tutorial-append changing 1 files +2 −2
  1. GuTS805 commented at 3:13 AM on August 5, 2026: contributor

    funded_psbt.txt and final_psbt.txt should only ever have one line in them, since later steps just do $(cat ...) to read them back. but the tutorial uses >> (append) instead of > (overwrite), so if you run the send or walletprocesspsbt step twice without deleting the file, it adds a second line instead of replacing the first one. then $(cat ...) picks up both lines as separate args and the next command fails with too many arguments.

    Fixes #35862.

  2. doc: use overwrite (>) instead of append (>>) for one-shot PSBT files in offline-signing-tutorial.md
    funded_psbt.txt and final_psbt.txt are each expected to hold exactly one
    PSBT/hex string, consumed via unquoted $(cat ...) in every later step. Using
    append (>>) instead of overwrite (>) means re-running the send or
    walletprocesspsbt step without deleting the output file first appends a
    second line, which $(cat ...) then word-splits into two arguments, causing
    decodepsbt/analyzepsbt/walletprocesspsbt/sendrawtransaction to reject the
    call with too many arguments.
    
    Fixes #35862.
    be30864ed1
  3. DrahtBot added the label Docs on Aug 5, 2026
  4. DrahtBot commented at 3:13 AM on August 5, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35890.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK Sjors, sedited

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. maflcko added the label Wallet on Aug 5, 2026
  6. davidgumberg commented at 12:05 AM on August 12, 2026: contributor

    This PR description and the issue it's linked to were both clearly generated by an LLM. Even if the issue is real and the change here is correct, you need to write your own description.

    Please read the AI Policy

  7. GuTS805 commented at 12:22 AM on August 12, 2026: contributor

    oh sorry i did not intended to do it like this. I will edit the description in my own words.

  8. GuTS805 commented at 12:38 AM on August 12, 2026: contributor

    @davidgumberg i have read ai policy. And rewrite the issue and description in my own words. Can you review it again.

  9. sedited requested review from Sjors on Sep 23, 2026
  10. Sjors commented at 9:44 AM on September 24, 2026: member

    ACK be30864ed1a63cad0e109ebc98fe17bd852bc8d0

    I had my agent follow the tutorial. Using > instead of >> makes sense; people might try a command twice.

  11. sedited approved
  12. sedited commented at 11:20 AM on September 24, 2026: contributor

    ACK be30864ed1a63cad0e109ebc98fe17bd852bc8d0

  13. sedited merged this on Sep 24, 2026
  14. sedited closed this on Sep 24, 2026

  15. GuTS805 deleted the branch on Sep 25, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-10-11 10:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me