test, fuzz: Remove unused variables #35914

pull hebasto wants to merge 8 commits into bitcoin:master from hebasto:260806-unused changing 8 files +1 −13

hebasto commented at 11:53 AM on August 6, 2026: member

Noted in https://my.cdash.org/builds/3868446/build.

See commit messages for more details.

Here is a related upstream change: https://github.com/llvm/llvm-project/pull/203084.

test, refactor: Remove unused `warnings` in `wallet/test/util.cpp`

These have been unused since the following commits:
 - c61d3f02f5122b38ea8bf0029aa9dfbbf38e10d0
 - e12ff8aca049ec7b054cb3047a167c7ce8dbd421

da58e55986

fuzz, refactor: Remove unused `linearization` in `cluster_linearize.cpp`
This has been unused since a52b53926b5c6a5b92255435e3c204cdf18665a2.
fc28914de4
fuzz, refactor: Remove unused `random_string` in `locale.cpp`
This has been unused since 33332829333b589420f8038541d04ec6970f051d.
3df0d067ad
fuzz, refactor: Remove unused `header` in `p2p_transport_serialization.cpp`
This has been unused since 0de48fe858a1ffcced340eef2c849165216141c8.
b7ae50e2e2

test, refactor: Remove unused variables in `test/rbf_tests.cpp`

These have been unused since the following commits:
 - c320cddb1b57a9c9911054fc440f7a12aaea61b5
 - e9c5aeb11d641b8cae373452339760809625021d
 - 216e6937290338950215795291dbf0a533e234cf

e50f422d25

hebasto added the label Refactoring on Aug 6, 2026
hebasto added the label Tests on Aug 6, 2026
hebasto added the label Fuzzing on Aug 6, 2026
DrahtBot commented at 11:53 AM on August 6, 2026: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35914.



Reviews

See the guideline and AI policy for information on the review process.

Type Reviewers

ACK maflcko

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.

Type	Reviewers
ACK	maflcko

in src/test/txgraph_tests.cpp:293 in d56ef831fe

 289 | @@ -290,7 +290,7 @@ BOOST_AUTO_TEST_CASE(txgraph_trim_big_singletons)
 290 |      BOOST_CHECK(graph->IsOversized(TxGraph::Level::TOP));
 291 |  
 292 |      // Call Trim() to remove transactions and bring the cluster back within limits.
 293 | -    auto removed_refs = graph->Trim();
 294 | +    [[maybe_unused]] auto removed_refs = graph->Trim();

fanquake commented at 12:41 PM on August 6, 2026:

Just remove the unused code?

ajtowns commented at 1:13 PM on August 6, 2026:

graph->Trim() shouldn't be removed?

I guess it's not marked [[nodiscard]] so could just be graph->Trim(); or otherwise (void)graph->Trim();

hebasto commented at 1:18 PM on August 6, 2026:

Thanks! Reworked.

hebasto renamed this:
~~test, fuzz: Remove and annotate unused variables.~~
test, fuzz: Remove and annotate unused variables
on Aug 6, 2026

test, refactor: Remove unused `removed_refs` in `txgraph_tests.cpp`

This has been unused since it was introduced in
938e86f8fecd65ca90b97e6cf896f8c59fb590ba.

e550945a39

test, refactor: Remove unused `utxo_pool` in `coinselector_tests.cpp`
This has been unused since d610951c154663053a0e39a850dffd96f808581b.
422f1bd92f
test, refactor: Remove unused `error` in `wallet_tests.cpp`
This has been unused since 3b98bf9c43ece060d57d7ae31624d4a8220de266.
3175d57628
hebasto force-pushed on Aug 6, 2026
hebasto renamed this:
~~test, fuzz: Remove and annotate unused variables~~
test, fuzz: Remove unused variables
on Aug 6, 2026

maflcko commented at 7:42 AM on August 7, 2026: member

review ACK 3175d576288f3118c6fee0d9f7cb57f976c52346 🐕

<details><summary>Show signature</summary>

Signature:

untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: review ACK 3175d576288f3118c6fee0d9f7cb57f976c52346 🐕
xx4UR3jViD8d+kcfVvqHCK9jsfUTYuzAeLKIHbmW3eF129y6dqlPkp332agTVjYq5wQnATdJJj5Ese7jojDsBA==

</details>

fanquake merged this on Aug 7, 2026
fanquake closed this on Aug 7, 2026
hebasto deleted the branch on Aug 7, 2026

Contributors

Labels

Refactoring Tests Fuzzing

test, fuzz: Remove unused variables #35914

Code Coverage & Benchmarks

Reviews