guix, depends: Drop `GUIX_ENVIRONMENT` from `gen

hebasto commented at 1:22 PM on August 7, 2026: member

This PR fixes a performance regression noticed during the review of #35537.

Since commit 008a3e29c8844c0be4457279f5c27c1bc57401c7 ("guix: split builds into Linux(gui) and macOS/Windows"), each host is built in two containers: one instantiated from manifest_build.scm and the other from the union of manifest_build.scm and manifest_gui.scm. The resulting Guix profiles necessarily differ, and because $(realpath $(GUIX_ENVIRONMENT)) is hashed into every depends package id, the built-package cache is invalidated whenever the profile changes:

Depends are rebuilt when switching to another branch with identical Guix scripts and the depends subdirectory.
All non-GUI packages are built twice per host, as the GUI container cannot reuse the packages just cached by the base container (this is mostly relevant for non-Linux hosts, as we move towards static builds on Linux).

Drop GUIX_ENVIRONMENT from the gen_id inputs, and salt the depends ids in guix-build with the inputs that define the containers instead: the pinned time-machine commit, the contents of manifest_build.scm, manifest_gui.scm and of every patch in contrib/guix/patches, and the user-supplied ADDITIONAL_GUIX_*_FLAGS.

Unlike the profile path, this salt is identical for both containers of a given host, so the GUI container reuses the packages built by the base container, and it stays stable across branches whose Guix and depends inputs are unchanged, while any change to the pinned Guix revision, to the manifests, or to the patches still invalidates the cache.

Related: #34228.

hebasto added the label Build system on Aug 7, 2026

DrahtBot commented at 1:22 PM on August 7, 2026: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35929.

Reviews

See the guideline and AI policy for information on the review process.

Type	Reviewers
Stale ACK	willcl-ark

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#36082 (ci: add Guix builds to CI by willcl-ark)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

hebasto added this to the milestone 32.0 on Aug 7, 2026

willcl-ark commented at 8:26 AM on August 18, 2026: member

Will this still work if/when we move to static linux builds?

At that point we might have different compiler/libc targets, so we might still prefer them distictly split as https://github.com/bitcoin/bitcoin/pull/36006/changes/ad0ee317e394f72740307821553cb827c530e5a0

ad0ee317 does not solve the build twice "issue" which you try to address here though.

fanquake commented at 8:32 AM on August 18, 2026: member

I think the PR description needs to be updated to clarify that this is only a "regression" for macOS/Windows builds. The point of #35537 was to split the Linux builds, and they wont be re-usable going forward.

hebasto commented at 2:36 PM on August 24, 2026: member

I think the PR description needs to be updated to clarify that this is only a "regression" for macOS/Windows builds. The point of #35537 was to split the Linux builds, and they wont be re-usable going forward.

The PR description has been updated.

Rebuilding packages in depends when switching branches is still a regression, even for Linux hosts. This affects all Guix builders, similar to the issue resolved in #34228.

Will this still work if/when we move to static linux builds?

Yes. For the case I mentioned above.

UPDATE: Please see my revised response here.

hebasto force-pushed on Aug 28, 2026

hebasto commented at 8:49 AM on August 28, 2026: member

Rebased on top of the recent changes in the depends build subsystem.

hebasto commented at 11:06 AM on August 28, 2026: member

@willcl-ark

Will this still work if/when we move to static linux builds?

At that point we might have different compiler/libc targets, so we might still prefer them distictly split as ad0ee31

ad0ee31 does not solve the build twice "issue" which you try to address here though.

For static builds, this approach won't cache non-native non-GUI packages properly. However, that can be mitigated with a single-line change, which follows your idea of separate caches:

--- a/contrib/guix/libexec/build_linux_gui.sh
+++ b/contrib/guix/libexec/build_linux_gui.sh
@@ -15,7 +15,7 @@ gcc_toolchain
 make -C depends --jobs="$JOBS" HOST="$HOST" \
                                    ${V:+V=1} \
                                    ${SOURCES_PATH+SOURCES_PATH="$SOURCES_PATH"} \
-                                   ${BASE_CACHE+BASE_CACHE="$BASE_CACHE"} \
+                                   BASE_CACHE="${BASE_CACHE:-$PWD/depends/built}/gui" \
                                    ${build_CC+build_CC="$build_CC"} \
                                    ${build_CXX+build_CXX="$build_CXX"}

willcl-ark approved

willcl-ark commented at 12:29 PM on August 28, 2026: member

tACK 2e605da1a653100a0cedc75dde79896918a22761

Manually tested changing GUIX_ENVIRONMENT here and on master:

bitcoin/worktrees/pr-35929 on  pr-35929 [$] via △ v4.3.4 via 🐍 v3.14.7 via ❄️  impure (nix-shell-env)
❯ GUIX_ENVIRONMENT=/tmp make -C depends --no-print-directory print-build_id
build_id=fb8808cf406fe741121401c6dca25037e1dfdccf9e6a5094ab3ec3b2e9745f39

bitcoin/worktrees/pr-35929 on  pr-35929 [$] via △ v4.3.4 via 🐍 v3.14.7 via ❄️  impure (nix-shell-env) took 6s
❯ GUIX_ENVIRONMENT=/var make -C depends --no-print-directory print-build_id
build_id=fb8808cf406fe741121401c6dca25037e1dfdccf9e6a5094ab3ec3b2e9745f39

bitcoin/worktrees/pr-35929 on  pr-35929 [$] via △ v4.3.4 via 🐍 v3.14.7 via ❄️  impure (nix-shell-env) took 2s
❯ cd bitcoin

core/bitcoin/bitcoin on  master [$?⇕] via △ v4.3.4 via 🐍 v3.14.7 via ❄️  impure (nix-shell-env)
❯ GUIX_ENVIRONMENT=/tmp make -C depends --no-print-directory print-build_id
build_id=055db281a936a1f3617749173a3dfda529852292674e1dd4a0547c09322ad102

core/bitcoin/bitcoin on  master [$?⇕] via △ v4.3.4 via 🐍 v3.14.7 via ❄️  impure (nix-shell-env) took 3s
❯ GUIX_ENVIRONMENT=/var make -C depends --no-print-directory print-build_id
build_id=ea52a88298f7ff28b6d45e44486d1577de149afdabb276263eb08d9d7fec795d

willcl-ark commented at 4:12 PM on August 28, 2026: member

Guix build for good measure:

x86_64
52a27582606827acad30bedaeb64d81125e2f069ae97c8fc15b1679bb5463b91  guix-build-2e605da1a653/output/aarch64-linux-gnu/SHA256SUMS.part
3106d8d7abc7704df689bbd4b553d41e39f647af2c74688e620393832cf6d795  guix-build-2e605da1a653/output/aarch64-linux-gnu/bitcoin-2e605da1a653-aarch64-linux-gnu-debug.tar.gz
6b4147e8ba221bcc4f4d3ccdba3e597bc6220edc2db98198113ed2f7193e4153  guix-build-2e605da1a653/output/aarch64-linux-gnu/bitcoin-2e605da1a653-aarch64-linux-gnu.tar.gz
0ff2536a4eccca3a892cdc064f0b82d389add0862ebf5b59d84455bf2c3b10e1  guix-build-2e605da1a653/output/arm-linux-gnueabihf/SHA256SUMS.part
2c44c5e8e03e25243584683ef84e95f63ea623340ec49ae7284dd052cf0fe9a9  guix-build-2e605da1a653/output/arm-linux-gnueabihf/bitcoin-2e605da1a653-arm-linux-gnueabihf-debug.tar.gz
d3450a74ff1bd60a6399c1a4a64fbbe77c2cb7513c1665b6df0152c8957d2e5e  guix-build-2e605da1a653/output/arm-linux-gnueabihf/bitcoin-2e605da1a653-arm-linux-gnueabihf.tar.gz
5155416ed81d9b75d8691ccdf5a7e817832b4eb9d2403e819830dd27f195dd1c  guix-build-2e605da1a653/output/arm64-apple-darwin/SHA256SUMS.part
9622f3054edb5ef4b055259400ee612aa34d4d0250b19b0e0b00285f6d2967e9  guix-build-2e605da1a653/output/arm64-apple-darwin/bitcoin-2e605da1a653-arm64-apple-darwin-codesigning.tar.gz
52114da05c6355f033b1000c6a34bb8091dcdc97444104f97c101fd304f469d4  guix-build-2e605da1a653/output/arm64-apple-darwin/bitcoin-2e605da1a653-arm64-apple-darwin-unsigned.tar.gz
27e2d133aaf7c62f557f94416557f084f37882a24d9c92ed9527125b6fd44b99  guix-build-2e605da1a653/output/arm64-apple-darwin/bitcoin-2e605da1a653-arm64-apple-darwin-unsigned.zip
3041d76bba1f83000e72f1b5bc35f773bb5ce47b858a71ed6028676f92ad9a24  guix-build-2e605da1a653/output/dist-archive/bitcoin-2e605da1a653.tar.gz
24735eaa4cf8222da930eba23af74b4cac8607cccce4fdf424221468ec4a0b31  guix-build-2e605da1a653/output/powerpc64-linux-gnu/SHA256SUMS.part
2059aeebda7c74eaa85e890a97123b7d7cbf064f9fd923af570051cca686ee0b  guix-build-2e605da1a653/output/powerpc64-linux-gnu/bitcoin-2e605da1a653-powerpc64-linux-gnu-debug.tar.gz
04745d8bde8772d274df6cb50dc14471647d296ef5d9873cdb4cc40dc03095c9  guix-build-2e605da1a653/output/powerpc64-linux-gnu/bitcoin-2e605da1a653-powerpc64-linux-gnu.tar.gz
c0500744d4f4619cfdf84af1b45c10e7dbd3d4a2b4d93d614f379241f1f31403  guix-build-2e605da1a653/output/riscv64-linux-gnu/SHA256SUMS.part
7e21b0b07032a2f6e9f7f2e684f8264521bec879f653d54cb3bdb11ac7a95357  guix-build-2e605da1a653/output/riscv64-linux-gnu/bitcoin-2e605da1a653-riscv64-linux-gnu-debug.tar.gz
e14e20b43a11fb04028d252a7f4d09add5bec5a9cd4d4e0caaae4429924dc0b2  guix-build-2e605da1a653/output/riscv64-linux-gnu/bitcoin-2e605da1a653-riscv64-linux-gnu.tar.gz
17d0070b7497a52d0e8148933f3cc69940aaf8c601e07289493241d7ccf224f3  guix-build-2e605da1a653/output/x86_64-apple-darwin/SHA256SUMS.part
dc92119f5929e81cdb14d3fc012baa64b6a6bde154a2ea82755ac83dbd2b9c53  guix-build-2e605da1a653/output/x86_64-apple-darwin/bitcoin-2e605da1a653-x86_64-apple-darwin-codesigning.tar.gz
3a6859dac6131988f9163165b0c6a5b82b09f20532199498924ed7482982def3  guix-build-2e605da1a653/output/x86_64-apple-darwin/bitcoin-2e605da1a653-x86_64-apple-darwin-unsigned.tar.gz
a9019c9d837d6e27593230602e216101db83e1b210edf9ea46063c85cc7c07cd  guix-build-2e605da1a653/output/x86_64-apple-darwin/bitcoin-2e605da1a653-x86_64-apple-darwin-unsigned.zip
ba136010df1fc24d5c40ce77b7c2f6b1c6a522f056c0df0a183877e427261be6  guix-build-2e605da1a653/output/x86_64-linux-gnu/SHA256SUMS.part
e2e31b7c3087c009626c4dd90426f290e3add2767348c87e012db224c6a8ac97  guix-build-2e605da1a653/output/x86_64-linux-gnu/bitcoin-2e605da1a653-x86_64-linux-gnu-debug.tar.gz
133cf528ba9923facad4d375b7079e09cd69fd63d7730568a481ce3319b6d818  guix-build-2e605da1a653/output/x86_64-linux-gnu/bitcoin-2e605da1a653-x86_64-linux-gnu.tar.gz
922b967eb4df77bbdd0bb8bf3a14a189686209885ec8d764715925c80af2c935  guix-build-2e605da1a653/output/x86_64-w64-mingw32/SHA256SUMS.part
2aee52621f2f5422b684d355039b5223cb7d92993e4ef0638b61b7e52b593643  guix-build-2e605da1a653/output/x86_64-w64-mingw32/bitcoin-2e605da1a653-win64-codesigning.tar.gz
92a488ad32aaaf8b81d4d59fb47ce3428303cf14029dc9ec0ab4e88a397f98ab  guix-build-2e605da1a653/output/x86_64-w64-mingw32/bitcoin-2e605da1a653-win64-debug.zip
aa04ba875eaef202a5dc4b1f50b996a770c8b9e670b3db4ba6214be38afc76a1  guix-build-2e605da1a653/output/x86_64-w64-mingw32/bitcoin-2e605da1a653-win64-setup-unsigned.exe
519357dd2b0103d495da0d7bd7817e6bc286f8de6a9dc78fd372e282a7000a63  guix-build-2e605da1a653/output/x86_64-w64-mingw32/bitcoin-2e605da1a653-win64-unsigned.zip

hebasto commented at 10:03 AM on August 29, 2026: member

My Guix build:

$ uname -m && find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
aarch64
52a27582606827acad30bedaeb64d81125e2f069ae97c8fc15b1679bb5463b91  guix-build-2e605da1a653/output/aarch64-linux-gnu/SHA256SUMS.part
3106d8d7abc7704df689bbd4b553d41e39f647af2c74688e620393832cf6d795  guix-build-2e605da1a653/output/aarch64-linux-gnu/bitcoin-2e605da1a653-aarch64-linux-gnu-debug.tar.gz
6b4147e8ba221bcc4f4d3ccdba3e597bc6220edc2db98198113ed2f7193e4153  guix-build-2e605da1a653/output/aarch64-linux-gnu/bitcoin-2e605da1a653-aarch64-linux-gnu.tar.gz
0ff2536a4eccca3a892cdc064f0b82d389add0862ebf5b59d84455bf2c3b10e1  guix-build-2e605da1a653/output/arm-linux-gnueabihf/SHA256SUMS.part
2c44c5e8e03e25243584683ef84e95f63ea623340ec49ae7284dd052cf0fe9a9  guix-build-2e605da1a653/output/arm-linux-gnueabihf/bitcoin-2e605da1a653-arm-linux-gnueabihf-debug.tar.gz
d3450a74ff1bd60a6399c1a4a64fbbe77c2cb7513c1665b6df0152c8957d2e5e  guix-build-2e605da1a653/output/arm-linux-gnueabihf/bitcoin-2e605da1a653-arm-linux-gnueabihf.tar.gz
5155416ed81d9b75d8691ccdf5a7e817832b4eb9d2403e819830dd27f195dd1c  guix-build-2e605da1a653/output/arm64-apple-darwin/SHA256SUMS.part
9622f3054edb5ef4b055259400ee612aa34d4d0250b19b0e0b00285f6d2967e9  guix-build-2e605da1a653/output/arm64-apple-darwin/bitcoin-2e605da1a653-arm64-apple-darwin-codesigning.tar.gz
52114da05c6355f033b1000c6a34bb8091dcdc97444104f97c101fd304f469d4  guix-build-2e605da1a653/output/arm64-apple-darwin/bitcoin-2e605da1a653-arm64-apple-darwin-unsigned.tar.gz
27e2d133aaf7c62f557f94416557f084f37882a24d9c92ed9527125b6fd44b99  guix-build-2e605da1a653/output/arm64-apple-darwin/bitcoin-2e605da1a653-arm64-apple-darwin-unsigned.zip
3041d76bba1f83000e72f1b5bc35f773bb5ce47b858a71ed6028676f92ad9a24  guix-build-2e605da1a653/output/dist-archive/bitcoin-2e605da1a653.tar.gz
24735eaa4cf8222da930eba23af74b4cac8607cccce4fdf424221468ec4a0b31  guix-build-2e605da1a653/output/powerpc64-linux-gnu/SHA256SUMS.part
2059aeebda7c74eaa85e890a97123b7d7cbf064f9fd923af570051cca686ee0b  guix-build-2e605da1a653/output/powerpc64-linux-gnu/bitcoin-2e605da1a653-powerpc64-linux-gnu-debug.tar.gz
04745d8bde8772d274df6cb50dc14471647d296ef5d9873cdb4cc40dc03095c9  guix-build-2e605da1a653/output/powerpc64-linux-gnu/bitcoin-2e605da1a653-powerpc64-linux-gnu.tar.gz
c0500744d4f4619cfdf84af1b45c10e7dbd3d4a2b4d93d614f379241f1f31403  guix-build-2e605da1a653/output/riscv64-linux-gnu/SHA256SUMS.part
7e21b0b07032a2f6e9f7f2e684f8264521bec879f653d54cb3bdb11ac7a95357  guix-build-2e605da1a653/output/riscv64-linux-gnu/bitcoin-2e605da1a653-riscv64-linux-gnu-debug.tar.gz
e14e20b43a11fb04028d252a7f4d09add5bec5a9cd4d4e0caaae4429924dc0b2  guix-build-2e605da1a653/output/riscv64-linux-gnu/bitcoin-2e605da1a653-riscv64-linux-gnu.tar.gz
17d0070b7497a52d0e8148933f3cc69940aaf8c601e07289493241d7ccf224f3  guix-build-2e605da1a653/output/x86_64-apple-darwin/SHA256SUMS.part
dc92119f5929e81cdb14d3fc012baa64b6a6bde154a2ea82755ac83dbd2b9c53  guix-build-2e605da1a653/output/x86_64-apple-darwin/bitcoin-2e605da1a653-x86_64-apple-darwin-codesigning.tar.gz
3a6859dac6131988f9163165b0c6a5b82b09f20532199498924ed7482982def3  guix-build-2e605da1a653/output/x86_64-apple-darwin/bitcoin-2e605da1a653-x86_64-apple-darwin-unsigned.tar.gz
a9019c9d837d6e27593230602e216101db83e1b210edf9ea46063c85cc7c07cd  guix-build-2e605da1a653/output/x86_64-apple-darwin/bitcoin-2e605da1a653-x86_64-apple-darwin-unsigned.zip
ba136010df1fc24d5c40ce77b7c2f6b1c6a522f056c0df0a183877e427261be6  guix-build-2e605da1a653/output/x86_64-linux-gnu/SHA256SUMS.part
e2e31b7c3087c009626c4dd90426f290e3add2767348c87e012db224c6a8ac97  guix-build-2e605da1a653/output/x86_64-linux-gnu/bitcoin-2e605da1a653-x86_64-linux-gnu-debug.tar.gz
133cf528ba9923facad4d375b7079e09cd69fd63d7730568a481ce3319b6d818  guix-build-2e605da1a653/output/x86_64-linux-gnu/bitcoin-2e605da1a653-x86_64-linux-gnu.tar.gz
922b967eb4df77bbdd0bb8bf3a14a189686209885ec8d764715925c80af2c935  guix-build-2e605da1a653/output/x86_64-w64-mingw32/SHA256SUMS.part
2aee52621f2f5422b684d355039b5223cb7d92993e4ef0638b61b7e52b593643  guix-build-2e605da1a653/output/x86_64-w64-mingw32/bitcoin-2e605da1a653-win64-codesigning.tar.gz
92a488ad32aaaf8b81d4d59fb47ce3428303cf14029dc9ec0ab4e88a397f98ab  guix-build-2e605da1a653/output/x86_64-w64-mingw32/bitcoin-2e605da1a653-win64-debug.zip
aa04ba875eaef202a5dc4b1f50b996a770c8b9e670b3db4ba6214be38afc76a1  guix-build-2e605da1a653/output/x86_64-w64-mingw32/bitcoin-2e605da1a653-win64-setup-unsigned.exe
519357dd2b0103d495da0d7bd7817e6bc286f8de6a9dc78fd372e282a7000a63  guix-build-2e605da1a653/output/x86_64-w64-mingw32/bitcoin-2e605da1a653-win64-unsigned.zip

fanquake commented at 10:00 AM on September 3, 2026: member

The toolchain remains fully accounted for: the verbose compiler output hashed by gen_id embeds the store paths of the toolchain packages themselves, so any change to the toolchain still invalidates the cache.

I can't quite convince myself that this is correct. How does this hold for a package like tar, or coreutils? i.e the time-machine is updated and one of those packages is bumped (but no others)? What if we change our manifest, i.e switch from cmake-minimal (3.x) to cmake-minimal-4? These both seems like times you'd want to bust the depends cache, but I don't think that would happen after your change here, which could lead to non-determinism (across builders).

I think we do actually want the full Guix environment passed into the ID generation, because it's non-trivial to list all things in the environment that could affect the build, and it seems easier to just pass in the env, rather than try and enumerate them all in the ID generation (although maybe we should add a few more entries/tools there in any case, for general depends usage).

willcl-ark commented at 11:00 AM on September 3, 2026: member

Hmmm, I think I agree that gen_id isn't accounting for enough and, if we try to make it do so, we are just re-inventing a more-brittle GUIX_ENVIRONMENT...

Perhaps simpler to go with a more "dumb" method like https://github.com/bitcoin/bitcoin/commit/efbb91102107dd9e758c46b9cd51d7a1de28c38a and accept that we may build some parts of depends twice, in the name of reproducibility!

fanquake commented at 11:08 AM on September 3, 2026: member

What if we change our manifest, i.e switch from cmake-minimal (3.x) to cmake-minimal-4?

I tested this scenario by taking this PR, rebasing it on master, and adding a commit to bump the time-machine to guix master (so we have cmake-minimal & cmake-minimal-4 available). I then did a build for x86_64-linux-gnu. I then added a new commit editing our manifest, to change cmake-minimal to cmake-minimal-4 and started another build. Depends was not rebuilt.

guix: expose time-machine metadata

Make the pinned repository and commit available to callers that source the
Guix prelude.

A Bitcoin Core-specific substitute server only needs to build the
packages in the guix closure at a specific time machine commit. It does
not need to build the bitcoin core binary applications.

To facilitate extracting the time-machine commit, export it as a
variable, so substitute builders (and anybody else) can re-use it by
sourcing the prelude, instead of requiring error-prone command string parsing.

9c8f1a4a16

hebasto force-pushed on Sep 4, 2026

DrahtBot added the label CI failed on Sep 4, 2026

DrahtBot commented at 11:06 AM on September 4, 2026: contributor

🚧 At least one of the CI tasks failed. <sub>Task lint: https://github.com/bitcoin/bitcoin/actions/runs/33865048546/job/100997886260</sub> <sub>LLM reason (✨ experimental): CI failed because lint-shell.py reported a ShellCheck issue (SC2046: missing quotes around $(find contrib/guix/patches -type f | sort) in contrib/guix/guix-build).</sub>

<details><summary>Hints</summary>

Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.
A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.
An intermittent issue.

Leave a comment here, if you need help tracking down a confusing failure.

</details>

hebasto force-pushed on Sep 4, 2026

hebasto commented at 11:39 AM on September 4, 2026: member

@willcl-ark @fanquake

Thank you for the review! Your feedback has been addressed.

The first commit is borrowed from #36082, with a minor variable name adjustment to align with ADDITIONAL_GUIX_TIMEMACHINE_FLAGS.

DrahtBot removed the label CI failed on Sep 4, 2026

hebasto commented at 4:07 PM on September 4, 2026: member

My Guix build:

$ uname -m && find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
x86_64
5285c602b94b5345be396fadd8d3791829948e48dd8e44880650c7cb40692828  guix-build-d4d09e4eb066/output/aarch64-linux-gnu/SHA256SUMS.part
14bd26d72ec670e6a428cecf852a64f20e41238ff5a863f8e6167cfd8d38c6e4  guix-build-d4d09e4eb066/output/aarch64-linux-gnu/bitcoin-d4d09e4eb066-aarch64-linux-gnu-debug.tar.gz
0fe1a4f682d627480c13cecbd9176931f0e91f2fee543e981a8a2e1d355469c8  guix-build-d4d09e4eb066/output/aarch64-linux-gnu/bitcoin-d4d09e4eb066-aarch64-linux-gnu.tar.gz
cb8ca5053b80ad6546de1c3dc5956aad75c5236e2b443cf5eee842116fa88ae0  guix-build-d4d09e4eb066/output/arm-linux-gnueabihf/SHA256SUMS.part
b2d81d4ab5c9315e7c344a2052bac92e5e43d24027f2d6102262ea81162d1320  guix-build-d4d09e4eb066/output/arm-linux-gnueabihf/bitcoin-d4d09e4eb066-arm-linux-gnueabihf-debug.tar.gz
c0b1d289e41943491613d2dc84bbbf6b702c14b05883635f161d8980c24e99ab  guix-build-d4d09e4eb066/output/arm-linux-gnueabihf/bitcoin-d4d09e4eb066-arm-linux-gnueabihf.tar.gz
8ece66bfa85f7536c7076a8fb38c45acd05d57d2c53c0e875c637c50c1fd124b  guix-build-d4d09e4eb066/output/arm64-apple-darwin/SHA256SUMS.part
9eede88713a7065ccf1bfc6080b49796c299ab98e8b7e2746dff7cd0c0f23851  guix-build-d4d09e4eb066/output/arm64-apple-darwin/bitcoin-d4d09e4eb066-arm64-apple-darwin-codesigning.tar.gz
e00b192ada996b3cd5388b4c7c96ef55d13b30cf30cc1a685fe5b0ab6139bd38  guix-build-d4d09e4eb066/output/arm64-apple-darwin/bitcoin-d4d09e4eb066-arm64-apple-darwin-unsigned.tar.gz
efc1ecd020e44e43f914d53073adac46dc0791f05999f5cdb1f7b941012a7b16  guix-build-d4d09e4eb066/output/arm64-apple-darwin/bitcoin-d4d09e4eb066-arm64-apple-darwin-unsigned.zip
b7427962340e4daaf49b6a789e5261e653b506faea5e56de16f2865961fe93d0  guix-build-d4d09e4eb066/output/dist-archive/bitcoin-d4d09e4eb066.tar.gz
f228cc665149e6a3cb090f8d0a348d72f71b405d269ad4958efee892c822769d  guix-build-d4d09e4eb066/output/powerpc64-linux-gnu/SHA256SUMS.part
be648d4167d726e1496ef9b78beedf457f41d06072c9e9903350d8e4f8b77c52  guix-build-d4d09e4eb066/output/powerpc64-linux-gnu/bitcoin-d4d09e4eb066-powerpc64-linux-gnu-debug.tar.gz
7a9b5a69305de6abdabd7efe889bf26c3c1218a96f751f02567e6dcb7aca692c  guix-build-d4d09e4eb066/output/powerpc64-linux-gnu/bitcoin-d4d09e4eb066-powerpc64-linux-gnu.tar.gz
67f2b632e36b097f2c28b21d3b27c8e32838c1bb202b3013e0d7ded1dae0f8be  guix-build-d4d09e4eb066/output/riscv64-linux-gnu/SHA256SUMS.part
b2a8a65783d61a1e96169f4e1e03cdafd1bf3be634e0298d2df5774873e44076  guix-build-d4d09e4eb066/output/riscv64-linux-gnu/bitcoin-d4d09e4eb066-riscv64-linux-gnu-debug.tar.gz
c294bad4acfc424a02822e707addd5910fe052190b16053440b93f81c27bc60c  guix-build-d4d09e4eb066/output/riscv64-linux-gnu/bitcoin-d4d09e4eb066-riscv64-linux-gnu.tar.gz
d5426b70e231098b61f8ec29c1bbac095ce9b3b4377fb7c5b1543c93c705b976  guix-build-d4d09e4eb066/output/x86_64-apple-darwin/SHA256SUMS.part
8bbd7e613506791526a16a4100c0b3eb0075c810f0e5b0031fe2887615bd5a9b  guix-build-d4d09e4eb066/output/x86_64-apple-darwin/bitcoin-d4d09e4eb066-x86_64-apple-darwin-codesigning.tar.gz
6f9de0bcf9a556048606095c8b25ef18c2bf0c9d0082163ee22549c9f9ec71b4  guix-build-d4d09e4eb066/output/x86_64-apple-darwin/bitcoin-d4d09e4eb066-x86_64-apple-darwin-unsigned.tar.gz
c75a9d0739f78a78b1ceba5e66810e306ff830d005927002166adef64cd2a31e  guix-build-d4d09e4eb066/output/x86_64-apple-darwin/bitcoin-d4d09e4eb066-x86_64-apple-darwin-unsigned.zip
f21fe3c65423fca8e7cd8c2761497f812c3fa3ec8070db022fdd86b1fdf19543  guix-build-d4d09e4eb066/output/x86_64-linux-gnu/SHA256SUMS.part
d8ee0cd3c75e2d6c52403cc991fe92153e57b2f5f47a760b79496453b701b1e1  guix-build-d4d09e4eb066/output/x86_64-linux-gnu/bitcoin-d4d09e4eb066-x86_64-linux-gnu-debug.tar.gz
f73d907d32047b419e8047b0864998d58c5ba63411d7a135fcae95527c589d98  guix-build-d4d09e4eb066/output/x86_64-linux-gnu/bitcoin-d4d09e4eb066-x86_64-linux-gnu.tar.gz
6470d60aa6ce3514792844a99c7c9ff65f4d978c4d704e538a4a7afd3ff509f5  guix-build-d4d09e4eb066/output/x86_64-w64-mingw32/SHA256SUMS.part
353f540032c43d46805d19986063dc6c03007b59650e8cafca8a477e6625a2e2  guix-build-d4d09e4eb066/output/x86_64-w64-mingw32/bitcoin-d4d09e4eb066-win64-codesigning.tar.gz
fb54fdf39460f2e173882837b8c2685d46295e594edf469d69fad70b315d60eb  guix-build-d4d09e4eb066/output/x86_64-w64-mingw32/bitcoin-d4d09e4eb066-win64-debug.zip
4fd38c4056c6f275e1d4a4ffe543d99745461103317012838cf0b5f6c33ec713  guix-build-d4d09e4eb066/output/x86_64-w64-mingw32/bitcoin-d4d09e4eb066-win64-setup-unsigned.exe
a158ac076e029030fde0d62eac9d1298711f7616965912b5fd5f5c960fb7d62e  guix-build-d4d09e4eb066/output/x86_64-w64-mingw32/bitcoin-d4d09e4eb066-win64-unsigned.zip

Sjors commented at 5:53 PM on September 4, 2026: member

x86_64
5285c602b94b5345be396fadd8d3791829948e48dd8e44880650c7cb40692828  guix-build-d4d09e4eb066/output/aarch64-linux-gnu/SHA256SUMS.part
14bd26d72ec670e6a428cecf852a64f20e41238ff5a863f8e6167cfd8d38c6e4  guix-build-d4d09e4eb066/output/aarch64-linux-gnu/bitcoin-d4d09e4eb066-aarch64-linux-gnu-debug.tar.gz
0fe1a4f682d627480c13cecbd9176931f0e91f2fee543e981a8a2e1d355469c8  guix-build-d4d09e4eb066/output/aarch64-linux-gnu/bitcoin-d4d09e4eb066-aarch64-linux-gnu.tar.gz
cb8ca5053b80ad6546de1c3dc5956aad75c5236e2b443cf5eee842116fa88ae0  guix-build-d4d09e4eb066/output/arm-linux-gnueabihf/SHA256SUMS.part
b2d81d4ab5c9315e7c344a2052bac92e5e43d24027f2d6102262ea81162d1320  guix-build-d4d09e4eb066/output/arm-linux-gnueabihf/bitcoin-d4d09e4eb066-arm-linux-gnueabihf-debug.tar.gz
c0b1d289e41943491613d2dc84bbbf6b702c14b05883635f161d8980c24e99ab  guix-build-d4d09e4eb066/output/arm-linux-gnueabihf/bitcoin-d4d09e4eb066-arm-linux-gnueabihf.tar.gz
8ece66bfa85f7536c7076a8fb38c45acd05d57d2c53c0e875c637c50c1fd124b  guix-build-d4d09e4eb066/output/arm64-apple-darwin/SHA256SUMS.part
9eede88713a7065ccf1bfc6080b49796c299ab98e8b7e2746dff7cd0c0f23851  guix-build-d4d09e4eb066/output/arm64-apple-darwin/bitcoin-d4d09e4eb066-arm64-apple-darwin-codesigning.tar.gz
e00b192ada996b3cd5388b4c7c96ef55d13b30cf30cc1a685fe5b0ab6139bd38  guix-build-d4d09e4eb066/output/arm64-apple-darwin/bitcoin-d4d09e4eb066-arm64-apple-darwin-unsigned.tar.gz
efc1ecd020e44e43f914d53073adac46dc0791f05999f5cdb1f7b941012a7b16  guix-build-d4d09e4eb066/output/arm64-apple-darwin/bitcoin-d4d09e4eb066-arm64-apple-darwin-unsigned.zip
b7427962340e4daaf49b6a789e5261e653b506faea5e56de16f2865961fe93d0  guix-build-d4d09e4eb066/output/dist-archive/bitcoin-d4d09e4eb066.tar.gz
f228cc665149e6a3cb090f8d0a348d72f71b405d269ad4958efee892c822769d  guix-build-d4d09e4eb066/output/powerpc64-linux-gnu/SHA256SUMS.part
be648d4167d726e1496ef9b78beedf457f41d06072c9e9903350d8e4f8b77c52  guix-build-d4d09e4eb066/output/powerpc64-linux-gnu/bitcoin-d4d09e4eb066-powerpc64-linux-gnu-debug.tar.gz
7a9b5a69305de6abdabd7efe889bf26c3c1218a96f751f02567e6dcb7aca692c  guix-build-d4d09e4eb066/output/powerpc64-linux-gnu/bitcoin-d4d09e4eb066-powerpc64-linux-gnu.tar.gz
67f2b632e36b097f2c28b21d3b27c8e32838c1bb202b3013e0d7ded1dae0f8be  guix-build-d4d09e4eb066/output/riscv64-linux-gnu/SHA256SUMS.part
b2a8a65783d61a1e96169f4e1e03cdafd1bf3be634e0298d2df5774873e44076  guix-build-d4d09e4eb066/output/riscv64-linux-gnu/bitcoin-d4d09e4eb066-riscv64-linux-gnu-debug.tar.gz
c294bad4acfc424a02822e707addd5910fe052190b16053440b93f81c27bc60c  guix-build-d4d09e4eb066/output/riscv64-linux-gnu/bitcoin-d4d09e4eb066-riscv64-linux-gnu.tar.gz
d5426b70e231098b61f8ec29c1bbac095ce9b3b4377fb7c5b1543c93c705b976  guix-build-d4d09e4eb066/output/x86_64-apple-darwin/SHA256SUMS.part
8bbd7e613506791526a16a4100c0b3eb0075c810f0e5b0031fe2887615bd5a9b  guix-build-d4d09e4eb066/output/x86_64-apple-darwin/bitcoin-d4d09e4eb066-x86_64-apple-darwin-codesigning.tar.gz
6f9de0bcf9a556048606095c8b25ef18c2bf0c9d0082163ee22549c9f9ec71b4  guix-build-d4d09e4eb066/output/x86_64-apple-darwin/bitcoin-d4d09e4eb066-x86_64-apple-darwin-unsigned.tar.gz
c75a9d0739f78a78b1ceba5e66810e306ff830d005927002166adef64cd2a31e  guix-build-d4d09e4eb066/output/x86_64-apple-darwin/bitcoin-d4d09e4eb066-x86_64-apple-darwin-unsigned.zip
f21fe3c65423fca8e7cd8c2761497f812c3fa3ec8070db022fdd86b1fdf19543  guix-build-d4d09e4eb066/output/x86_64-linux-gnu/SHA256SUMS.part
d8ee0cd3c75e2d6c52403cc991fe92153e57b2f5f47a760b79496453b701b1e1  guix-build-d4d09e4eb066/output/x86_64-linux-gnu/bitcoin-d4d09e4eb066-x86_64-linux-gnu-debug.tar.gz
f73d907d32047b419e8047b0864998d58c5ba63411d7a135fcae95527c589d98  guix-build-d4d09e4eb066/output/x86_64-linux-gnu/bitcoin-d4d09e4eb066-x86_64-linux-gnu.tar.gz
6470d60aa6ce3514792844a99c7c9ff65f4d978c4d704e538a4a7afd3ff509f5  guix-build-d4d09e4eb066/output/x86_64-w64-mingw32/SHA256SUMS.part
353f540032c43d46805d19986063dc6c03007b59650e8cafca8a477e6625a2e2  guix-build-d4d09e4eb066/output/x86_64-w64-mingw32/bitcoin-d4d09e4eb066-win64-codesigning.tar.gz
fb54fdf39460f2e173882837b8c2685d46295e594edf469d69fad70b315d60eb  guix-build-d4d09e4eb066/output/x86_64-w64-mingw32/bitcoin-d4d09e4eb066-win64-debug.zip
4fd38c4056c6f275e1d4a4ffe543d99745461103317012838cf0b5f6c33ec713  guix-build-d4d09e4eb066/output/x86_64-w64-mingw32/bitcoin-d4d09e4eb066-win64-setup-unsigned.exe
a158ac076e029030fde0d62eac9d1298711f7616965912b5fd5f5c960fb7d62e  guix-build-d4d09e4eb066/output/x86_64-w64-mingw32/bitcoin-d4d09e4eb066-win64-unsigned.zip

fanquake commented at 2:23 PM on September 7, 2026: member

Perhaps simpler to go with a more "dumb" method like https://github.com/bitcoin/bitcoin/commit/efbb91102107dd9e758c46b9cd51d7a1de28c38a and accept that we may build some parts of depends twice, in the name of reproducibility!

I think I agree that this would be a better approach than the new changes here, which also seems fragile (i.e they introduce a list of files that we'd need to remember to manually update, if there's any (relevant) change in the contrib/guix dir), while essentially trying to recreate GUIX_ENVIRONMENT.

Note also the PR description / commit message don't seem to have been updated for the current changes, because they still state that "verbose compiler output" would be a viable replacement for GUIX_ENVIRONMENT.

hebasto commented at 10:28 AM on September 8, 2026: member

Perhaps simpler to go with a more "dumb" method like efbb911 and accept that we may build some parts of depends twice, in the name of reproducibility!

I think I agree that this would be a better approach than the new changes here...

Happy to close this PR in favour of an alternative approach, once someone opens one.

which also seems fragile (i.e they introduce a list of files that we'd need to remember to manually update, if there's any (relevant) change in the contrib/guix dir), while essentially trying to recreate GUIX_ENVIRONMENT.

The file list only names two files, and it shouldn't need updating often.

hebasto renamed this:
~~guix, depends: Omit `GUIX_ENVIRONMENT` from `gen_id` calculations~~
guix, depends: Drop `GUIX_ENVIRONMENT` from `gen_id` calculations
on Sep 9, 2026

guix, depends: Drop `GUIX_ENVIRONMENT` from `gen_id` calculations

Since commit 008a3e29c8844c0be4457279f5c27c1bc57401c7 ("guix: split
builds into Linux(gui) and macOS/Windows"), each host is built in two
containers: one instantiated from `manifest_build.scm` and the other
from the union of `manifest_build.scm` and `manifest_gui.scm`. The
resulting Guix profiles necessarily differ, and because
`$(realpath $(GUIX_ENVIRONMENT))` is hashed into every depends package
id, the built-package cache is invalidated whenever the profile
changes:
1. Depends are rebuilt when switching to another branch with identical
   Guix scripts and the depends subdirectory.
2. Non-GUI packages are built twice per host, as the GUI container
   cannot reuse the packages just cached by the base container (this is
   mostly relevant for non-Linux hosts, as we move towards static builds
   on Linux).

Drop `GUIX_ENVIRONMENT` from the `gen_id` inputs, and salt the depends
ids in `guix-build` with the inputs that define the containers instead:
the pinned time-machine commit, the contents of `manifest_build.scm`,
`manifest_gui.scm` and of every patch in `contrib/guix/patches`, and
the user-supplied `ADDITIONAL_GUIX_*_FLAGS`.

Unlike the profile path, this salt is identical for both containers of
a given host, so the GUI container reuses the packages built by the base
container, and it stays stable across branches whose Guix and depends
inputs are unchanged, while any change to the pinned Guix revision, to
the manifests, or to the patches still invalidates the cache.

5d8f540829

hebasto force-pushed on Sep 9, 2026

hebasto commented at 7:41 AM on September 9, 2026: member

Note also the PR description / commit message don't seem to have been updated for the current changes, because they still state that "verbose compiler output" would be a viable replacement for GUIX_ENVIRONMENT.

Thanks! Reworked.

Sjors commented at 2:37 PM on September 9, 2026: member

x86_64
5ea07656570b984de7de1160bd916ebd3fb1601d21d766b64566ef5cd379fe3c  guix-build-5d8f5408290c/output/aarch64-linux-gnu/SHA256SUMS.part
7c232b06dad9e7dfc28edc33002aaf968663ef333db7cde80daca3a666b6f776  guix-build-5d8f5408290c/output/aarch64-linux-gnu/bitcoin-5d8f5408290c-aarch64-linux-gnu-debug.tar.gz
54246dcb9f1f4f24a04bef0a6af27b43712295452d34845ecb23afa48547a710  guix-build-5d8f5408290c/output/aarch64-linux-gnu/bitcoin-5d8f5408290c-aarch64-linux-gnu.tar.gz
3fb789e5f4a71c75bc0ed7f146729259a5ab3d039fa95fdb69856e7b9bc6bea1  guix-build-5d8f5408290c/output/arm-linux-gnueabihf/SHA256SUMS.part
9a868872035da36cbdf70350df8cc73f8d00c43625a1cfe1b548dae38f0e1eb0  guix-build-5d8f5408290c/output/arm-linux-gnueabihf/bitcoin-5d8f5408290c-arm-linux-gnueabihf-debug.tar.gz
0e837e13c8d817be51ddb01796e242a69b8cce8d91b82759de3fc0bf3e8dbd02  guix-build-5d8f5408290c/output/arm-linux-gnueabihf/bitcoin-5d8f5408290c-arm-linux-gnueabihf.tar.gz
0cde36420cdc28b819ec4f381615f22a96c1214a55b87086c6886d36b03895b6  guix-build-5d8f5408290c/output/arm64-apple-darwin/SHA256SUMS.part
1990fff14171b5638088a4c934b50ac0b15b74b7d3a26e06f679d3ead601c3f5  guix-build-5d8f5408290c/output/arm64-apple-darwin/bitcoin-5d8f5408290c-arm64-apple-darwin-codesigning.tar.gz
f99d06d0cf0f85d27ea8ce661377b2342d2e5712cc03b8d889383a0f3edcd529  guix-build-5d8f5408290c/output/arm64-apple-darwin/bitcoin-5d8f5408290c-arm64-apple-darwin-unsigned.tar.gz
3e760b85e0cc34bf5c467880d31d413352f2cb959e1162f768c8bd6c3709a2e4  guix-build-5d8f5408290c/output/arm64-apple-darwin/bitcoin-5d8f5408290c-arm64-apple-darwin-unsigned.zip
4f8fbb225e76b967345e98e364c71940c78d03be679bca05c78b8b37bd9b5184  guix-build-5d8f5408290c/output/dist-archive/bitcoin-5d8f5408290c.tar.gz
ffc34ed563231e0943f741820a0f3e92f1e6acafde4212eb5e5be31be902e75b  guix-build-5d8f5408290c/output/powerpc64-linux-gnu/SHA256SUMS.part
33414e8c60a77f7e8f9746a72ad53f218f5003ba7bcf5f968d161b3a354b70a7  guix-build-5d8f5408290c/output/powerpc64-linux-gnu/bitcoin-5d8f5408290c-powerpc64-linux-gnu-debug.tar.gz
5da433cf4c59fbef99258c6d9309eb4e5e85779eb84d301aa932635ed953bd3b  guix-build-5d8f5408290c/output/powerpc64-linux-gnu/bitcoin-5d8f5408290c-powerpc64-linux-gnu.tar.gz
3dab86136bf0dcbbd4b1772bd3fa112fa0643d8ee2976266899bca6bda60249a  guix-build-5d8f5408290c/output/riscv64-linux-gnu/SHA256SUMS.part
3079a33a644778eb8de52ca89fac5b4a9d812c7f2afcd6fa1aaf344dbb65961b  guix-build-5d8f5408290c/output/riscv64-linux-gnu/bitcoin-5d8f5408290c-riscv64-linux-gnu-debug.tar.gz
479950294d5ca804580e1419ea03768a905a1243e0182434ff56b96ab7be5c0f  guix-build-5d8f5408290c/output/riscv64-linux-gnu/bitcoin-5d8f5408290c-riscv64-linux-gnu.tar.gz
7b83cda66ffbd313e183b7ba14287ea41b0d36c032e45291825209b0286d4dae  guix-build-5d8f5408290c/output/x86_64-apple-darwin/SHA256SUMS.part
f7c49c1ed2af3cb8a8f834e9ba49613b782f476ce8445ff9ccb8215a20d2b63d  guix-build-5d8f5408290c/output/x86_64-apple-darwin/bitcoin-5d8f5408290c-x86_64-apple-darwin-codesigning.tar.gz
98d390411d9efb58550c61d141d4746fc561b2c943404bb3bd09495f60a5288b  guix-build-5d8f5408290c/output/x86_64-apple-darwin/bitcoin-5d8f5408290c-x86_64-apple-darwin-unsigned.tar.gz
4b36a57cf599494d620f93ead38d5cf233e54ad7004e976c4da6fcb00ef5bac6  guix-build-5d8f5408290c/output/x86_64-apple-darwin/bitcoin-5d8f5408290c-x86_64-apple-darwin-unsigned.zip
91c3454ae83f9dfc4a33af867b6aa8d1d26b41ad7f548f509b4f9dc004dfcd9a  guix-build-5d8f5408290c/output/x86_64-linux-gnu/SHA256SUMS.part
0ddd7d99d499fa8419566a4fad8e3dd10d961f71e760ab4ad2b1b8c3d2ba8c5e  guix-build-5d8f5408290c/output/x86_64-linux-gnu/bitcoin-5d8f5408290c-x86_64-linux-gnu-debug.tar.gz
f77f8be3f9721673e1aee547e2fe4bda8042407c871d2018e0b40808412c6da8  guix-build-5d8f5408290c/output/x86_64-linux-gnu/bitcoin-5d8f5408290c-x86_64-linux-gnu.tar.gz
6d7313d14697f2e9362bbbc810c26b09e7324a3718dedb42b99d9e3b2b71455a  guix-build-5d8f5408290c/output/x86_64-w64-mingw32/SHA256SUMS.part
c2c9a1699bafe160090dfc6416c010e181c8b748e159821c695f72bc969b4f20  guix-build-5d8f5408290c/output/x86_64-w64-mingw32/bitcoin-5d8f5408290c-win64-codesigning.tar.gz
e6eb8085b51a5a0c95a008f7c54da5db256b2f9e69eaec4269789c22303218af  guix-build-5d8f5408290c/output/x86_64-w64-mingw32/bitcoin-5d8f5408290c-win64-debug.zip
2f38f3913c07781aab27681df41f985caba9ae14f30f8cb445fbed73b24dd0ff  guix-build-5d8f5408290c/output/x86_64-w64-mingw32/bitcoin-5d8f5408290c-win64-setup-unsigned.exe
ed80341e31e7de311faaa2bb548772eedf3ee00fa6df053a089a817413e82901  guix-build-5d8f5408290c/output/x86_64-w64-mingw32/bitcoin-5d8f5408290c-win64-unsigned.zip

willcl-ark commented at 7:56 PM on September 9, 2026: member

I opened #36209 as a possible alternative to the approach here.

hebasto commented at 10:12 AM on September 10, 2026: member

Perhaps simpler to go with a more "dumb" method like efbb911 and accept that we may build some parts of depends twice, in the name of reproducibility!

I think I agree that this would be a better approach than the new changes here...

Happy to close this PR in favour of an alternative approach, once someone opens one.

I opened #36209 as a possible alternative to the approach here.

Closing this PR in favour of #36209.

hebasto closed this on Sep 10, 2026

fanquake removed this from the milestone 32.0 on Sep 10, 2026

guix, depends: Drop `GUIX_ENVIRONMENT` from `gen_id` calculations #35929

Code Coverage & Benchmarks

Reviews

Conflicts