depends, qt: Add patch for missing headers #35945

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:260810-depends-qt-syncqt changing 3 files +38 −2
  1. hebasto commented at 3:24 PM on August 10, 2026: member

    This PR fixes the build when using recent Clang releases and libc++.

    From https://github.com/hebasto/bitcoin-core-nightly/actions/runs/31400107892/job/93492660951:

    [27/1645] Building CXX object qtbase/src/tools/syncqt/CMakeFiles/syncqt.dir/main.cpp.o
    FAILED: [code=1] qtbase/src/tools/syncqt/CMakeFiles/syncqt.dir/main.cpp.o 
    /usr/bin/clang++-24  -stdlib=libc++ -DQT_EXPLICIT_QFILE_CONSTRUCTION_FROM_PATH -DQT_LEAN_HEADERS=1 -DQT_NAMESPACE=\"\" -DQT_NO_DEBUG -DQT_NO_FOREACH -DQT_NO_JAVA_STYLE_ITERATORS -DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT -DQT_NO_QASCONST -DQT_NO_QEXCHANGE -DQT_NO_QSNPRINTF -DQT_USE_QSTRINGBUILDER -DQT_VERSION_MAJOR=6 -DQT_VERSION_MINOR=8 -DQT_VERSION_PATCH=4 -DQT_VERSION_STR=\"6.8.4\" -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_FAST -I/home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/depends/work/build/x86_64-pc-linux-gnu/qt/6.8.4-e34d706caeb/qtbase/src/tools/syncqt -I/home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/depends/work/build/x86_64-pc-linux-gnu/qt/6.8.4-e34d706caeb/qtbase/mkspecs/linux-clang -I/home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/depends/work/build/x86_64-pc-linux-gnu/qt/6.8.4-e34d706caeb/qtbase/include -I/home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/depends/x86_64-pc-linux-gnu/include  -ffile-prefi
    /home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/depends/work/build/x86_64-pc-linux-gnu/qt/6.8.4-e34d706caeb/qtbase/src/tools/syncqt/main.cpp:82:10: error: no member named 'transform' in namespace 'std'
       82 |     std::transform(s.begin(), s.end(), s.begin(),
          |          ^~~~~~~~~
    /home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/depends/work/build/x86_64-pc-linux-gnu/qt/6.8.4-e34d706caeb/qtbase/src/tools/syncqt/main.cpp:89:10: error: no member named 'transform' in namespace 'std'
       89 |     std::transform(s.begin(), s.end(), s.begin(),
          |          ^~~~~~~~~
    2 errors generated.
    [28/1645] Building C object qtbase/src/3rdparty/pcre2/CMakeFiles/BundledPcre2.dir/src/pcre2_ucd.c.o
    [29/1645] Building C object qtbase/src/3rdparty/pcre2/CMakeFiles/BundledPcre2.dir/src/pcre2_match.c.o
    [30/1645] Building C object qtbase/src/3rdparty/pcre2/CMakeFiles/BundledPcre2.dir/src/pcre2_jit_compile.c.o
    ninja: build stopped: subcommand failed.
    gmake: *** [funcs.mk:343: /home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/depends/work/build/x86_64-pc-linux-gnu/qt/6.8.4-e34d706caeb/./.stamp_built] Error 1
    gmake: Leaving directory '/home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/depends'
    

    From https://github.com/hebasto/bitcoin-core-nightly/actions/runs/31403593334/job/93504547098:

    [892/1645] Building CXX object qtbase/src/plugins/platforms/xcb/CMakeFiles/XcbQpaPrivate.dir/qxcbatom.cpp.o
    FAILED: [code=1] qtbase/src/plugins/platforms/xcb/CMakeFiles/XcbQpaPrivate.dir/qxcbatom.cpp.o 
    /usr/bin/clang++-24  -stdlib=libc++ -DQT_ASCII_CAST_WARNINGS -DQT_BUILDING_QT -DQT_BUILD_XCB_PLUGIN -DQT_BUILD_XCB_QPA_LIB_LIB -DQT_CORE_LIB -DQT_DEPRECATED_WARNINGS -DQT_EXPLICIT_QFILE_CONSTRUCTION_FROM_PATH -DQT_GUI_LIB -DQT_LEAN_HEADERS=1 -DQT_MOC_COMPAT -DQT_NO_CAST_TO_ASCII -DQT_NO_DEBUG -DQT_NO_EXCEPTIONS -DQT_NO_FOREACH -DQT_NO_JAVA_STYLE_ITERATORS -DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT -DQT_NO_QASCONST -DQT_NO_QEXCHANGE -DQT_NO_QSNPRINTF -DQT_USE_QSTRINGBUILDER -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_FAST -I/home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/depends/work/build/x86_64-pc-linux-gnu/qt/6.8.4-d5ec21e4777/qtbase/src/plugins/platforms/xcb/XcbQpaPrivate_autogen/include -I/home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/depends/work/build/x86_64-pc-linux-gnu/qt/6.8.4-d5ec21e4777/qtbase/src/plugins/platforms/xcb -I/home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/depends/work/build/x86_64-pc-linux-gnu/qt/6.8.4-d5ec21e4777/qtbase/src/plugins/platforms/xcb/gl_integrations -I/home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/depends/work/build/x86_64-pc-linux-gnu/qt/6.8.4-d5ec21e4777/qtbase/src/3rdparty/xcb/include -I/home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/depends/work/build/x86_64-pc-linux-gnu/qt/6.8.4-d5ec21e4777/qtbase/src/corelib -I/home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/depends/work/build/x86_64-pc-linux-gnu/qt/6.8.4-d5ec21e4777/qtbase/include/QtCore/6.8.4 -I/home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/depends/work/build/x86_64-pc-linux-gnu/qt/6.8.4-d5ec21e4777/qtbase/include/QtCore/6.8.4/QtCore -I/home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/depends/work/build/x86_64-pc-linux-gnu/qt/6.8.4-d5ec21e4777/qtbase/include -I/home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/depends/work/build/x86_64-pc-linux-gnu/qt/6.8.4-d5ec21e4777/qtbase/include/QtCore -I/home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/depends/work/build/x86_64-pc-linux-gnu/qt/6.8.4-d5ec21e4777/qtbase/mkspecs/linux-clang -I/home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/depends/work/build/x86_64-pc-linux-gnu/qt/6.8.4-d5ec21e4777/qtbase/src/gui -I/home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/depends/work/build/x86_64-pc-linux-gnu/qt/6.8.4-d5ec21e4777/qtbase/include/QtGui/6.8.4 -I/home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/depends/work/build/x86_64-pc-linux-gnu/qt/6.8.4-d5ec21e4777/qtbase/include/QtGui/6.8.4/QtGui -I/home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/depends/work/build/x86_64-pc-linux-gnu/qt/6.8.4-d5ec21e4777/qtbase/include/QtGui -I/home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/depends/x86_64-pc-linux-gnu/include  -ffile-prefix-map=/home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/depends/work/build/x86_64-pc-linux-gnu/qt/6.8.4-d5ec21e4777=/usr -O2 -std=gnu++20 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -Wall -Wextra -fno-exceptions -ftemplate-depth=1024 -ffunction-sections -fdata-sections -U_FORTIFY_SOURCE -fcf-protection=full -D_FORTIFY_SOURCE=3 -ftrivial-auto-var-init=pattern -fstack-protector-strong -MD -MT qtbase/src/plugins/platforms/xcb/CMakeFiles/XcbQpaPrivate.dir/qxcbatom.cpp.o -MF qtbase/src/plugins/platforms/xcb/CMakeFiles/XcbQpaPrivate.dir/qxcbatom.cpp.o.d -o qtbase/src/plugins/platforms/xcb/CMakeFiles/XcbQpaPrivate.dir/qxcbatom.cpp.o -c /home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/depends/work/build/x86_64-pc-linux-gnu/qt/6.8.4-d5ec21e4777/qtbase/src/plugins/platforms/xcb/qxcbatom.cpp
    /home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/depends/work/build/x86_64-pc-linux-gnu/qt/6.8.4-d5ec21e4777/qtbase/src/plugins/platforms/xcb/qxcbatom.cpp:237:13: error: use of undeclared identifier 'free'
      237 |             free(reply);
          |             ^~~~
    1 error generated.
    
  2. hebasto added the label Build system on Aug 10, 2026
  3. DrahtBot commented at 3:25 PM on August 10, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35945.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK fanquake

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. hebasto marked this as a draft on Aug 10, 2026
  5. hebasto force-pushed on Aug 10, 2026
  6. DrahtBot added the label CI failed on Aug 10, 2026
  7. hebasto renamed this:
    depends, qt: Add patch for missing header
    depends, qt: Add patch for missing headers
    on Aug 10, 2026
  8. hebasto marked this as ready for review on Aug 10, 2026
  9. depends, qt: Add patch for missing headers
    This fixes the build when using recent clang releases and libc++.
    e8500cbd19
  10. hebasto force-pushed on Aug 10, 2026
  11. DrahtBot removed the label CI failed on Aug 10, 2026
  12. hebasto commented at 10:09 AM on August 11, 2026: member

    My Guix build:

    aarch64
    6d106ce8aea768dbd725d31febfa54e5fcfadd103f8888a578e116d392484271  guix-build-e8500cbd19db/output/aarch64-linux-gnu/SHA256SUMS.part
    f63bf074269ae357739b6e94ed010d26b3619824bd8c43a41833a58c8c5b3bde  guix-build-e8500cbd19db/output/aarch64-linux-gnu/bitcoin-e8500cbd19db-aarch64-linux-gnu-debug.tar.gz
    8778f3ee617a63ce64f02bc242f11190e3578910aadb30f54be3d5dcc87b1d28  guix-build-e8500cbd19db/output/aarch64-linux-gnu/bitcoin-e8500cbd19db-aarch64-linux-gnu.tar.gz
    f4d3c5dfd3f3604892e046a96ff9878a5208955695c6594b805267b1433cb4e8  guix-build-e8500cbd19db/output/arm-linux-gnueabihf/SHA256SUMS.part
    b0acb2c44c7fbabbaac6c61a024d027243c0cac082872a892b80b3ff3a561147  guix-build-e8500cbd19db/output/arm-linux-gnueabihf/bitcoin-e8500cbd19db-arm-linux-gnueabihf-debug.tar.gz
    756e37a8164dc266e449f104c7d77e4969965262aa23240b07721992f265d831  guix-build-e8500cbd19db/output/arm-linux-gnueabihf/bitcoin-e8500cbd19db-arm-linux-gnueabihf.tar.gz
    46fa224f35003545afde756f4061028910bfc38d6919a190cead8e82bfac3f3c  guix-build-e8500cbd19db/output/arm64-apple-darwin/SHA256SUMS.part
    9e3f87385e392d180981920dfe81c8e1087a035a22f4cb9d730975b78776fbbd  guix-build-e8500cbd19db/output/arm64-apple-darwin/bitcoin-e8500cbd19db-arm64-apple-darwin-codesigning.tar.gz
    5278892ea074572e69b19cac6039429de9525314ec22bfa865c259e891363be5  guix-build-e8500cbd19db/output/arm64-apple-darwin/bitcoin-e8500cbd19db-arm64-apple-darwin-unsigned.tar.gz
    923511f7378a7e8c897caa089c5b9af21cbb6c0179762d6ae9a025a834b3b6d4  guix-build-e8500cbd19db/output/arm64-apple-darwin/bitcoin-e8500cbd19db-arm64-apple-darwin-unsigned.zip
    cee7979d95c39e991542b88f03d27fa08a7847f1f41b25845df9d9bfffa34618  guix-build-e8500cbd19db/output/dist-archive/bitcoin-e8500cbd19db.tar.gz
    823fc2e3103633d2a4ec40d62815dfbb1c89d9ddf779c6e7ca81228166061681  guix-build-e8500cbd19db/output/powerpc64-linux-gnu/SHA256SUMS.part
    4a9ab455b7fd13973248c46945e09efaafa154d607f535f15000e9f8e72275c3  guix-build-e8500cbd19db/output/powerpc64-linux-gnu/bitcoin-e8500cbd19db-powerpc64-linux-gnu-debug.tar.gz
    dbcda48aa06270d0cadd12ae047c0e9c25dfd4e972ca988818e15703c7485f55  guix-build-e8500cbd19db/output/powerpc64-linux-gnu/bitcoin-e8500cbd19db-powerpc64-linux-gnu.tar.gz
    a6eecaf568cbcad4953e2230f64aa562d97e542614e61acee51c3170844a807e  guix-build-e8500cbd19db/output/riscv64-linux-gnu/SHA256SUMS.part
    c9af59c24d2875256c47563a6816bd24aa51b6fbaec16cfe9d4cc1ee726fd9fc  guix-build-e8500cbd19db/output/riscv64-linux-gnu/bitcoin-e8500cbd19db-riscv64-linux-gnu-debug.tar.gz
    18b81d5574cea81add0a457a3a34d7ef254ef9294c2590332d196759d2bc4708  guix-build-e8500cbd19db/output/riscv64-linux-gnu/bitcoin-e8500cbd19db-riscv64-linux-gnu.tar.gz
    87f5241e07bb35b69e9b73c940951aae4c9d7c0ac7305fb0748e6225a0773166  guix-build-e8500cbd19db/output/x86_64-apple-darwin/SHA256SUMS.part
    f3fbbf175ba77f224b2aef4fdaba511f3cac1c0d712a05ab2ba772633f64ad05  guix-build-e8500cbd19db/output/x86_64-apple-darwin/bitcoin-e8500cbd19db-x86_64-apple-darwin-codesigning.tar.gz
    f336ce2ed373fc412587a697baf7bc8e7470ed38762f75c8d95995768879fb01  guix-build-e8500cbd19db/output/x86_64-apple-darwin/bitcoin-e8500cbd19db-x86_64-apple-darwin-unsigned.tar.gz
    c10338d057c36f7ebde7ab73593dd6823bfde3f3a840be1421e11778a21a9fba  guix-build-e8500cbd19db/output/x86_64-apple-darwin/bitcoin-e8500cbd19db-x86_64-apple-darwin-unsigned.zip
    73f0d443430b64ff181d2bf5f20487039452d1e33aa52081c8af36380af6429d  guix-build-e8500cbd19db/output/x86_64-linux-gnu/SHA256SUMS.part
    3cfd9ca0679e2e16f3ab91ba269768302ff8e971757d675f7351ba1941b1f10d  guix-build-e8500cbd19db/output/x86_64-linux-gnu/bitcoin-e8500cbd19db-x86_64-linux-gnu-debug.tar.gz
    5f0c118faf3f67712eb6d01e54170201aef7a6b040c6d5c042ba79e52c711cac  guix-build-e8500cbd19db/output/x86_64-linux-gnu/bitcoin-e8500cbd19db-x86_64-linux-gnu.tar.gz
    54c7eb8c62f5bd9565582902ff65072a96842d4eec9e52179aa24e03da1b9601  guix-build-e8500cbd19db/output/x86_64-w64-mingw32/SHA256SUMS.part
    5f4f908975f49bb69ac19295bfebbcdb131b3bef799ec084c2b55c54a039a398  guix-build-e8500cbd19db/output/x86_64-w64-mingw32/bitcoin-e8500cbd19db-win64-codesigning.tar.gz
    2e22ef652419d041a3702e5317544f4a9d8526e3a59e11474b8f4dbb67d00315  guix-build-e8500cbd19db/output/x86_64-w64-mingw32/bitcoin-e8500cbd19db-win64-debug.zip
    cd84223ba73699552626c313e4a035d4ab94b098c3460f9e5700bf1381a8d4f4  guix-build-e8500cbd19db/output/x86_64-w64-mingw32/bitcoin-e8500cbd19db-win64-setup-unsigned.exe
    efd7d1a0fbb4444bf2446357b02026222ce5bc07e71143a44781fa9e5dc2a13b  guix-build-e8500cbd19db/output/x86_64-w64-mingw32/bitcoin-e8500cbd19db-win64-unsigned.zip
    
  13. fanquake commented at 10:45 AM on August 12, 2026: member

    ACK e8500cbd19db8b8183c7deedb0a9836c2e30a7de

  14. fanquake merged this on Aug 12, 2026
  15. fanquake closed this on Aug 12, 2026

  16. hebasto deleted the branch on Aug 12, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-08-31 18:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me