ci: Enable Boost.MultiIndex invariant-checking mode #35957

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:260812-boost-debug changing 3 files +5 −2

hebasto commented at 12:26 PM on August 12, 2026: member

From the Boost.MultiIndex docs:

When this mode is in effect, all public functions of Boost.MultiIndex will perform post-execution tests aimed at ensuring that the basic internal invariants of the data structures managed are preserved.

It is recommended that users of Boost.MultiIndex always set the invariant-checking mode in debug builds.

Define it in the two jobs that already define BOOST_MULTI_INDEX_ENABLE_SAFE_MODE. The "MSAN, fuzz" job also defines safe mode but is left unchanged, as invariant checking would push it past the 240-minute limit on the Warp runner.
hebasto added the label Tests on Aug 12, 2026
DrahtBot commented at 12:26 PM on August 12, 2026: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35957.



Reviews

See the guideline and AI policy for information on the review process. A summary of reviews will appear here.
fanquake commented at 12:30 PM on August 12, 2026: member

ci: Define BOOST_MULTI_INDEX_ENABLE_SAFE_MODE

This is already defined? Shouldn't the commit message be "ci: Define BOOST_MULTI_INDEX_ENABLE_INVARIANT_CHECKING for debug builds"?
hebasto renamed this:
~~ci: Define `BOOST_MULTI_INDEX_ENABLE_SAFE_MODE` for debug builds~~
ci: Define `BOOST_MULTI_INDEX_ENABLE_INVARIANT_CHECKING` for debug builds
on Aug 12, 2026
hebasto force-pushed on Aug 12, 2026
DrahtBot added the label CI failed on Aug 12, 2026
hebasto commented at 12:46 PM on August 12, 2026: member

ci: Define BOOST_MULTI_INDEX_ENABLE_SAFE_MODE

This is already defined? Shouldn't the commit message be "ci: Define BOOST_MULTI_INDEX_ENABLE_INVARIANT_CHECKING for debug builds"?

Thanks! Fixed.
fanquake commented at 9:03 AM on August 13, 2026: member

https://github.com/bitcoin/bitcoin/actions/runs/31598051874/job/94118405886?pr=35957

Looks like this times out the MSAN fuzz job. How long did it take when you tested it locally?
hebasto commented at 2:39 PM on August 13, 2026: member

https://github.com/bitcoin/bitcoin/actions/runs/31598051874/job/94118405886?pr=35957

Looks like this times out the MSAN fuzz job. How long did it take when you tested it locally?

It took 214 min on my machine with 16 cores.
hebasto force-pushed on Aug 15, 2026

ci: Enable Boost.MultiIndex invariant-checking mode

From the Boost.MultiIndex docs:
> When this mode is in effect, all public functions of Boost.MultiIndex
> will perform post-execution tests aimed at ensuring that the basic
> internal invariants of the data structures managed are preserved.
>
> It is recommended that users of Boost.MultiIndex always set the
> invariant-checking mode in debug builds.

Define it in the two jobs that already define
BOOST_MULTI_INDEX_ENABLE_SAFE_MODE. The "MSAN, fuzz" job also defines
safe mode but is left unchanged, as invariant checking would push it
past the 240-minute limit on the Warp runner.

cfdcc6d207

hebasto force-pushed on Aug 16, 2026
hebasto renamed this:
~~ci: Define `BOOST_MULTI_INDEX_ENABLE_INVARIANT_CHECKING` for debug builds~~
ci: Enable Boost.MultiIndex invariant-checking mode
on Aug 16, 2026
DrahtBot removed the label CI failed on Aug 16, 2026

Contributors

Labels

ci: Enable Boost.MultiIndex invariant-checking mode #35957

Code Coverage & Benchmarks

Reviews