test: sync funding block before isolating nodes #35968

pull Shaurya2k06 wants to merge 1 commits into bitcoin:master from Shaurya2k06:test-wallet-listtransactions-sync changing 1 files +1 −1
  1. Shaurya2k06 commented at 9:55 AM on August 14, 2026: none

    Fixes #35967

    test_alternate_witness_tx mines the taproot funding output on node0 with sync_fun=self.no_op and immediately disconnects. node1 later includes the script-path spend via generateblock. If the funding block has not reached node1, that call fails with bad-txns-inputs-missingorspent.

    Drop the no_op so generate() uses the default sync_all before the partition. Later generate* calls keep no_op because the nodes are then disconnected.

    Seen twice this week in hebasto bitcoin-core-nightly NetBSD jobs: https://github.com/hebasto/bitcoin-core-nightly/actions/runs/31350308484/job/93339698854 https://github.com/hebasto/bitcoin-core-nightly/actions/runs/31765546925/job/94660585799

    The modified test is test/functional/wallet_listtransactions.py. I ran it locally three times with build/test/functional/wallet_listtransactions.py.

  2. test: sync funding block before isolating nodes
    test_alternate_witness_tx mines the taproot funding output on node0
    with sync_fun=self.no_op and immediately disconnects. node1 later
    includes the script-path spend via generateblock. If the funding
    block has not reached node1, that call fails with
    bad-txns-inputs-missingorspent.
    
    Drop the no_op so generate() uses the default sync_all before the
    partition.
    
    Signed-off-by: shaurya2k06 <shaurya2k06@gmail.com>
    8454fb2bd7
  3. DrahtBot added the label Tests on Aug 14, 2026
  4. DrahtBot commented at 9:55 AM on August 14, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35968.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-08-17 07:50 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me