guix: build glibc with `--enable-kernel=3.17.0` #35993

fanquake commented at 11:34 AM on August 17, 2026: member

Our minimum required kernel version is documented as 3.17.0. Pass --enable-kernel=3.17.0 when building glibc, so that version is reflected in the binary, and the version checked in the symbol-check script, aligns with the expected minimum.

guix: build glibc with --enable-kernel=3.17.0 5548818115

DrahtBot added the label Build system on Aug 17, 2026

DrahtBot commented at 11:34 AM on August 17, 2026: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35993.

Reviews

See the guideline and AI policy for information on the review process.

Type	Reviewers
ACK	hebasto, willcl-ark

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.

hebasto commented at 12:31 PM on August 17, 2026: member

Concept ACK. I was about suggesting the same in #25573.

Our minimum required kernel version is documented as 3.17.0. Pass --enable-kernel=3.17.0 when building glibc, so that version is reflected in the binary, and the version checked in the symbol-check script, aligns with the expected minimum.

Also:

The higher the version number is, ... the faster the code gets.

hebasto commented at 4:49 PM on August 17, 2026: member

My Guix build:

aarch64
4063b7b56663a4bb26bea40ca1ef27e9053f66f8546b256512c0abac7bd388af  guix-build-5548818115c0/output/aarch64-linux-gnu/SHA256SUMS.part
fe090bfe735c9fd633774720215e4fe0d84df2c3bc58bb0187f57bc27f944f0b  guix-build-5548818115c0/output/aarch64-linux-gnu/bitcoin-5548818115c0-aarch64-linux-gnu-debug.tar.gz
c807c5d7d8a443d9a11d6abce0832c28906a5bef9ed79ed97ca965f3e1ff2a49  guix-build-5548818115c0/output/aarch64-linux-gnu/bitcoin-5548818115c0-aarch64-linux-gnu.tar.gz
983d417f0c9a02b3f336d7e5b808ca7dd6d16973f35fc7d7443d896354041c04  guix-build-5548818115c0/output/arm-linux-gnueabihf/SHA256SUMS.part
62057b725ebc65c0471a790b38ffc09eb1babdb5eb2c60d2328ace9382a55f55  guix-build-5548818115c0/output/arm-linux-gnueabihf/bitcoin-5548818115c0-arm-linux-gnueabihf-debug.tar.gz
b0fffb72aaebc7b3c128694fc9b67982861ccb9ee3ce8b2d0cd0e22570cf49b3  guix-build-5548818115c0/output/arm-linux-gnueabihf/bitcoin-5548818115c0-arm-linux-gnueabihf.tar.gz
b2641ea7a53f41c08d6de4453ad0a7f0fd625559715f3299a4f7949c0cedbd62  guix-build-5548818115c0/output/arm64-apple-darwin/SHA256SUMS.part
ef883aef674d8d99f0b0df4b4c272f45c3db2739f3c106a6890321dd2122abe5  guix-build-5548818115c0/output/arm64-apple-darwin/bitcoin-5548818115c0-arm64-apple-darwin-codesigning.tar.gz
12fa372c54e8bdc50c532c82dee2eeb8ad15ee6116aea74885d9cdf9f11ee112  guix-build-5548818115c0/output/arm64-apple-darwin/bitcoin-5548818115c0-arm64-apple-darwin-unsigned.tar.gz
88d93a9cad6c2950f8bfafa8dc19b880f6005bb71103e74b445e98a1fa2e06d2  guix-build-5548818115c0/output/arm64-apple-darwin/bitcoin-5548818115c0-arm64-apple-darwin-unsigned.zip
1b9b4e33e6366981102ff0c9d737eb3021c5e4268626c164390d8cf9e473db76  guix-build-5548818115c0/output/dist-archive/bitcoin-5548818115c0.tar.gz
e626e7a7d2c85e3b34de35841fa5737d102c8588e512522c09d7d13eb3989385  guix-build-5548818115c0/output/powerpc64-linux-gnu/SHA256SUMS.part
475955c1a7e8bfb16bb609db45ca871bdf8ba8c367a6b44a918861d9b7f2f387  guix-build-5548818115c0/output/powerpc64-linux-gnu/bitcoin-5548818115c0-powerpc64-linux-gnu-debug.tar.gz
ac612b3fb599fe8c363c6a3558b99471155141701965cc624196beb06607a612  guix-build-5548818115c0/output/powerpc64-linux-gnu/bitcoin-5548818115c0-powerpc64-linux-gnu.tar.gz
a8344b6e8989c6d9e2f1d3b441d57edcd6f4a8fcea43924551a98241218c70f0  guix-build-5548818115c0/output/riscv64-linux-gnu/SHA256SUMS.part
08b3a9face219e981b344a209c5ad8dc9e2e5df1dce4ea334706c24fe3ed41fc  guix-build-5548818115c0/output/riscv64-linux-gnu/bitcoin-5548818115c0-riscv64-linux-gnu-debug.tar.gz
76cd04fe595e3d2d127f62238544b2767e6238660752f1f9b984e0d2c3720c87  guix-build-5548818115c0/output/riscv64-linux-gnu/bitcoin-5548818115c0-riscv64-linux-gnu.tar.gz
7c10efcd7d96f9f45a4f812698d9503e7fc9e88d04c641b73939f7c7528662e5  guix-build-5548818115c0/output/x86_64-apple-darwin/SHA256SUMS.part
c793c9a958d3298048736fd3c2f5aa40bf9f39621dfbfe8d82b1d103500d349d  guix-build-5548818115c0/output/x86_64-apple-darwin/bitcoin-5548818115c0-x86_64-apple-darwin-codesigning.tar.gz
5de3e5a18d04375cb8150bc0e65a14a06c909d22dc8de4b600a1a0701c8ad7de  guix-build-5548818115c0/output/x86_64-apple-darwin/bitcoin-5548818115c0-x86_64-apple-darwin-unsigned.tar.gz
547131a4b444e0824fb15b8d15b40be5bd235eb52fcd8019efb00733f2ce4287  guix-build-5548818115c0/output/x86_64-apple-darwin/bitcoin-5548818115c0-x86_64-apple-darwin-unsigned.zip
5d1e843660b073fd179baae883efda52f29b1fbe5a384666205138b4f263a2fe  guix-build-5548818115c0/output/x86_64-linux-gnu/SHA256SUMS.part
1f03eb332d412cbd3642ef84e6090560a9b71f418a20ef186cf90bbb30889fda  guix-build-5548818115c0/output/x86_64-linux-gnu/bitcoin-5548818115c0-x86_64-linux-gnu-debug.tar.gz
c47c36e2c0ac1edfc9153cf854828d2da9aeb7a5e362eeeacaf672dc2d5398dd  guix-build-5548818115c0/output/x86_64-linux-gnu/bitcoin-5548818115c0-x86_64-linux-gnu.tar.gz
1ab186b177afbbe80e9fdb20d960a1f9c3e441e7c799f764d8ada975d2e6a548  guix-build-5548818115c0/output/x86_64-w64-mingw32/SHA256SUMS.part
b8161c5b3c679ee2978fb70034b87978ba298b3c3a7199f0610177e53110acb0  guix-build-5548818115c0/output/x86_64-w64-mingw32/bitcoin-5548818115c0-win64-codesigning.tar.gz
ab656ef94f36b6846502eb1cbf71ed049ad43efff2cbeab3c0663b7db8e1b8a0  guix-build-5548818115c0/output/x86_64-w64-mingw32/bitcoin-5548818115c0-win64-debug.zip
c271f2f51becf4b3625bac069f8498de8a0014fce5f3803dfdb84f1f276c64df  guix-build-5548818115c0/output/x86_64-w64-mingw32/bitcoin-5548818115c0-win64-setup-unsigned.exe
02d0273b50b8907fc8c112470d36015d53bbbb519050fb4e23c25da8d9ba0f9b  guix-build-5548818115c0/output/x86_64-w64-mingw32/bitcoin-5548818115c0-win64-unsigned.zip

hebasto approved

hebasto commented at 4:54 PM on August 17, 2026: member

ACK 5548818115c02d1e452a3240593b6e929c387d1d, tested on Ubuntu 24.04:

$ file bin/bitcoind
bin/bitcoind: ELF 64-bit LSB pie executable, ARM aarch64, version 1 (GNU/Linux), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 3.17.0, stripped

willcl-ark commented at 10:52 AM on August 18, 2026: member

x86_64
4063b7b56663a4bb26bea40ca1ef27e9053f66f8546b256512c0abac7bd388af  guix-build-5548818115c0/output/aarch64-linux-gnu/SHA256SUMS.part
fe090bfe735c9fd633774720215e4fe0d84df2c3bc58bb0187f57bc27f944f0b  guix-build-5548818115c0/output/aarch64-linux-gnu/bitcoin-5548818115c0-aarch64-linux-gnu-debug.tar.gz
c807c5d7d8a443d9a11d6abce0832c28906a5bef9ed79ed97ca965f3e1ff2a49  guix-build-5548818115c0/output/aarch64-linux-gnu/bitcoin-5548818115c0-aarch64-linux-gnu.tar.gz
983d417f0c9a02b3f336d7e5b808ca7dd6d16973f35fc7d7443d896354041c04  guix-build-5548818115c0/output/arm-linux-gnueabihf/SHA256SUMS.part
62057b725ebc65c0471a790b38ffc09eb1babdb5eb2c60d2328ace9382a55f55  guix-build-5548818115c0/output/arm-linux-gnueabihf/bitcoin-5548818115c0-arm-linux-gnueabihf-debug.tar.gz
b0fffb72aaebc7b3c128694fc9b67982861ccb9ee3ce8b2d0cd0e22570cf49b3  guix-build-5548818115c0/output/arm-linux-gnueabihf/bitcoin-5548818115c0-arm-linux-gnueabihf.tar.gz
b2641ea7a53f41c08d6de4453ad0a7f0fd625559715f3299a4f7949c0cedbd62  guix-build-5548818115c0/output/arm64-apple-darwin/SHA256SUMS.part
ef883aef674d8d99f0b0df4b4c272f45c3db2739f3c106a6890321dd2122abe5  guix-build-5548818115c0/output/arm64-apple-darwin/bitcoin-5548818115c0-arm64-apple-darwin-codesigning.tar.gz
12fa372c54e8bdc50c532c82dee2eeb8ad15ee6116aea74885d9cdf9f11ee112  guix-build-5548818115c0/output/arm64-apple-darwin/bitcoin-5548818115c0-arm64-apple-darwin-unsigned.tar.gz
88d93a9cad6c2950f8bfafa8dc19b880f6005bb71103e74b445e98a1fa2e06d2  guix-build-5548818115c0/output/arm64-apple-darwin/bitcoin-5548818115c0-arm64-apple-darwin-unsigned.zip
1b9b4e33e6366981102ff0c9d737eb3021c5e4268626c164390d8cf9e473db76  guix-build-5548818115c0/output/dist-archive/bitcoin-5548818115c0.tar.gz
e626e7a7d2c85e3b34de35841fa5737d102c8588e512522c09d7d13eb3989385  guix-build-5548818115c0/output/powerpc64-linux-gnu/SHA256SUMS.part
475955c1a7e8bfb16bb609db45ca871bdf8ba8c367a6b44a918861d9b7f2f387  guix-build-5548818115c0/output/powerpc64-linux-gnu/bitcoin-5548818115c0-powerpc64-linux-gnu-debug.tar.gz
ac612b3fb599fe8c363c6a3558b99471155141701965cc624196beb06607a612  guix-build-5548818115c0/output/powerpc64-linux-gnu/bitcoin-5548818115c0-powerpc64-linux-gnu.tar.gz
a8344b6e8989c6d9e2f1d3b441d57edcd6f4a8fcea43924551a98241218c70f0  guix-build-5548818115c0/output/riscv64-linux-gnu/SHA256SUMS.part
08b3a9face219e981b344a209c5ad8dc9e2e5df1dce4ea334706c24fe3ed41fc  guix-build-5548818115c0/output/riscv64-linux-gnu/bitcoin-5548818115c0-riscv64-linux-gnu-debug.tar.gz
76cd04fe595e3d2d127f62238544b2767e6238660752f1f9b984e0d2c3720c87  guix-build-5548818115c0/output/riscv64-linux-gnu/bitcoin-5548818115c0-riscv64-linux-gnu.tar.gz
7c10efcd7d96f9f45a4f812698d9503e7fc9e88d04c641b73939f7c7528662e5  guix-build-5548818115c0/output/x86_64-apple-darwin/SHA256SUMS.part
c793c9a958d3298048736fd3c2f5aa40bf9f39621dfbfe8d82b1d103500d349d  guix-build-5548818115c0/output/x86_64-apple-darwin/bitcoin-5548818115c0-x86_64-apple-darwin-codesigning.tar.gz
5de3e5a18d04375cb8150bc0e65a14a06c909d22dc8de4b600a1a0701c8ad7de  guix-build-5548818115c0/output/x86_64-apple-darwin/bitcoin-5548818115c0-x86_64-apple-darwin-unsigned.tar.gz
547131a4b444e0824fb15b8d15b40be5bd235eb52fcd8019efb00733f2ce4287  guix-build-5548818115c0/output/x86_64-apple-darwin/bitcoin-5548818115c0-x86_64-apple-darwin-unsigned.zip
5d1e843660b073fd179baae883efda52f29b1fbe5a384666205138b4f263a2fe  guix-build-5548818115c0/output/x86_64-linux-gnu/SHA256SUMS.part
1f03eb332d412cbd3642ef84e6090560a9b71f418a20ef186cf90bbb30889fda  guix-build-5548818115c0/output/x86_64-linux-gnu/bitcoin-5548818115c0-x86_64-linux-gnu-debug.tar.gz
c47c36e2c0ac1edfc9153cf854828d2da9aeb7a5e362eeeacaf672dc2d5398dd  guix-build-5548818115c0/output/x86_64-linux-gnu/bitcoin-5548818115c0-x86_64-linux-gnu.tar.gz
1ab186b177afbbe80e9fdb20d960a1f9c3e441e7c799f764d8ada975d2e6a548  guix-build-5548818115c0/output/x86_64-w64-mingw32/SHA256SUMS.part
b8161c5b3c679ee2978fb70034b87978ba298b3c3a7199f0610177e53110acb0  guix-build-5548818115c0/output/x86_64-w64-mingw32/bitcoin-5548818115c0-win64-codesigning.tar.gz
ab656ef94f36b6846502eb1cbf71ed049ad43efff2cbeab3c0663b7db8e1b8a0  guix-build-5548818115c0/output/x86_64-w64-mingw32/bitcoin-5548818115c0-win64-debug.zip
c271f2f51becf4b3625bac069f8498de8a0014fce5f3803dfdb84f1f276c64df  guix-build-5548818115c0/output/x86_64-w64-mingw32/bitcoin-5548818115c0-win64-setup-unsigned.exe
02d0273b50b8907fc8c112470d36015d53bbbb519050fb4e23c25da8d9ba0f9b  guix-build-5548818115c0/output/x86_64-w64-mingw32/bitcoin-5548818115c0-win64-unsigned.zip

willcl-ark approved

willcl-ark commented at 12:38 PM on August 18, 2026: member

ACK 5548818115c02d1e452a3240593b6e929c387d1d

hebasto merged this on Aug 18, 2026

hebasto closed this on Aug 18, 2026

willcl-ark commented at 12:49 PM on August 18, 2026: member

Also:

The higher the version number is, ... the faster the code gets.

I don't know how much difference it will actually make, but even the very oldest OSes are generally newer than 3.17: https://repology.org/project/linux/versions

bumping to 4.18 woudl bring us in line with CentOS 8, and 5.10 is the last maintained version currently...

As we have it working on 3.17 though also feels unnecessary to bump unless there is an actual (measured) performance benefit...

fanquake deleted the branch on Aug 18, 2026

fanquake commented at 12:58 PM on August 18, 2026: member

You can take a look through https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/unix/sysv/linux/kernel-features.h;h=85f6e888dba58fe7e4b27fc594d80e02092187f6;hb=HEAD, to get an idea of what is actually effected by changing the supplied kernel version.

willcl-ark commented at 3:49 PM on August 18, 2026: member

You can take a look through sourceware.org/git?p=glibc.git;a=blob;f=sysdeps/unix/sysv/linux/kernel-features.h;h=85f6e888dba58fe7e4b27fc594d80e02092187f6;hb=HEAD, to get an idea of what is actually effected by changing the supplied kernel version.

or not... 😄

willcl-ark commented at 4:04 PM on August 18, 2026: member

My clanker doesn't think it's worthwhile, but I didn't double check its opinion:

<details> <summary>Details</summary>

Rebuilding glibc with --enable-kernel=4.18 would mainly enable unconditional use of mlock2 and statx.
--enable-kernel=5.10 additionally enables clone3, faccessat2, and close_range. The time64 change is irrelevant for our x86_64 binaries.

Bitcoin Core does not appear to directly use these newer interfaces in performance-critical paths. The likely benefits are limited to small improvements in process startup, file-descriptor cleanup, or metadata-heavy Qt/filesystem operations. No meaningful steady-state validation, validation, networking, or database speedup is apparent from this diff.

My recommendation: don’t raise the kernel baseline for performance alone. If we want a cleaner modern baseline for other reasons, 5.10 is more worthwhile than 4.18, but it should be justified by support/maintenance policy and confirmed with startup, wallet-open, reindex, and GUI benchmarks.

</details>

janb84 commented at 5:38 PM on August 18, 2026: contributor

Guix Build Output

Host architecture: aarch64 Commit: 5548818

4063b7b56663a4bb26bea40ca1ef27e9053f66f8546b256512c0abac7bd388af  guix-build-5548818115c0/output/aarch64-linux-gnu/SHA256SUMS.part
fe090bfe735c9fd633774720215e4fe0d84df2c3bc58bb0187f57bc27f944f0b  guix-build-5548818115c0/output/aarch64-linux-gnu/bitcoin-5548818115c0-aarch64-linux-gnu-debug.tar.gz
c807c5d7d8a443d9a11d6abce0832c28906a5bef9ed79ed97ca965f3e1ff2a49  guix-build-5548818115c0/output/aarch64-linux-gnu/bitcoin-5548818115c0-aarch64-linux-gnu.tar.gz
983d417f0c9a02b3f336d7e5b808ca7dd6d16973f35fc7d7443d896354041c04  guix-build-5548818115c0/output/arm-linux-gnueabihf/SHA256SUMS.part
62057b725ebc65c0471a790b38ffc09eb1babdb5eb2c60d2328ace9382a55f55  guix-build-5548818115c0/output/arm-linux-gnueabihf/bitcoin-5548818115c0-arm-linux-gnueabihf-debug.tar.gz
b0fffb72aaebc7b3c128694fc9b67982861ccb9ee3ce8b2d0cd0e22570cf49b3  guix-build-5548818115c0/output/arm-linux-gnueabihf/bitcoin-5548818115c0-arm-linux-gnueabihf.tar.gz
b2641ea7a53f41c08d6de4453ad0a7f0fd625559715f3299a4f7949c0cedbd62  guix-build-5548818115c0/output/arm64-apple-darwin/SHA256SUMS.part
ef883aef674d8d99f0b0df4b4c272f45c3db2739f3c106a6890321dd2122abe5  guix-build-5548818115c0/output/arm64-apple-darwin/bitcoin-5548818115c0-arm64-apple-darwin-codesigning.tar.gz
12fa372c54e8bdc50c532c82dee2eeb8ad15ee6116aea74885d9cdf9f11ee112  guix-build-5548818115c0/output/arm64-apple-darwin/bitcoin-5548818115c0-arm64-apple-darwin-unsigned.tar.gz
88d93a9cad6c2950f8bfafa8dc19b880f6005bb71103e74b445e98a1fa2e06d2  guix-build-5548818115c0/output/arm64-apple-darwin/bitcoin-5548818115c0-arm64-apple-darwin-unsigned.zip
1b9b4e33e6366981102ff0c9d737eb3021c5e4268626c164390d8cf9e473db76  guix-build-5548818115c0/output/dist-archive/bitcoin-5548818115c0.tar.gz
e626e7a7d2c85e3b34de35841fa5737d102c8588e512522c09d7d13eb3989385  guix-build-5548818115c0/output/powerpc64-linux-gnu/SHA256SUMS.part
475955c1a7e8bfb16bb609db45ca871bdf8ba8c367a6b44a918861d9b7f2f387  guix-build-5548818115c0/output/powerpc64-linux-gnu/bitcoin-5548818115c0-powerpc64-linux-gnu-debug.tar.gz
ac612b3fb599fe8c363c6a3558b99471155141701965cc624196beb06607a612  guix-build-5548818115c0/output/powerpc64-linux-gnu/bitcoin-5548818115c0-powerpc64-linux-gnu.tar.gz
a8344b6e8989c6d9e2f1d3b441d57edcd6f4a8fcea43924551a98241218c70f0  guix-build-5548818115c0/output/riscv64-linux-gnu/SHA256SUMS.part
08b3a9face219e981b344a209c5ad8dc9e2e5df1dce4ea334706c24fe3ed41fc  guix-build-5548818115c0/output/riscv64-linux-gnu/bitcoin-5548818115c0-riscv64-linux-gnu-debug.tar.gz
76cd04fe595e3d2d127f62238544b2767e6238660752f1f9b984e0d2c3720c87  guix-build-5548818115c0/output/riscv64-linux-gnu/bitcoin-5548818115c0-riscv64-linux-gnu.tar.gz
7c10efcd7d96f9f45a4f812698d9503e7fc9e88d04c641b73939f7c7528662e5  guix-build-5548818115c0/output/x86_64-apple-darwin/SHA256SUMS.part
c793c9a958d3298048736fd3c2f5aa40bf9f39621dfbfe8d82b1d103500d349d  guix-build-5548818115c0/output/x86_64-apple-darwin/bitcoin-5548818115c0-x86_64-apple-darwin-codesigning.tar.gz
5de3e5a18d04375cb8150bc0e65a14a06c909d22dc8de4b600a1a0701c8ad7de  guix-build-5548818115c0/output/x86_64-apple-darwin/bitcoin-5548818115c0-x86_64-apple-darwin-unsigned.tar.gz
547131a4b444e0824fb15b8d15b40be5bd235eb52fcd8019efb00733f2ce4287  guix-build-5548818115c0/output/x86_64-apple-darwin/bitcoin-5548818115c0-x86_64-apple-darwin-unsigned.zip
5d1e843660b073fd179baae883efda52f29b1fbe5a384666205138b4f263a2fe  guix-build-5548818115c0/output/x86_64-linux-gnu/SHA256SUMS.part
1f03eb332d412cbd3642ef84e6090560a9b71f418a20ef186cf90bbb30889fda  guix-build-5548818115c0/output/x86_64-linux-gnu/bitcoin-5548818115c0-x86_64-linux-gnu-debug.tar.gz
c47c36e2c0ac1edfc9153cf854828d2da9aeb7a5e362eeeacaf672dc2d5398dd  guix-build-5548818115c0/output/x86_64-linux-gnu/bitcoin-5548818115c0-x86_64-linux-gnu.tar.gz
1ab186b177afbbe80e9fdb20d960a1f9c3e441e7c799f764d8ada975d2e6a548  guix-build-5548818115c0/output/x86_64-w64-mingw32/SHA256SUMS.part
b8161c5b3c679ee2978fb70034b87978ba298b3c3a7199f0610177e53110acb0  guix-build-5548818115c0/output/x86_64-w64-mingw32/bitcoin-5548818115c0-win64-codesigning.tar.gz
ab656ef94f36b6846502eb1cbf71ed049ad43efff2cbeab3c0663b7db8e1b8a0  guix-build-5548818115c0/output/x86_64-w64-mingw32/bitcoin-5548818115c0-win64-debug.zip
c271f2f51becf4b3625bac069f8498de8a0014fce5f3803dfdb84f1f276c64df  guix-build-5548818115c0/output/x86_64-w64-mingw32/bitcoin-5548818115c0-win64-setup-unsigned.exe
02d0273b50b8907fc8c112470d36015d53bbbb519050fb4e23c25da8d9ba0f9b  guix-build-5548818115c0/output/x86_64-w64-mingw32/bitcoin-5548818115c0-win64-unsigned.zip

janb84 commented at 5:41 PM on August 18, 2026: contributor

post merge ACK 5548818115c02d1e452a3240593b6e929c387d1d

I like the re-ordering in the code, see above for my GUIX build but i have not tested the binary