Remove unused code.
miniscript: remove unused context argument from ParseHexStr #36009
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:ParseHexStr_noctx changing 1 files +5 −7-
fanquake commented at 9:33 AM on August 18, 2026: member
-
miniscript: remove unused context argument from ParseHexStr 1fdd208c1c
- DrahtBot added the label Descriptors on Aug 18, 2026
-
DrahtBot commented at 9:33 AM on August 18, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36009.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process.
Type Reviewers ACK stickies-v, sedited If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
LLM Linter (✨ experimental)
Possible places where named args for integral literals may be used (e.g.
func(x, /*named_arg=*/0)in C++, andfunc(x, named_arg=0)in Python):ParseHexStr("sha256", in, 32)insrc/script/miniscript.hParseHexStr("ripemd160", in, 20)insrc/script/miniscript.hParseHexStr("hash256", in, 32)insrc/script/miniscript.hParseHexStr("hash160", in, 20)insrc/script/miniscript.h
<sup>2026-08-18 09:34:01</sup>
- stickies-v approved
-
stickies-v commented at 12:18 PM on August 18, 2026: contributor
ACK 1fdd208c1ce32ae2385069f39e7d78972213424a
This was introduced in 1ddaa66eae67b102f5e37d212d366a5dcad4aa26 without any usage, seems fine to remove.
- sedited approved
-
sedited commented at 3:55 PM on August 18, 2026: contributor
ACK 1fdd208c1ce32ae2385069f39e7d78972213424a
- sedited merged this on Aug 18, 2026
- sedited closed this on Aug 18, 2026
- fanquake deleted the branch on Aug 18, 2026
Contributors
Labels