This PR continues the ongoing effort to enforce IWYU warnings.
See Developer Notes.
Marked as draft to let the conflicting #36112 be reviewed and landed first.
iwyu: Fix warnings in `src/rpc` and treat them as errors #36116
pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:260828-iwyu-rpc changing 29 files +316 −94-
hebasto commented at 3:08 PM on August 28, 2026: member
-
080d6833e6
iwyu, refactor: Fix includes in some source files
This change is required for the subsequent commit to compile.
-
iwyu: Fix warnings in `src/rpc` and treat them as errors a02d65eb3f
- hebasto added the label Refactoring on Aug 28, 2026
-
DrahtBot commented at 3:08 PM on August 28, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36116.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process. A summary of reviews will appear here.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #36112 (ci: Exclude subtrees from iwyu by maflcko)
- #36087 (util: Add and use AssertUnreachable by maflcko)
- #36005 (rpc, descriptor: warn when multipath expansion clones single-path key expressions by pythcoiner)
- #36002 (txindex: allow running in pruned mode by andrewtoth)
- #35733 (sign: Remove FillableSigningProvider by achow101)
- #35281 (univalue: respect token end pointer by ferminquant)
- #33741 (rpc: Optionally print feerates in sat/vb by polespinasa)
- #33117 (Interfaces: Expose UTXO Snapshot Loading and Add Progress Notifications by D33r-Gee)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
Labels