test_framework.py already uses PREVIOUS_RELEASES_DIR to set a default directory to find previous releases, so should get_previous_releases.py when fetching them.
This is more convenient for local development when using multiple worktrees where having $PREVIOUS_RELEASES_DIR set is useful.
Also allows some CI code to get deleted.
LLM Usage Disclosure: Qwen3.8-0.5B generated the next 800,000 pages of my epistolary novel while I made this PR.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36195.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline and AI policy for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | hodlinator, willcl-ark |
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
267 | help='remove existing directory.')
268 | parser.add_argument('-t', '--target-dir', action='store',
269 | - help='target directory.', default='releases')
270 | + default=previous_releases_path,
271 | + help='target directory, defaults to '
272 | + 'environment\'s PREVIOUS_RELEASE_DIR if set, '
In ab30c9f232f0b038b1edd012dcd3a4218e27a103
tiny typo here in helptext only:
PREVIOUS_RELEASE_DIR -> PREVIOUS_RELEASES_DIR
thanks, fixed.
ACK ab30c9f232f0b038b1edd012dcd3a4218e27a103
Looks good. I've bumped into this before myself but not bothered to fix, so thanks.
Left a tiny doc nit.
Concept ACK ab30c9f232f0b038b1edd012dcd3a4218e27a103
Seems quite useful in my workflow as well.
Would be good to address #36195 (review)
`test_framework.py` already uses `PREVIOUS_RELEASES_DIR` to set a
default directory to find previous releases, so should
`get_previous_releases.py` when fetching them.
This is more convenient for local development when using multiple
worktrees where having `$PREVIOUS_RELEASES_DIR` set is useful.
Also allows some CI code to get deleted.
Pushed to fix the helptext typo.
ACK ecdf9db906b4d09e780371fd6e7fe420ecdc87f9
PREVIOUS_RELEASES_DIR is now in my nix dev env, so I can reset my worktrees without having to patch the ELF files of old releases with the correct ld-linux-x86-64.so.2 from my nix store as often.
Tested through running a couple of functional tests requiring previous releases and verified that they were using the intended directory outside of the git tree and that the /releases directory inside of the git tree didn't get recreated.
PREVIOUS_RELEASES_DIRis now in my nix dev env, so I can reset my worktrees without having to patch the ELF files of old releases with the correct ld-linux-x86-64.so.2 from my nix store as often.
haha amen! I'll also be happy not to have to patch these so often too :D
ACK ecdf9db906b4d09e780371fd6e7fe420ecdc87f9